* [PATCH] pinctrl: tegra238: remove unused entries
@ 2026-05-29 9:41 Arnd Bergmann
2026-05-29 19:59 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2026-05-29 9:41 UTC (permalink / raw)
To: Linus Walleij, Thierry Reding, Jonathan Hunter, Prathamesh Shete
Cc: Arnd Bergmann, linux-gpio, linux-tegra, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The -Wunused-const-variable check points out a number of added
entries that are currently not referenced:
drivers/pinctrl/tegra/pinctrl-tegra238.c:1169:27: error: 'soc_gpio86_phh3_pins' defined but not used [-Werror=unused-const-variable=]
1169 | static const unsigned int soc_gpio86_phh3_pins[] = {
| ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra238.c:1165:27: error: 'uart5_cts_phh2_pins' defined but not used [-Werror=unused-const-variable=]
1165 | static const unsigned int uart5_cts_phh2_pins[] = {
| ^~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra238.c:1161:27: error: 'uart5_rts_phh1_pins' defined but not used [-Werror=unused-const-variable=]
1161 | static const unsigned int uart5_rts_phh1_pins[] = {
| ^~~~~~~~~~~~~~~~~~~
Remove them for now, they can just be added back if they get
used in the future.
Fixes: 25cac7292d49 ("pinctrl: tegra: Add Tegra238 pinmux driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/tegra/pinctrl-tegra238.c | 96 ------------------------
1 file changed, 96 deletions(-)
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra238.c b/drivers/pinctrl/tegra/pinctrl-tegra238.c
index 421da334151c..c765b6b880e5 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra238.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra238.c
@@ -1074,102 +1074,6 @@ static const unsigned int pwm7_pee1_pins[] = {
TEGRA_PIN_PWM7_PEE1,
};
-static const unsigned int soc_gpio49_pee2_pins[] = {
- TEGRA_PIN_SOC_GPIO49_PEE2,
-};
-
-static const unsigned int soc_gpio82_pee3_pins[] = {
- TEGRA_PIN_SOC_GPIO82_PEE3,
-};
-
-static const unsigned int soc_gpio50_pee4_pins[] = {
- TEGRA_PIN_SOC_GPIO50_PEE4,
-};
-
-static const unsigned int soc_gpio83_pee5_pins[] = {
- TEGRA_PIN_SOC_GPIO83_PEE5,
-};
-
-static const unsigned int soc_gpio69_pff0_pins[] = {
- TEGRA_PIN_SOC_GPIO69_PFF0,
-};
-
-static const unsigned int soc_gpio70_pff1_pins[] = {
- TEGRA_PIN_SOC_GPIO70_PFF1,
-};
-
-static const unsigned int soc_gpio71_pff2_pins[] = {
- TEGRA_PIN_SOC_GPIO71_PFF2,
-};
-
-static const unsigned int soc_gpio72_pff3_pins[] = {
- TEGRA_PIN_SOC_GPIO72_PFF3,
-};
-
-static const unsigned int soc_gpio73_pff4_pins[] = {
- TEGRA_PIN_SOC_GPIO73_PFF4,
-};
-
-static const unsigned int soc_gpio74_pff5_pins[] = {
- TEGRA_PIN_SOC_GPIO74_PFF5,
-};
-
-static const unsigned int soc_gpio80_pff6_pins[] = {
- TEGRA_PIN_SOC_GPIO80_PFF6,
-};
-
-static const unsigned int soc_gpio76_pff7_pins[] = {
- TEGRA_PIN_SOC_GPIO76_PFF7,
-};
-
-static const unsigned int soc_gpio77_pgg0_pins[] = {
- TEGRA_PIN_SOC_GPIO77_PGG0,
-};
-
-static const unsigned int soc_gpio84_pgg1_pins[] = {
- TEGRA_PIN_SOC_GPIO84_PGG1,
-};
-
-static const unsigned int uart2_tx_pgg2_pins[] = {
- TEGRA_PIN_UART2_TX_PGG2,
-};
-
-static const unsigned int uart2_rx_pgg3_pins[] = {
- TEGRA_PIN_UART2_RX_PGG3,
-};
-
-static const unsigned int uart2_rts_pgg4_pins[] = {
- TEGRA_PIN_UART2_RTS_PGG4,
-};
-
-static const unsigned int uart2_cts_pgg5_pins[] = {
- TEGRA_PIN_UART2_CTS_PGG5,
-};
-
-static const unsigned int soc_gpio85_pgg6_pins[] = {
- TEGRA_PIN_SOC_GPIO85_PGG6,
-};
-
-static const unsigned int uart5_tx_pgg7_pins[] = {
- TEGRA_PIN_UART5_TX_PGG7,
-};
-
-static const unsigned int uart5_rx_phh0_pins[] = {
- TEGRA_PIN_UART5_RX_PHH0,
-};
-
-static const unsigned int uart5_rts_phh1_pins[] = {
- TEGRA_PIN_UART5_RTS_PHH1,
-};
-
-static const unsigned int uart5_cts_phh2_pins[] = {
- TEGRA_PIN_UART5_CTS_PHH2,
-};
-
-static const unsigned int soc_gpio86_phh3_pins[] = {
- TEGRA_PIN_SOC_GPIO86_PHH3,
-};
-
static const unsigned int sdmmc1_comp_pins[] = {
TEGRA_PIN_SDMMC1_COMP,
};
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] pinctrl: tegra238: remove unused entries
2026-05-29 9:41 [PATCH] pinctrl: tegra238: remove unused entries Arnd Bergmann
@ 2026-05-29 19:59 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2026-05-29 19:59 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Thierry Reding, Jonathan Hunter, Prathamesh Shete, Arnd Bergmann,
linux-gpio, linux-tegra, linux-kernel
On Fri, May 29, 2026 at 11:41 AM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The -Wunused-const-variable check points out a number of added
> entries that are currently not referenced:
Patch applied.
I guess these entries actually exist in the hardware though, they have
just not been attached to groups.
But it's easy to just restore this when needed so no big deal.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-29 19:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-29 9:41 [PATCH] pinctrl: tegra238: remove unused entries Arnd Bergmann
2026-05-29 19:59 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox