* [PATCH RESEND] staging: nvec: use strcmp() instead of strncmp() with magic length
@ 2026-07-23 16:18 Artem Lytkin
0 siblings, 0 replies; only message in thread
From: Artem Lytkin @ 2026-07-23 16:18 UTC (permalink / raw)
To: linux-staging; +Cc: gregkh, marvin24, linux-tegra
Replace strncmp() with a hardcoded length of 30 with strcmp().
The bat_type string is already null-terminated (set two lines above),
so strncmp() with an arbitrary length is misleading and functionally
equivalent to strcmp().
Signed-off-by: Artem Lytkin <iprintercanon@gmail.com>
---
drivers/staging/nvec/nvec_power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec_power.c b/drivers/staging/nvec/nvec_power.c
index 2faab9fdedef7..89dd997aaf36b 100644
--- a/drivers/staging/nvec/nvec_power.c
+++ b/drivers/staging/nvec/nvec_power.c
@@ -207,7 +207,7 @@ static int nvec_power_bat_notifier(struct notifier_block *nb,
* This differs a little from the spec fill in more if you find
* some.
*/
- if (!strncmp(power->bat_type, "Li", 30))
+ if (!strcmp(power->bat_type, "Li"))
power->bat_type_enum = POWER_SUPPLY_TECHNOLOGY_LION;
else
power->bat_type_enum = POWER_SUPPLY_TECHNOLOGY_UNKNOWN;
--
2.43.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-07-23 16:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 16:18 [PATCH RESEND] staging: nvec: use strcmp() instead of strncmp() with magic length Artem Lytkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox