* [PATCH 05/11] usb: gadget: Remove redundant dev_err()
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
@ 2026-07-31 3:54 ` Pan Chuang
2026-07-31 22:41 ` Herve Codina
2026-07-31 3:54 ` [PATCH 06/11] usb: host: xhci-tegra: " Pan Chuang
1 sibling, 1 reply; 4+ messages in thread
From: Pan Chuang @ 2026-07-31 3:54 UTC (permalink / raw)
To: Greg Kroah-Hartman, Joel Stanley, Andrew Jeffery, Neal Liu,
Cristian Birsan, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
Herve Codina, Thierry Reding, Jonathan Hunter,
open list:USB SUBSYSTEM,
moderated list:ARM/ASPEED MACHINE SUPPORT,
moderated list:ARM/ASPEED MACHINE SUPPORT, open list,
open list:RENESAS RZ/N1 USBF CONTROLLER DRIVER,
open list:TEGRA ARCHITECTURE SUPPORT
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/usb/gadget/udc/aspeed-vhub/core.c | 4 +---
drivers/usb/gadget/udc/aspeed_udc.c | 4 +---
drivers/usb/gadget/udc/atmel_usba_udc.c | 5 +----
drivers/usb/gadget/udc/r8a66597-udc.c | 4 +---
drivers/usb/gadget/udc/renesas_usbf.c | 8 ++------
drivers/usb/gadget/udc/snps_udc_plat.c | 4 +---
drivers/usb/gadget/udc/tegra-xudc.c | 5 +----
7 files changed, 8 insertions(+), 26 deletions(-)
diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c b/drivers/usb/gadget/udc/aspeed-vhub/core.c
index 4a8b9ff8368f..4ac990553a86 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/core.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/core.c
@@ -379,10 +379,8 @@ static int ast_vhub_probe(struct platform_device *pdev)
}
rc = devm_request_irq(&pdev->dev, vhub->irq, ast_vhub_irq, 0,
KBUILD_MODNAME, vhub);
- if (rc) {
- dev_err(&pdev->dev, "Failed to request interrupt\n");
+ if (rc)
goto err;
- }
dma_mask_ptr = (u64 *)of_device_get_match_data(&pdev->dev);
if (dma_mask_ptr) {
diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 54f81e668009..08b24902c7b9 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1568,10 +1568,8 @@ static int ast_udc_probe(struct platform_device *pdev)
rc = devm_request_irq(&pdev->dev, udc->irq, ast_udc_isr, 0,
KBUILD_MODNAME, udc);
- if (rc) {
- dev_err(&pdev->dev, "Failed to request interrupt\n");
+ if (rc)
goto err_cleanup;
- }
rc = usb_add_gadget_udc(&pdev->dev, &udc->gadget);
if (rc) {
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 72a2f95ff018..18b4b2358d1e 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -2332,11 +2332,8 @@ static int usba_udc_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, irq, usba_udc_irq, 0,
"atmel_usba_udc", udc);
- if (ret) {
- dev_err(&pdev->dev, "Cannot request irq %d (error %d)\n",
- irq, ret);
+ if (ret)
return ret;
- }
udc->irq = irq;
if (udc->vbus_pin) {
diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c
index d190e16d43fc..915786c9628c 100644
--- a/drivers/usb/gadget/udc/r8a66597-udc.c
+++ b/drivers/usb/gadget/udc/r8a66597-udc.c
@@ -1894,10 +1894,8 @@ static int r8a66597_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, irq, r8a66597_irq, IRQF_SHARED,
udc_name, r8a66597);
- if (ret < 0) {
- dev_err(dev, "request_irq error (%d)\n", ret);
+ if (ret < 0)
goto clean_up2;
- }
INIT_LIST_HEAD(&r8a66597->gadget.ep_list);
r8a66597->gadget.ep0 = &r8a66597->ep[0].ep;
diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c
index d67002ea049a..367c9e73f366 100644
--- a/drivers/usb/gadget/udc/renesas_usbf.c
+++ b/drivers/usb/gadget/udc/renesas_usbf.c
@@ -3335,19 +3335,15 @@ static int usbf_probe(struct platform_device *pdev)
if (irq < 0)
return irq;
ret = devm_request_irq(dev, irq, usbf_epc_irq, 0, "usbf-epc", udc);
- if (ret) {
- dev_err(dev, "cannot request irq %d err %d\n", irq, ret);
+ if (ret)
return ret;
- }
irq = platform_get_irq(pdev, 1);
if (irq < 0)
return irq;
ret = devm_request_irq(dev, irq, usbf_ahb_epc_irq, 0, "usbf-ahb-epc", udc);
- if (ret) {
- dev_err(dev, "cannot request irq %d err %d\n", irq, ret);
+ if (ret)
return ret;
- }
usbf_reg_bitset(udc, USBF_REG_AHBMCTR, USBF_SYS_WBURST_TYPE);
diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
index db842a6de643..9e4f04476595 100644
--- a/drivers/usb/gadget/udc/snps_udc_plat.c
+++ b/drivers/usb/gadget/udc/snps_udc_plat.c
@@ -193,10 +193,8 @@ static int udc_plat_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, udc->irq, udc_irq, IRQF_SHARED,
"snps-udc", udc);
- if (ret < 0) {
- dev_err(dev, "Request irq %d failed for UDC\n", udc->irq);
+ if (ret < 0)
goto exit_dma;
- }
platform_set_drvdata(pdev, udc);
udc->chiprev = UDC_BCM_REV;
diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
index e9d33be02866..5042c13f92be 100644
--- a/drivers/usb/gadget/udc/tegra-xudc.c
+++ b/drivers/usb/gadget/udc/tegra-xudc.c
@@ -3803,11 +3803,8 @@ static int tegra_xudc_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, xudc->irq, tegra_xudc_irq, 0,
dev_name(&pdev->dev), xudc);
- if (err < 0) {
- dev_err(xudc->dev, "failed to claim IRQ#%u: %d\n", xudc->irq,
- err);
+ if (err < 0)
return err;
- }
xudc->clks = devm_kcalloc(&pdev->dev, xudc->soc->num_clks, sizeof(*xudc->clks),
GFP_KERNEL);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 06/11] usb: host: xhci-tegra: Remove redundant dev_err()
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-31 3:54 ` [PATCH 05/11] usb: gadget: Remove redundant dev_err() Pan Chuang
@ 2026-07-31 3:54 ` Pan Chuang
1 sibling, 0 replies; 4+ messages in thread
From: Pan Chuang @ 2026-07-31 3:54 UTC (permalink / raw)
To: Mathias Nyman, Greg Kroah-Hartman, Thierry Reding,
Jonathan Hunter, open list:USB XHCI DRIVER,
open list:TEGRA ARCHITECTURE SUPPORT, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/usb/host/xhci-tegra.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
index e7e6d569f1db..626a41804cd6 100644
--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -1908,20 +1908,16 @@ static int tegra_xusb_probe(struct platform_device *pdev)
tegra_xusb_mbox_irq,
tegra_xusb_mbox_thread, 0,
dev_name(&pdev->dev), tegra);
- if (err < 0) {
- dev_err(&pdev->dev, "failed to request IRQ: %d\n", err);
+ if (err < 0)
goto remove_usb3;
- }
if (tegra->padctl_irq) {
err = devm_request_threaded_irq(&pdev->dev, tegra->padctl_irq,
NULL, tegra_xusb_padctl_irq,
IRQF_ONESHOT, dev_name(&pdev->dev),
tegra);
- if (err < 0) {
- dev_err(&pdev->dev, "failed to request padctl IRQ: %d\n", err);
+ if (err < 0)
goto remove_usb3;
- }
}
err = tegra_xusb_enable_firmware_messages(tegra);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread