* [PATCH RESEND] drm/tegra: dc: fix reference leak in tegra_dc_couple()
@ 2025-10-22 11:47 Ma Ke
2025-10-23 4:32 ` Mikko Perttunen
0 siblings, 1 reply; 2+ messages in thread
From: Ma Ke @ 2025-10-22 11:47 UTC (permalink / raw)
To: thierry.reding, mperttunen, airlied, simona, jonathanh
Cc: dri-devel, linux-tegra, linux-kernel, akpm, Ma Ke, stable
driver_find_device() calls get_device() to increment the reference
count once a matching device is found, but there is no put_device() to
balance the reference count. To avoid reference count leakage, add
put_device() to decrease the reference count.
Found by code review.
Cc: stable@vger.kernel.org
Fixes: a31500fe7055 ("drm/tegra: dc: Restore coupling of display controllers")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
drivers/gpu/drm/tegra/dc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index 59d5c1ba145a..6c84bd69b11f 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -3148,6 +3148,7 @@ static int tegra_dc_couple(struct tegra_dc *dc)
dc->client.parent = &parent->client;
dev_dbg(dc->dev, "coupled to %s\n", dev_name(companion));
+ put_device(companion);
}
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] drm/tegra: dc: fix reference leak in tegra_dc_couple()
2025-10-22 11:47 [PATCH RESEND] drm/tegra: dc: fix reference leak in tegra_dc_couple() Ma Ke
@ 2025-10-23 4:32 ` Mikko Perttunen
0 siblings, 0 replies; 2+ messages in thread
From: Mikko Perttunen @ 2025-10-23 4:32 UTC (permalink / raw)
To: thierry.reding, airlied, simona, jonathanh, Ma Ke
Cc: dri-devel, linux-tegra, linux-kernel, akpm, Ma Ke, stable
On Wednesday, October 22, 2025 8:47 PM Ma Ke wrote:
> driver_find_device() calls get_device() to increment the reference
> count once a matching device is found, but there is no put_device() to
> balance the reference count. To avoid reference count leakage, add
> put_device() to decrease the reference count.
>
> Found by code review.
>
> Cc: stable@vger.kernel.org
> Fixes: a31500fe7055 ("drm/tegra: dc: Restore coupling of display controllers")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> drivers/gpu/drm/tegra/dc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
> index 59d5c1ba145a..6c84bd69b11f 100644
> --- a/drivers/gpu/drm/tegra/dc.c
> +++ b/drivers/gpu/drm/tegra/dc.c
> @@ -3148,6 +3148,7 @@ static int tegra_dc_couple(struct tegra_dc *dc)
> dc->client.parent = &parent->client;
>
> dev_dbg(dc->dev, "coupled to %s\n", dev_name(companion));
> + put_device(companion);
> }
>
> return 0;
>
Acked-by: Mikko Perttunen <mperttunen@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-23 4:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-22 11:47 [PATCH RESEND] drm/tegra: dc: fix reference leak in tegra_dc_couple() Ma Ke
2025-10-23 4:32 ` Mikko Perttunen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox