Re: [PATCH v4 10/12] ARM: tegra: Add External Memory Controller node on Tegra114

[Mikko Perttunen <mperttunen@nvidia.com>]

On Tuesday, November 25, 2025 9:05 PM Svyatoslav Ryhel wrote:
> Add External Memory Controller node to the device-tree.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  arch/arm/boot/dts/nvidia/tegra114.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nvidia/tegra114.dtsi b/arch/arm/boot/dts/nvidia/tegra114.dtsi
> index ef0618e9eec1..a920ad041c14 100644
> --- a/arch/arm/boot/dts/nvidia/tegra114.dtsi
> +++ b/arch/arm/boot/dts/nvidia/tegra114.dtsi
> @@ -259,6 +259,8 @@ tegra_car: clock@60006000 {
>  		reg = <0x60006000 0x1000>;
>  		#clock-cells = <1>;
>  		#reset-cells = <1>;
> +
> +		nvidia,external-memory-controller = <&emc>;
>  	};
>  
>  	flow-controller@60007000 {
> @@ -655,6 +657,16 @@ mc: memory-controller@70019000 {
>  		#iommu-cells = <1>;
>  	};
>  
> +	emc: external-memory-controller@7001b000 {
> +		compatible = "nvidia,tegra114-emc";
> +		reg = <0x7001b000 0x1000>;

The TRM says that the aperture is 2K in size. Otherwise LGTM.

Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>

> +		interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&tegra_car TEGRA114_CLK_EMC>;
> +		clock-names = "emc";
> +
> +		nvidia,memory-controller = <&mc>;
> +	};
> +
>  	hda@70030000 {
>  		compatible = "nvidia,tegra114-hda", "nvidia,tegra30-hda";
>  		reg = <0x70030000 0x10000>;
>