Linux Tegra architecture development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Thierry Reding <treding@nvidia.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Prashant Gaikwad <pgaikwad@nvidia.com>,
	Mikko Perttunen <mperttunen@nvidia.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Dmitry Osipenko <digetx@gmail.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 00/12] Tegra114: implement EMC support
Date: Mon, 1 Dec 2025 08:18:00 +0100	[thread overview]
Message-ID: <b011f973-146f-4672-8e2b-9373eddbec3a@kernel.org> (raw)
In-Reply-To: <CAPVz0n1nk30=UwR5344c+rk=n6LCn-nnzLCf=CRfWOUPDw-rqA@mail.gmail.com>

On 01/12/2025 07:12, Svyatoslav Ryhel wrote:
> ср, 26 лист. 2025 р. о 10:47 Krzysztof Kozlowski <krzk@kernel.org> пише:
>>
>> On 25/11/2025 13:05, Svyatoslav Ryhel wrote:
>>> Add support for External Memory Controller found in Tegra 4 SoC along
>>> with adjustments required for it to work properly.
>>>
>>> Tested on ASUS TF701T (T40X) and Nvidia Tegratab (T40S). Both work fine.
>>
>> You mixed here FOUR independent subsystems and without any explanation
>> of the dependencies it means things are just harder for us to handle for
>> no reason.
>>
>> Please split independent subsystems or clearly document the merging
>> issues/dependencies.
>>
> 
> All commits are independent and subsystem maintainers can pick commits
> which are relevant for their domain. No regressions at the build time
> nor on the device itself were detected with individual commits picked.
> Only device tree changes are preferred to be picked last.
> 
> Patchset is made this way to show logic of implementation of EMC
> support for Tegra114 since a list of links between fragmented
> patchsets will not bring clarity nor it will improve merging
> experience.

This is clearly not true statement and it is not you who will merged
that. Instead of just applying it with one command, maintainers will
have to use several to find/pick up individual bits.

You received comment, I expect implementing it. I am not going through
this patchset.

Best regards,
Krzysztof

      reply	other threads:[~2025-12-01  7:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 12:05 [PATCH v4 00/12] Tegra114: implement EMC support Svyatoslav Ryhel
2025-11-25 12:05 ` [PATCH v4 01/12] devfreq: tegra30-devfreq: add support for Tegra114 Svyatoslav Ryhel
2026-01-20  6:56   ` Mikko Perttunen
2025-11-25 12:05 ` [PATCH v4 02/12] ARM: tegra: Add ACTMON node to Tegra114 device tree Svyatoslav Ryhel
2025-11-25 12:05 ` [PATCH v4 03/12] dt-bindings: memory: Document Tegra114 Memory Controller Svyatoslav Ryhel
2025-12-04 18:11   ` Rob Herring (Arm)
2025-11-25 12:05 ` [PATCH v4 04/12] memory: tegra: implement EMEM regs and ICC ops for Tegra114 Svyatoslav Ryhel
2025-11-25 12:05 ` [PATCH v4 05/12] dt-bindings: memory: Add Tegra114 memory client IDs Svyatoslav Ryhel
2025-11-25 12:05 ` [PATCH v4 06/12] clk: tegra: set up proper EMC clock implementation for Tegra114 Svyatoslav Ryhel
2026-01-20  7:01   ` Mikko Perttunen
2025-11-25 12:05 ` [PATCH v4 07/12] dt-bindings: memory: Document Tegra114 External Memory Controller Svyatoslav Ryhel
2025-12-04 18:12   ` Rob Herring (Arm)
2025-11-25 12:05 ` [PATCH v4 08/12] soc: tegra: common: add Tegra114 support to devm_tegra_core_dev_init_opp_table Svyatoslav Ryhel
2026-01-20  7:05   ` Mikko Perttunen
2025-11-25 12:05 ` [PATCH v4 09/12] memory: tegra: Add Tegra114 EMC driver Svyatoslav Ryhel
2026-01-20  7:07   ` Mikko Perttunen
2025-11-25 12:05 ` [PATCH v4 10/12] ARM: tegra: Add External Memory Controller node on Tegra114 Svyatoslav Ryhel
2026-01-20  7:15   ` Mikko Perttunen
2025-11-25 12:05 ` [PATCH v4 11/12] ARM: tegra: Add EMC OPP and ICC properties to Tegra114 EMC and ACTMON device-tree nodes Svyatoslav Ryhel
2026-01-21  7:55   ` Mikko Perttunen
2026-01-21 16:57     ` Svyatoslav Ryhel
2026-01-22  5:45       ` Mikko Perttunen
2026-01-22  8:13         ` Svyatoslav Ryhel
2025-11-25 12:05 ` [PATCH v4 12/12] ARM: tegra: add DC interconnections for Tegra114 Svyatoslav Ryhel
2026-01-21  7:58   ` Mikko Perttunen
2025-11-26  8:47 ` [PATCH v4 00/12] Tegra114: implement EMC support Krzysztof Kozlowski
2025-12-01  6:12   ` Svyatoslav Ryhel
2025-12-01  7:18     ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b011f973-146f-4672-8e2b-9373eddbec3a@kernel.org \
    --to=krzk@kernel.org \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mperttunen@nvidia.com \
    --cc=mturquette@baylibre.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=pgaikwad@nvidia.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox