From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] gpu: host1x: Do not use mapping cache for job submissions
Date: Mon, 4 Apr 2022 13:33:42 +0100 [thread overview]
Message-ID: <3781875f-dfb0-a00c-0ee3-6ae70c3220e5@nvidia.com> (raw)
In-Reply-To: <20220324103025.2660775-1-thierry.reding@gmail.com>
On 24/03/2022 10:30, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Buffer mappings used in job submissions are usually small and not
> rapidly reused as opposed to framebuffers (which are usually large and
> rapidly reused, for example when page-flipping between double-buffered
> framebuffers). Avoid going through the mapping cache for these buffers
> since the cache would also lead to leaks if nobody is ever releasing
> the cache's last reference. For DRM/KMS these last references are
> dropped when the framebuffers are removed and therefore no longer
> needed.
>
> While at it, also add a note about the need to explicitly remove the
> final reference to the mapping in the cache.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
I have tested this and verified that it is working well.
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Thanks
Jon
--
nvpublic
next prev parent reply other threads:[~2022-04-04 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 10:30 [PATCH] gpu: host1x: Do not use mapping cache for job submissions Thierry Reding
2022-04-04 12:33 ` Jon Hunter [this message]
2022-04-06 13:13 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3781875f-dfb0-a00c-0ee3-6ae70c3220e5@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox