From: Thierry Reding <thierry.reding@gmail.com>
To: Mikko Perttunen <mperttunen@nvidia.com>,
Jon Hunter <jonathanh@nvidia.com>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] gpu: host1x: Do not use mapping cache for job submissions
Date: Wed, 6 Apr 2022 15:13:17 +0200 [thread overview]
Message-ID: <Yk2R7SBLy7ZnQJNR@orome> (raw)
In-Reply-To: <20220324103025.2660775-1-thierry.reding@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
On Thu, Mar 24, 2022 at 11:30:25AM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Buffer mappings used in job submissions are usually small and not
> rapidly reused as opposed to framebuffers (which are usually large and
> rapidly reused, for example when page-flipping between double-buffered
> framebuffers). Avoid going through the mapping cache for these buffers
> since the cache would also lead to leaks if nobody is ever releasing
> the cache's last reference. For DRM/KMS these last references are
> dropped when the framebuffers are removed and therefore no longer
> needed.
>
> While at it, also add a note about the need to explicitly remove the
> final reference to the mapping in the cache.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/gpu/host1x/job.c | 4 ++--
> include/linux/host1x.h | 5 +++++
> 2 files changed, 7 insertions(+), 2 deletions(-)
Applied.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-04-06 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 10:30 [PATCH] gpu: host1x: Do not use mapping cache for job submissions Thierry Reding
2022-04-04 12:33 ` Jon Hunter
2022-04-06 13:13 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk2R7SBLy7ZnQJNR@orome \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox