From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 00/12] memory: tegra: Driver unification
Date: Tue, 1 Jun 2021 23:02:18 +0300 [thread overview]
Message-ID: <43a76033-8a51-5a90-a2f8-a088c22c2b1c@gmail.com> (raw)
In-Reply-To: <b7ec0fba-1eb6-62b8-837c-609327cbe541@gmail.com>
01.06.2021 22:38, Dmitry Osipenko пишет:
> 01.06.2021 20:59, Thierry Reding пишет:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> Hi,
>>
>> this set of patches converges the feature sets of the pre-Tegra186 and
>> the post-Tegra186 memory controller drivers such that newer chips can
>> take advantage of some features that were previously only implemented
>> on earlier chips.
>>
>> Note that this looks a bit daunting from a diffstat point of view but
>> the bulk of this is in the first two patches that basically shuffle
>> around where some of the per-memory-client register definitions are
>> located, hence the big number of changed lines.
>>
>> Changes in v2:
>> - split patches up a bit for smaller, logical changes
>> - add better documentation for ->probe() callback
>> - use SET_SYSTEM_SLEEP_OPS where appropriate
>> - include Tegra194 separation patch
>> - use prefix for global variables
>> - drop commented-out code
>
> Everything looks and works good, thank you.
>
> I made a minor comment about the function which can be made static,
> perhaps you could improve it locally if you will take these patches via
> Tegra tree.
>
./scripts/bloat-o-meter -d ./vmlinux.old ./vmlinux.new
add/remove: 6/4 grow/shrink: 4/2 up/down: 2208/-240 (1968)
Data old new delta
tegra124_mc_clients 2948 3484 +536
tegra30_mc_clients 2904 3432 +528
tegra114_mc_clients 2860 3380 +520
tegra20_mc_clients 2288 2704 +416
tegra_mc_status_names - 128 +128
tegra_mc_error_names - 32 +32
tegra30_mc_ops - 20 +20
tegra20_mc_ops - 20 +20
__initcall__kmod_tegra_mc__252_848_tegra_mc_init3 - 4 +4
__initcall__kmod_tegra124_emc__239_1536_tegra_emc_driver_init6 - 4 +4
__initcall__kmod_tegra_mc__252_980_tegra_mc_init3 4 - -4
__initcall__kmod_tegra124_emc__237_1536_tegra_emc_driver_init6 4 - -4
__func__ 36101 36085 -16
error_names 32 - -32
_rs 15764 15708 -56
status_names 128 - -128
Total: Before=3674440, After=3676408, chg +0.05%
The +2KB in size is okay, I expected it would be worse.
prev parent reply other threads:[~2021-06-01 20:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 17:59 [PATCH v2 00/12] memory: tegra: Driver unification Thierry Reding
2021-06-01 17:59 ` [PATCH v2 01/12] memory: tegra: Consolidate register fields Thierry Reding
2021-06-01 17:59 ` [PATCH v2 02/12] memory: tegra: Unify struct tegra_mc across SoC generations Thierry Reding
2021-06-01 17:59 ` [PATCH v2 03/12] memory: tegra: Introduce struct tegra_mc_ops Thierry Reding
2021-06-01 17:59 ` [PATCH v2 04/12] memory: tegra: Push suspend/resume into SoC drivers Thierry Reding
2021-06-01 17:59 ` [PATCH v2 05/12] memory: tegra: Make per-SoC setup more generic Thierry Reding
2021-06-01 17:59 ` [PATCH v2 06/12] memory: tegra: Extract setup code into callback Thierry Reding
2021-06-01 17:59 ` [PATCH v2 07/12] memory: tegra: Parameterize interrupt handler Thierry Reding
2021-06-01 18:53 ` Dmitry Osipenko
2021-06-01 18:54 ` Dmitry Osipenko
2021-06-01 19:37 ` Dmitry Osipenko
2021-06-02 8:43 ` Thierry Reding
2021-06-01 17:59 ` [PATCH v2 08/12] memory: tegra: Make IRQ support opitonal Thierry Reding
2021-06-01 17:59 ` [PATCH v2 09/12] memory: tegra: Only initialize reset controller if available Thierry Reding
2021-06-01 17:59 ` [PATCH v2 10/12] memory: tegra: Unify drivers Thierry Reding
2021-06-01 17:59 ` [PATCH v2 11/12] memory: tegra: Add memory client IDs to tables Thierry Reding
2021-06-01 17:59 ` [PATCH v2 12/12] memory: tegra: Split Tegra194 data into separate file Thierry Reding
2021-06-02 7:53 ` Krzysztof Kozlowski
2021-06-02 8:29 ` Thierry Reding
2021-06-01 19:38 ` [PATCH v2 00/12] memory: tegra: Driver unification Dmitry Osipenko
2021-06-01 20:02 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43a76033-8a51-5a90-a2f8-a088c22c2b1c@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox