From: Thierry Reding <thierry.reding@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Dmitry Osipenko <digetx@gmail.com>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 12/12] memory: tegra: Split Tegra194 data into separate file
Date: Wed, 2 Jun 2021 10:29:40 +0200 [thread overview]
Message-ID: <YLdBdHswB/4tN3J0@orome.fritz.box> (raw)
In-Reply-To: <59395d67-a4e1-5f47-2ced-e7b28ba66009@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 2121 bytes --]
On Wed, Jun 02, 2021 at 09:53:03AM +0200, Krzysztof Kozlowski wrote:
> On 01/06/2021 19:59, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Keep the directory structure consistent by splitting the Tegra194 data
> > into a separate file.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > drivers/memory/tegra/Makefile | 2 +-
> > drivers/memory/tegra/mc.h | 5 +
> > drivers/memory/tegra/tegra186.c | 1349 +-----------------------------
> > drivers/memory/tegra/tegra194.c | 1353 +++++++++++++++++++++++++++++++
> > 4 files changed, 1360 insertions(+), 1349 deletions(-)
> > create mode 100644 drivers/memory/tegra/tegra194.c
> >
> > diff --git a/drivers/memory/tegra/Makefile b/drivers/memory/tegra/Makefile
> > index 1af0fefacdda..c992e87782d2 100644
> > --- a/drivers/memory/tegra/Makefile
> > +++ b/drivers/memory/tegra/Makefile
> > @@ -8,7 +8,7 @@ tegra-mc-$(CONFIG_ARCH_TEGRA_124_SOC) += tegra124.o
> > tegra-mc-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra124.o
> > tegra-mc-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210.o
> > tegra-mc-$(CONFIG_ARCH_TEGRA_186_SOC) += tegra186.o
> > -tegra-mc-$(CONFIG_ARCH_TEGRA_194_SOC) += tegra186.o
> > +tegra-mc-$(CONFIG_ARCH_TEGRA_194_SOC) += tegra186.o tegra194.o
> >
> > obj-$(CONFIG_TEGRA_MC) += tegra-mc.o
>
> (...)
>
> > diff --git a/drivers/memory/tegra/tegra194.c b/drivers/memory/tegra/tegra194.c
> > new file mode 100644
> > index 000000000000..3ae6fbb76997
> > --- /dev/null
> > +++ b/drivers/memory/tegra/tegra194.c
> > @@ -0,0 +1,1353 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (C) 2017-2021 NVIDIA CORPORATION. All rights reserved.
> > + */
> > +
> > +#include <soc/tegra/mc.h>
> > +
> > +#include <dt-bindings/memory/tegra194-mc.h>
> > +
> > +#include "mc.h"
> > +
> > +#if defined(CONFIG_ARCH_TEGRA_194_SOC)
>
> Do you actually need this #ifdef? This CONFIG_ARCH... symbol is already
> used in Makefile, so the unit should not be built on anything else.
This is indeed redundant now. Good catch!
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-02 8:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 17:59 [PATCH v2 00/12] memory: tegra: Driver unification Thierry Reding
2021-06-01 17:59 ` [PATCH v2 01/12] memory: tegra: Consolidate register fields Thierry Reding
2021-06-01 17:59 ` [PATCH v2 02/12] memory: tegra: Unify struct tegra_mc across SoC generations Thierry Reding
2021-06-01 17:59 ` [PATCH v2 03/12] memory: tegra: Introduce struct tegra_mc_ops Thierry Reding
2021-06-01 17:59 ` [PATCH v2 04/12] memory: tegra: Push suspend/resume into SoC drivers Thierry Reding
2021-06-01 17:59 ` [PATCH v2 05/12] memory: tegra: Make per-SoC setup more generic Thierry Reding
2021-06-01 17:59 ` [PATCH v2 06/12] memory: tegra: Extract setup code into callback Thierry Reding
2021-06-01 17:59 ` [PATCH v2 07/12] memory: tegra: Parameterize interrupt handler Thierry Reding
2021-06-01 18:53 ` Dmitry Osipenko
2021-06-01 18:54 ` Dmitry Osipenko
2021-06-01 19:37 ` Dmitry Osipenko
2021-06-02 8:43 ` Thierry Reding
2021-06-01 17:59 ` [PATCH v2 08/12] memory: tegra: Make IRQ support opitonal Thierry Reding
2021-06-01 17:59 ` [PATCH v2 09/12] memory: tegra: Only initialize reset controller if available Thierry Reding
2021-06-01 17:59 ` [PATCH v2 10/12] memory: tegra: Unify drivers Thierry Reding
2021-06-01 17:59 ` [PATCH v2 11/12] memory: tegra: Add memory client IDs to tables Thierry Reding
2021-06-01 17:59 ` [PATCH v2 12/12] memory: tegra: Split Tegra194 data into separate file Thierry Reding
2021-06-02 7:53 ` Krzysztof Kozlowski
2021-06-02 8:29 ` Thierry Reding [this message]
2021-06-01 19:38 ` [PATCH v2 00/12] memory: tegra: Driver unification Dmitry Osipenko
2021-06-01 20:02 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLdBdHswB/4tN3J0@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox