* Re: [PATCH] clocksource: tegra: Port tegra20 clocksource to arm64 [not found] ` <1415319715-21757-1-git-send-email-anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-11-07 4:17 ` Stephen Warren [not found] ` <545C47BC.4050207-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Stephen Warren @ 2014-11-07 4:17 UTC (permalink / raw) To: Anatol Pomozov Cc: pdeschrijver-DDmLM1+adcrQT0dZR+AlfA, marc.zyngier-5wv7dgnIgG8, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 11/06/2014 05:21 PM, Anatol Pomozov wrote: > register_persistent_clock() are in different headers in arm/arm64 > > Tested: Compiled the driver on 64bit platform and make sure that > it works I assume "it works" refers to "it compiles" not "it executes successfully"? I think it'd be better to make the same APIs available on arm and arm64, or even across all architectures. > Signed-off-by: Anatol Pomozov <anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > drivers/clocksource/tegra20_timer.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksource/tegra20_timer.c > index d2616ef..e0123c7 100644 > --- a/drivers/clocksource/tegra20_timer.c > +++ b/drivers/clocksource/tegra20_timer.c > @@ -29,8 +29,12 @@ > #include <linux/sched_clock.h> > #include <linux/delay.h> > > +#ifdef CONFIG_ARM64 > +#include <asm/time.h> > +#else > #include <asm/mach/time.h> > #include <asm/smp_twd.h> > +#endif > > #define RTC_SECONDS 0x08 > #define RTC_SHADOW_SECONDS 0x0c > ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <545C47BC.4050207-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] clocksource: tegra: Port tegra20 clocksource to arm64 [not found] ` <545C47BC.4050207-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> @ 2014-11-07 4:26 ` Anatol Pomozov 0 siblings, 0 replies; 2+ messages in thread From: Anatol Pomozov @ 2014-11-07 4:26 UTC (permalink / raw) To: Stephen Warren Cc: pdeschrijver-DDmLM1+adcrQT0dZR+AlfA, Marc Zyngier, LKML, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hi On Thu, Nov 6, 2014 at 8:17 PM, Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote: > On 11/06/2014 05:21 PM, Anatol Pomozov wrote: >> register_persistent_clock() are in different headers in arm/arm64 >> >> Tested: Compiled the driver on 64bit platform and make sure that >> it works > > I assume "it works" refers to "it compiles" not "it executes successfully"? It execute successfully, at least on 3.14 + bunch of backported changes. I tested it on chromiumos 3.14 kernel and 64bit tegra board. > I think it'd be better to make the same APIs available on arm and arm64, > or even across all architectures. > >> Signed-off-by: Anatol Pomozov <anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> --- >> drivers/clocksource/tegra20_timer.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksource/tegra20_timer.c >> index d2616ef..e0123c7 100644 >> --- a/drivers/clocksource/tegra20_timer.c >> +++ b/drivers/clocksource/tegra20_timer.c >> @@ -29,8 +29,12 @@ >> #include <linux/sched_clock.h> >> #include <linux/delay.h> >> >> +#ifdef CONFIG_ARM64 >> +#include <asm/time.h> >> +#else >> #include <asm/mach/time.h> >> #include <asm/smp_twd.h> >> +#endif >> >> #define RTC_SECONDS 0x08 >> #define RTC_SHADOW_SECONDS 0x0c >> > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-07 4:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1415319715-21757-1-git-send-email-anatol.pomozov@gmail.com>
[not found] ` <1415319715-21757-1-git-send-email-anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-07 4:17 ` [PATCH] clocksource: tegra: Port tegra20 clocksource to arm64 Stephen Warren
[not found] ` <545C47BC.4050207-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-11-07 4:26 ` Anatol Pomozov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox