From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: Krishna Chaitanya Chundru <quic_krichai@quicinc.com>,
bhelgaas@google.com, thierry.reding@gmail.com,
petlozup@nvidia.com, rafael.j.wysocki@intel.com,
lpieralisi@kernel.org, robh@kernel.org,
jeffy.chen@rock-chips.com
Cc: krzysztof.kozlowski+dt@linaro.org, jonathanh@nvidia.com,
dmitry.osipenko@collabora.com, viresh.kumar@linaro.org,
gregkh@linuxfoundation.org, steven.price@arm.com, kw@linux.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-pm@vger.kernel.org, vidyas@nvidia.com
Subject: Re: [RFC,v14 0/5] Add DT based PCIe wake support in PCI core driver
Date: Thu, 7 Dec 2023 12:39:02 +0530 [thread overview]
Message-ID: <557bae04-13c2-44ea-bad0-9589c999c2cb@nvidia.com> (raw)
In-Reply-To: <feee5e5b-565e-8575-2bbe-61b35fa8f1dd@quicinc.com>
Hi Krishna Chaitanya,
Unfortunately I cannot follow up on this series now.
If you have a platform with same requirement, please verify and publish
new version.
Thanks,
Manikanta
On 06-12-2023 20:14, Krishna Chaitanya Chundru wrote:
> External email: Use caution opening links or attachments
>
>
> Hi Manikanta,
>
> I don't see any update on this series after comments.
>
> Is there any plans to take up this series.
>
> Thanks & Regards,
>
> Krishna Chaitanya.
>
> On 2/8/2023 4:46 PM, Manikanta Maddireddy wrote:
>> Below series [1] attempted to support DT based PCIe wake feature in
>> generic
>> PCI core driver. This series was left at v13 and final comments are not
>> addressed. I am continuing this series from v14 by addressing all
>> comments
>> in v13. I dropped rockchip device tree patch because I don't have
>> hardware
>> to verify it. Instead, I verified these patches on NVIDIA Jetson AGX
>> Orin
>> Developer Kit and included its device tree changes in this series.
>>
>> [1]
>> https://lore.kernel.org/all/20171226023646.17722-1-jeffy.chen@rock-chips.com/
>>
>> Changes in v14:
>> Updated commit message for DT bindings patch to reflect that DT
>> properties
>> are tied to PCI-PCI Bridge.
>> Addressed review comments on PCI interrupt parsing patch.
>> Dropped rockchip device tree patch.
>> Added Jetson AGX OrinDeveloper Kit device tree and Tegra PMC patches.
>>
>> Changes in v13:
>> Fix compiler error reported by kbuild test robot
>> <fengguang.wu@intel.com>
>>
>> Changes in v12:
>> Only add irq definitions for PCI devices and rewrite the commit message.
>> Enable the wake irq in noirq stage to avoid possible irq storm.
>>
>> Changes in v11:
>> Address Brian's comments.
>> Only support 1-per-device PCIe WAKE# pin as suggested.
>> Move to pcie port as Brian suggested.
>>
>> Changes in v10:
>> Use device_set_wakeup_capable() instead of device_set_wakeup_enable(),
>> since dedicated wakeirq will be lost in device_set_wakeup_enable(false).
>>
>> Changes in v9:
>> Add section for PCI devices and rewrite the commit message.
>> Fix check error in .cleanup().
>> Move dedicated wakeirq setup to setup() callback and use
>> device_set_wakeup_enable() to enable/disable.
>> Rewrite the commit message.
>>
>> Changes in v8:
>> Add optional "pci", and rewrite commit message.
>> Add pci-of.c and use platform_pm_ops to handle the PCIe WAKE# signal.
>> Rewrite the commit message.
>>
>> Changes in v7:
>> Move PCIE_WAKE handling into pci core.
>>
>> Changes in v6:
>> Fix device_init_wake error handling, and add some comments.
>>
>> Changes in v5:
>> Move to pci.txt
>> Rebase.
>> Use "wakeup" instead of "wake"
>>
>> Changes in v3:
>> Fix error handling.
>>
>> Changes in v2:
>> Use dev_pm_set_dedicated_wake_irq.
>>
>> Jeffy Chen (3):
>> dt-bindings: PCI: Add definition of PCIe WAKE# irq and PCI irq
>> of/irq: Adjust of_pci_irq parsing for multiple interrupts
>> PCI / PM: Add support for the PCIe WAKE# signal for OF
>>
>> Manikanta Maddireddy (2):
>> arm64: tegra: Add PCIe port node with PCIe WAKE# for C1 controller
>> soc/tegra: pmc: Add Tegra234 PCIe wake event
>>
>> Documentation/devicetree/bindings/pci/pci.txt | 8 +++
>> .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 11 ++++
>> drivers/pci/of.c | 63 ++++++++++++++++++-
>> drivers/pci/pci-driver.c | 10 +++
>> drivers/pci/pci.c | 7 +++
>> drivers/pci/pci.h | 8 +++
>> drivers/soc/tegra/pmc.c | 1 +
>> 7 files changed, 105 insertions(+), 3 deletions(-)
>>
prev parent reply other threads:[~2023-12-07 7:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 11:16 [RFC,v14 0/5] Add DT based PCIe wake support in PCI core driver Manikanta Maddireddy
2023-02-08 11:16 ` [RFC,v14 1/5] dt-bindings: PCI: Add definition of PCIe WAKE# irq and PCI irq Manikanta Maddireddy
2023-02-08 13:53 ` Rob Herring
2023-02-08 15:54 ` Manikanta Maddireddy
2023-02-08 11:16 ` [RFC,v14 2/5] of/irq: Adjust of_pci_irq parsing for multiple interrupts Manikanta Maddireddy
2023-02-08 11:44 ` Thierry Reding
2023-02-08 12:20 ` Manikanta Maddireddy
2023-02-08 11:16 ` [RFC,v14 3/5] PCI / PM: Add support for the PCIe WAKE# signal for OF Manikanta Maddireddy
2023-02-08 11:50 ` Thierry Reding
2023-02-08 12:19 ` Manikanta Maddireddy
2023-02-08 11:16 ` [RFC,v14 4/5] arm64: tegra: Add PCIe port node with PCIe WAKE# for C1 controller Manikanta Maddireddy
2023-02-08 11:37 ` Thierry Reding
2023-02-08 12:13 ` Manikanta Maddireddy
2023-02-08 16:14 ` Thierry Reding
2023-02-09 10:53 ` Petlozu Pravareshwar
2023-02-09 11:12 ` Thierry Reding
2023-12-06 15:36 ` Manivannan Sadhasivam
2023-12-07 7:24 ` Manikanta Maddireddy
2023-12-07 7:59 ` Manivannan Sadhasivam
2023-12-07 8:53 ` Manikanta Maddireddy
2023-12-07 9:31 ` Manivannan Sadhasivam
2023-02-08 11:16 ` [RFC,v14 5/5] soc/tegra: pmc: Add Tegra234 PCIe wake event Manikanta Maddireddy
2023-02-08 11:38 ` Thierry Reding
2023-02-08 12:06 ` Manikanta Maddireddy
2023-12-06 14:44 ` [RFC,v14 0/5] Add DT based PCIe wake support in PCI core driver Krishna Chaitanya Chundru
2023-12-07 7:09 ` Manikanta Maddireddy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557bae04-13c2-44ea-bad0-9589c999c2cb@nvidia.com \
--to=mmaddireddy@nvidia.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeffy.chen@rock-chips.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=petlozup@nvidia.com \
--cc=quic_krichai@quicinc.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox