From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: bhelgaas@google.com, thierry.reding@gmail.com,
petlozup@nvidia.com, rafael.j.wysocki@intel.com,
lpieralisi@kernel.org, jeffy.chen@rock-chips.com,
krzysztof.kozlowski+dt@linaro.org, jonathanh@nvidia.com,
dmitry.osipenko@collabora.com, viresh.kumar@linaro.org,
gregkh@linuxfoundation.org, steven.price@arm.com, kw@linux.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-pm@vger.kernel.org, vidyas@nvidia.com
Subject: Re: [RFC,v14 1/5] dt-bindings: PCI: Add definition of PCIe WAKE# irq and PCI irq
Date: Wed, 8 Feb 2023 21:24:01 +0530 [thread overview]
Message-ID: <b2b91240-95fe-145d-502c-d52225497a34@nvidia.com> (raw)
In-Reply-To: <CAL_JsqJtx+AMFC6SRUEVEgLbiWqv=Ov2cN=oqofZhqvtd1c8vQ@mail.gmail.com>
On 2/8/2023 7:23 PM, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, Feb 8, 2023 at 5:17 AM Manikanta Maddireddy
> <mmaddireddy@nvidia.com> wrote:
>> From: Jeffy Chen <jeffy.chen@rock-chips.com>
>>
>> Add device tree support to pass PCIe WAKE# pin information to PCI core
>> driver. To support PCIe WAKE# and PCI irqs, add definition of the optional
>> properties "interrupts" and "interrupt-names". These properties should be
>> defined by the PCIe port to which wake capable Endpoint is connected,
>> so the definition is added under "PCI-PCI Bridge properties" section.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
> I did? 5 years ago it seems. Times change and evolve. Don't add to
> pci.txt. This must be a schema now. PCI schema lives in dtschema.
>
> Rob
I will prepare new patch in dtschema and send in next version.
Manikanta
next prev parent reply other threads:[~2023-02-08 15:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 11:16 [RFC,v14 0/5] Add DT based PCIe wake support in PCI core driver Manikanta Maddireddy
2023-02-08 11:16 ` [RFC,v14 1/5] dt-bindings: PCI: Add definition of PCIe WAKE# irq and PCI irq Manikanta Maddireddy
2023-02-08 13:53 ` Rob Herring
2023-02-08 15:54 ` Manikanta Maddireddy [this message]
2023-02-08 11:16 ` [RFC,v14 2/5] of/irq: Adjust of_pci_irq parsing for multiple interrupts Manikanta Maddireddy
2023-02-08 11:44 ` Thierry Reding
2023-02-08 12:20 ` Manikanta Maddireddy
2023-02-08 11:16 ` [RFC,v14 3/5] PCI / PM: Add support for the PCIe WAKE# signal for OF Manikanta Maddireddy
2023-02-08 11:50 ` Thierry Reding
2023-02-08 12:19 ` Manikanta Maddireddy
2023-02-08 11:16 ` [RFC,v14 4/5] arm64: tegra: Add PCIe port node with PCIe WAKE# for C1 controller Manikanta Maddireddy
2023-02-08 11:37 ` Thierry Reding
2023-02-08 12:13 ` Manikanta Maddireddy
2023-02-08 16:14 ` Thierry Reding
2023-02-09 10:53 ` Petlozu Pravareshwar
2023-02-09 11:12 ` Thierry Reding
2023-12-06 15:36 ` Manivannan Sadhasivam
2023-12-07 7:24 ` Manikanta Maddireddy
2023-12-07 7:59 ` Manivannan Sadhasivam
2023-12-07 8:53 ` Manikanta Maddireddy
2023-12-07 9:31 ` Manivannan Sadhasivam
2023-02-08 11:16 ` [RFC,v14 5/5] soc/tegra: pmc: Add Tegra234 PCIe wake event Manikanta Maddireddy
2023-02-08 11:38 ` Thierry Reding
2023-02-08 12:06 ` Manikanta Maddireddy
2023-12-06 14:44 ` [RFC,v14 0/5] Add DT based PCIe wake support in PCI core driver Krishna Chaitanya Chundru
2023-12-07 7:09 ` Manikanta Maddireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2b91240-95fe-145d-502c-d52225497a34@nvidia.com \
--to=mmaddireddy@nvidia.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeffy.chen@rock-chips.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=petlozup@nvidia.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox