From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Besar Wicaksono <bwicaksono@nvidia.com>,
catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
sfr@canb.auug.org.au, treding@nvidia.com, jonathanh@nvidia.com,
vsethi@nvidia.com, ywan@nvidia.com
Subject: Re: [PATCH] perf: arm_cspmu: Fix build failure on x86_64
Date: Thu, 17 Nov 2022 09:18:14 +0000 [thread overview]
Message-ID: <5bdfe519-e6fe-7fed-2731-40d490e1f9bb@arm.com> (raw)
In-Reply-To: <20221116190455.55651-1-bwicaksono@nvidia.com>
On 16/11/2022 19:04, Besar Wicaksono wrote:
> Building on x86_64 allmodconfig failed:
> | drivers/perf/arm_cspmu/arm_cspmu.c:1114:29: error: implicit
> | declaration of function 'get_acpi_id_for_cpu'
>
> get_acpi_id_for_cpu is a helper function from ARM64.
> Fix by adding ARM64 dependency.
>
> Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
nit: Not sure if we have a stable commit id to mark "fixes".
May be that is not needed until it hits upstream.
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> drivers/perf/arm_cspmu/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/perf/arm_cspmu/Kconfig b/drivers/perf/arm_cspmu/Kconfig
> index 058223bef661..0b316fe69a45 100644
> --- a/drivers/perf/arm_cspmu/Kconfig
> +++ b/drivers/perf/arm_cspmu/Kconfig
> @@ -4,7 +4,7 @@
>
> config ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU
> tristate "ARM Coresight Architecture PMU"
> - depends on ACPI
> + depends on ARM64 && ACPI
> depends on ACPI_APMT || COMPILE_TEST
> help
> Provides support for performance monitoring unit (PMU) devices
>
> base-commit: 9500fc6e9e6077616c0dea0f7eb33138be94ed0c
next prev parent reply other threads:[~2022-11-17 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 19:04 [PATCH] perf: arm_cspmu: Fix build failure on x86_64 Besar Wicaksono
2022-11-17 9:18 ` Suzuki K Poulose [this message]
2022-11-18 19:40 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bdfe519-e6fe-7fed-2731-40d490e1f9bb@arm.com \
--to=suzuki.poulose@arm.com \
--cc=bwicaksono@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sfr@canb.auug.org.au \
--cc=treding@nvidia.com \
--cc=vsethi@nvidia.com \
--cc=will@kernel.org \
--cc=ywan@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox