* [PATCH] perf: arm_cspmu: Fix build failure on x86_64
@ 2022-11-16 19:04 Besar Wicaksono
2022-11-17 9:18 ` Suzuki K Poulose
2022-11-18 19:40 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Besar Wicaksono @ 2022-11-16 19:04 UTC (permalink / raw)
To: suzuki.poulose, catalin.marinas, will, mark.rutland
Cc: linux-arm-kernel, linux-kernel, linux-tegra, sfr, treding,
jonathanh, vsethi, ywan, Besar Wicaksono
Building on x86_64 allmodconfig failed:
| drivers/perf/arm_cspmu/arm_cspmu.c:1114:29: error: implicit
| declaration of function 'get_acpi_id_for_cpu'
get_acpi_id_for_cpu is a helper function from ARM64.
Fix by adding ARM64 dependency.
Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
---
drivers/perf/arm_cspmu/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/perf/arm_cspmu/Kconfig b/drivers/perf/arm_cspmu/Kconfig
index 058223bef661..0b316fe69a45 100644
--- a/drivers/perf/arm_cspmu/Kconfig
+++ b/drivers/perf/arm_cspmu/Kconfig
@@ -4,7 +4,7 @@
config ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU
tristate "ARM Coresight Architecture PMU"
- depends on ACPI
+ depends on ARM64 && ACPI
depends on ACPI_APMT || COMPILE_TEST
help
Provides support for performance monitoring unit (PMU) devices
base-commit: 9500fc6e9e6077616c0dea0f7eb33138be94ed0c
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf: arm_cspmu: Fix build failure on x86_64
2022-11-16 19:04 [PATCH] perf: arm_cspmu: Fix build failure on x86_64 Besar Wicaksono
@ 2022-11-17 9:18 ` Suzuki K Poulose
2022-11-18 19:40 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Suzuki K Poulose @ 2022-11-17 9:18 UTC (permalink / raw)
To: Besar Wicaksono, catalin.marinas, will, mark.rutland
Cc: linux-arm-kernel, linux-kernel, linux-tegra, sfr, treding,
jonathanh, vsethi, ywan
On 16/11/2022 19:04, Besar Wicaksono wrote:
> Building on x86_64 allmodconfig failed:
> | drivers/perf/arm_cspmu/arm_cspmu.c:1114:29: error: implicit
> | declaration of function 'get_acpi_id_for_cpu'
>
> get_acpi_id_for_cpu is a helper function from ARM64.
> Fix by adding ARM64 dependency.
>
> Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
nit: Not sure if we have a stable commit id to mark "fixes".
May be that is not needed until it hits upstream.
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> drivers/perf/arm_cspmu/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/perf/arm_cspmu/Kconfig b/drivers/perf/arm_cspmu/Kconfig
> index 058223bef661..0b316fe69a45 100644
> --- a/drivers/perf/arm_cspmu/Kconfig
> +++ b/drivers/perf/arm_cspmu/Kconfig
> @@ -4,7 +4,7 @@
>
> config ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU
> tristate "ARM Coresight Architecture PMU"
> - depends on ACPI
> + depends on ARM64 && ACPI
> depends on ACPI_APMT || COMPILE_TEST
> help
> Provides support for performance monitoring unit (PMU) devices
>
> base-commit: 9500fc6e9e6077616c0dea0f7eb33138be94ed0c
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf: arm_cspmu: Fix build failure on x86_64
2022-11-16 19:04 [PATCH] perf: arm_cspmu: Fix build failure on x86_64 Besar Wicaksono
2022-11-17 9:18 ` Suzuki K Poulose
@ 2022-11-18 19:40 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2022-11-18 19:40 UTC (permalink / raw)
To: mark.rutland, catalin.marinas, suzuki.poulose, Besar Wicaksono
Cc: kernel-team, Will Deacon, linux-tegra, linux-arm-kernel, vsethi,
linux-kernel, sfr, treding, jonathanh, ywan
On Wed, 16 Nov 2022 13:04:55 -0600, Besar Wicaksono wrote:
> Building on x86_64 allmodconfig failed:
> | drivers/perf/arm_cspmu/arm_cspmu.c:1114:29: error: implicit
> | declaration of function 'get_acpi_id_for_cpu'
>
> get_acpi_id_for_cpu is a helper function from ARM64.
> Fix by adding ARM64 dependency.
>
> [...]
Applied to will (for-next/perf), thanks!
[1/1] perf: arm_cspmu: Fix build failure on x86_64
https://git.kernel.org/will/c/e72dbf9085b5
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-18 19:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-16 19:04 [PATCH] perf: arm_cspmu: Fix build failure on x86_64 Besar Wicaksono
2022-11-17 9:18 ` Suzuki K Poulose
2022-11-18 19:40 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox