From: Mikko Perttunen <mperttunen@nvidia.com>
To: Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Pan Chuang <panchuang@vivo.com>,
"open list:TEGRA ARCHITECTURE SUPPORT"
<linux-tegra@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Pan Chuang <panchuang@vivo.com>
Subject: Re: [PATCH] firmware: tegra: Remove redundant dev_err()
Date: Wed, 15 Jul 2026 15:14:03 +0900 [thread overview]
Message-ID: <6A2ROEhiRXKNUTuswOgtPg@nvidia.com> (raw)
In-Reply-To: <20260713131940.355559-2-panchuang@vivo.com>
On Monday, July 13, 2026 10:19 PM Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/firmware/tegra/bpmp-tegra210.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/tegra/bpmp-tegra210.c b/drivers/firmware/tegra/bpmp-tegra210.c
> index 6295f5640c15..643068a8b3b8 100644
> --- a/drivers/firmware/tegra/bpmp-tegra210.c
> +++ b/drivers/firmware/tegra/bpmp-tegra210.c
> @@ -215,10 +215,8 @@ static int tegra210_bpmp_init(struct tegra_bpmp *bpmp)
>
> err = devm_request_irq(&pdev->dev, err, rx_irq,
> IRQF_NO_SUSPEND, dev_name(&pdev->dev), bpmp);
> - if (err < 0) {
> - dev_err(&pdev->dev, "failed to request IRQ: %d\n", err);
> + if (err < 0)
> return err;
> - }
>
> return 0;
> }
> --
> 2.34.1
>
>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
prev parent reply other threads:[~2026-07-15 6:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260713131940.355559-1-panchuang@vivo.com>
2026-07-13 13:19 ` [PATCH] firmware: tegra: Remove redundant dev_err() Pan Chuang
2026-07-15 6:14 ` Mikko Perttunen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A2ROEhiRXKNUTuswOgtPg@nvidia.com \
--to=mperttunen@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=panchuang@vivo.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox