* [PATCH] firmware: tegra: Remove redundant dev_err() [not found] <20260713131940.355559-1-panchuang@vivo.com> @ 2026-07-13 13:19 ` Pan Chuang 2026-07-15 6:14 ` Mikko Perttunen 0 siblings, 1 reply; 2+ messages in thread From: Pan Chuang @ 2026-07-13 13:19 UTC (permalink / raw) To: Thierry Reding, Jonathan Hunter, Pan Chuang, open list:TEGRA ARCHITECTURE SUPPORT, open list Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang <panchuang@vivo.com> --- drivers/firmware/tegra/bpmp-tegra210.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/firmware/tegra/bpmp-tegra210.c b/drivers/firmware/tegra/bpmp-tegra210.c index 6295f5640c15..643068a8b3b8 100644 --- a/drivers/firmware/tegra/bpmp-tegra210.c +++ b/drivers/firmware/tegra/bpmp-tegra210.c @@ -215,10 +215,8 @@ static int tegra210_bpmp_init(struct tegra_bpmp *bpmp) err = devm_request_irq(&pdev->dev, err, rx_irq, IRQF_NO_SUSPEND, dev_name(&pdev->dev), bpmp); - if (err < 0) { - dev_err(&pdev->dev, "failed to request IRQ: %d\n", err); + if (err < 0) return err; - } return 0; } -- 2.34.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware: tegra: Remove redundant dev_err() 2026-07-13 13:19 ` [PATCH] firmware: tegra: Remove redundant dev_err() Pan Chuang @ 2026-07-15 6:14 ` Mikko Perttunen 0 siblings, 0 replies; 2+ messages in thread From: Mikko Perttunen @ 2026-07-15 6:14 UTC (permalink / raw) To: Thierry Reding, Jonathan Hunter, Pan Chuang, open list:TEGRA ARCHITECTURE SUPPORT, open list, Pan Chuang On Monday, July 13, 2026 10:19 PM Pan Chuang wrote: > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in > devm_request_*_irq()"), devm_request_irq() automatically logs > detailed error messages on failure. Remove the now-redundant > driver-specific dev_err() calls. > > Signed-off-by: Pan Chuang <panchuang@vivo.com> > --- > drivers/firmware/tegra/bpmp-tegra210.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/firmware/tegra/bpmp-tegra210.c b/drivers/firmware/tegra/bpmp-tegra210.c > index 6295f5640c15..643068a8b3b8 100644 > --- a/drivers/firmware/tegra/bpmp-tegra210.c > +++ b/drivers/firmware/tegra/bpmp-tegra210.c > @@ -215,10 +215,8 @@ static int tegra210_bpmp_init(struct tegra_bpmp *bpmp) > > err = devm_request_irq(&pdev->dev, err, rx_irq, > IRQF_NO_SUSPEND, dev_name(&pdev->dev), bpmp); > - if (err < 0) { > - dev_err(&pdev->dev, "failed to request IRQ: %d\n", err); > + if (err < 0) > return err; > - } > > return 0; > } > -- > 2.34.1 > > Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-15 6:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260713131940.355559-1-panchuang@vivo.com>
2026-07-13 13:19 ` [PATCH] firmware: tegra: Remove redundant dev_err() Pan Chuang
2026-07-15 6:14 ` Mikko Perttunen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox