From: Bitan Biswas <bbiswas@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Shardar Mohammed <smohammed@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Mantravadi Karthik <mkarthik@nvidia.com>
Subject: Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects
Date: Wed, 5 Jun 2019 23:24:39 -0700 [thread overview]
Message-ID: <89488516-a064-a1a0-9e3d-8234043201be@nvidia.com> (raw)
In-Reply-To: <2d83ad21-b012-1b3e-fc9a-741972ee3ba9@gmail.com>
On 5/31/19 5:45 AM, Dmitry Osipenko wrote:
> 31.05.2019 12:04, Bitan Biswas пишет:
>>
>>
>> On 5/30/19 4:43 AM, Dmitry Osipenko wrote:
>>> 30.05.2019 14:36, Dmitry Osipenko пишет:
>>>> 30.05.2019 9:14, Bitan Biswas пишет:
>>>>> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
>>>>> except for BUG/BUG_ON checks
>>>>
>>>> Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire,
>>>> hence there is absolutely no good reason in making system unusable on a
>>>> software bug. BUG_ON may be more useful for development, but not for a
>>>> casual daily usage.
>> I shall update the patch to remove the BUG/BUG_ON calls.
>
> Please replace them with WARN_ON_ONCE.
>
Based on review of the BUG_ON some were found redundant calls and hence
planned to be removed. Non-trivial BUG_ON planned to be replaced with
WARN_ON_ONCE call.
-regards,
Bitan
prev parent reply other threads:[~2019-06-06 6:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 6:14 [PATCH V2] drivers: i2c: tegra: fix checkpatch defects Bitan Biswas
2019-05-30 11:36 ` Dmitry Osipenko
2019-05-30 11:43 ` Dmitry Osipenko
2019-05-31 9:04 ` Bitan Biswas
2019-05-31 12:45 ` Dmitry Osipenko
2019-06-06 6:24 ` Bitan Biswas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89488516-a064-a1a0-9e3d-8234043201be@nvidia.com \
--to=bbiswas@nvidia.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=skomatineni@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox