* [PATCH 1/1] phy: tegra: xusb: Fix UTMI AO sleepwalk trigger programming sequence
@ 2025-12-03 2:47 Wayne Chang
2025-12-04 7:12 ` JC Kuo
0 siblings, 1 reply; 3+ messages in thread
From: Wayne Chang @ 2025-12-03 2:47 UTC (permalink / raw)
To: jckuo, vkoul, kishon, thierry.reding, jonathanh
Cc: waynec, haotienh, linux-phy, linux-tegra, linux-kernel, stable
From: Haotien Hsu <haotienh@nvidia.com>
The UTMIP sleepwalk programming sequence requires asserting both
LINEVAL_WALK_EN and WAKE_WALK_EN when enabling the sleepwalk logic.
However, the current code mistakenly cleared WAKE_WALK_EN, which
prevents the sleepwalk trigger from operating correctly.
Fix this by asserting WAKE_WALK_EN together with LINEVAL_WALK_EN.
Fixes: 1f9cab6cc20c ("phy: tegra: xusb: Add wake/sleepwalk for Tegra186")
Cc: stable@vger.kernel.org
Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
Signed-off-by: Wayne Chang <waynec@nvidia.com>
---
drivers/phy/tegra/xusb-tegra186.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
index e818f6c3980e..b2a76710c0c4 100644
--- a/drivers/phy/tegra/xusb-tegra186.c
+++ b/drivers/phy/tegra/xusb-tegra186.c
@@ -401,8 +401,7 @@ static int tegra186_utmi_enable_phy_sleepwalk(struct tegra_xusb_lane *lane,
/* enable the trigger of the sleepwalk logic */
value = ao_readl(priv, XUSB_AO_UTMIP_SLEEPWALK_CFG(index));
- value |= LINEVAL_WALK_EN;
- value &= ~WAKE_WALK_EN;
+ value |= LINEVAL_WALK_EN | WAKE_WALK_EN;
ao_writel(priv, value, XUSB_AO_UTMIP_SLEEPWALK_CFG(index));
/* reset the walk pointer and clear the alarm of the sleepwalk logic,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] phy: tegra: xusb: Fix UTMI AO sleepwalk trigger programming sequence
2025-12-03 2:47 [PATCH 1/1] phy: tegra: xusb: Fix UTMI AO sleepwalk trigger programming sequence Wayne Chang
@ 2025-12-04 7:12 ` JC Kuo
2025-12-05 3:19 ` Wayne Chang
0 siblings, 1 reply; 3+ messages in thread
From: JC Kuo @ 2025-12-04 7:12 UTC (permalink / raw)
To: Wayne Chang, vkoul, kishon, thierry.reding, jonathanh
Cc: haotienh, linux-phy, linux-tegra, linux-kernel, stable
Hi Wayne
On 12/3/25 10:47, Wayne Chang wrote:
> From: Haotien Hsu <haotienh@nvidia.com>
>
> The UTMIP sleepwalk programming sequence requires asserting both
> LINEVAL_WALK_EN and WAKE_WALK_EN when enabling the sleepwalk logic.
> However, the current code mistakenly cleared WAKE_WALK_EN, which
> prevents the sleepwalk trigger from operating correctly.
>
> Fix this by asserting WAKE_WALK_EN together with LINEVAL_WALK_EN.
>
> Fixes: 1f9cab6cc20c ("phy: tegra: xusb: Add wake/sleepwalk for Tegra186")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
> drivers/phy/tegra/xusb-tegra186.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index e818f6c3980e..b2a76710c0c4 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -401,8 +401,7 @@ static int tegra186_utmi_enable_phy_sleepwalk(struct tegra_xusb_lane *lane,
>
> /* enable the trigger of the sleepwalk logic */
> value = ao_readl(priv, XUSB_AO_UTMIP_SLEEPWALK_CFG(index));
> - value |= LINEVAL_WALK_EN;
> - value &= ~WAKE_WALK_EN;
> + value |= LINEVAL_WALK_EN | WAKE_WALK_EN;
> ao_writel(priv, value, XUSB_AO_UTMIP_SLEEPWALK_CFG(index));
>
> /* reset the walk pointer and clear the alarm of the sleepwalk logic,
WAKE_WALK_EN has to be set with '0' according to the ASIC designers. Tegra234
and Tegra239 TRMs have been updated. We will get Tegra264 document updated as well.
Thanks,
JC
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] phy: tegra: xusb: Fix UTMI AO sleepwalk trigger programming sequence
2025-12-04 7:12 ` JC Kuo
@ 2025-12-05 3:19 ` Wayne Chang
0 siblings, 0 replies; 3+ messages in thread
From: Wayne Chang @ 2025-12-05 3:19 UTC (permalink / raw)
To: Jui Chang Kuo, vkoul@kernel.org, kishon@kernel.org,
thierry.reding@gmail.com, Jon Hunter
Cc: HaoTien Hsu, linux-phy@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Hi JC,
On 12/4/25 15:12, Jui Chang Kuo wrote:
> Hi Wayne
>
> On 12/3/25 10:47, Wayne Chang wrote:
>> From: Haotien Hsu <haotienh@nvidia.com>
>>
>> The UTMIP sleepwalk programming sequence requires asserting both
>> LINEVAL_WALK_EN and WAKE_WALK_EN when enabling the sleepwalk logic.
>> However, the current code mistakenly cleared WAKE_WALK_EN, which
>> prevents the sleepwalk trigger from operating correctly.
>>
>> Fix this by asserting WAKE_WALK_EN together with LINEVAL_WALK_EN.
>>
>> Fixes: 1f9cab6cc20c ("phy: tegra: xusb: Add wake/sleepwalk for Tegra186")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>> ---
>> drivers/phy/tegra/xusb-tegra186.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
>> index e818f6c3980e..b2a76710c0c4 100644
>> --- a/drivers/phy/tegra/xusb-tegra186.c
>> +++ b/drivers/phy/tegra/xusb-tegra186.c
>> @@ -401,8 +401,7 @@ static int tegra186_utmi_enable_phy_sleepwalk(struct tegra_xusb_lane *lane,
>>
>> /* enable the trigger of the sleepwalk logic */
>> value = ao_readl(priv, XUSB_AO_UTMIP_SLEEPWALK_CFG(index));
>> - value |= LINEVAL_WALK_EN;
>> - value &= ~WAKE_WALK_EN;
>> + value |= LINEVAL_WALK_EN | WAKE_WALK_EN;
>> ao_writel(priv, value, XUSB_AO_UTMIP_SLEEPWALK_CFG(index));
>>
>> /* reset the walk pointer and clear the alarm of the sleepwalk logic,
> WAKE_WALK_EN has to be set with '0' according to the ASIC designers. Tegra234
> and Tegra239 TRMs have been updated. We will get Tegra264 document updated as well.
Thanks for the review. Dropping the change.
>
> Thanks,
> JC
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-05 3:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-03 2:47 [PATCH 1/1] phy: tegra: xusb: Fix UTMI AO sleepwalk trigger programming sequence Wayne Chang
2025-12-04 7:12 ` JC Kuo
2025-12-05 3:19 ` Wayne Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox