Linux Tegra architecture development
 help / color / mirror / Atom feed
* [PATCH] drm/tegra: remove redundant pm_runtime_dont_use_autosuspend() calls
@ 2026-11-10 15:19 Joshua Crofts
  2026-11-19  7:13 ` Mikko Perttunen
  0 siblings, 1 reply; 2+ messages in thread
From: Joshua Crofts @ 2026-11-10 15:19 UTC (permalink / raw)
  To: Thierry Reding, Mikko Perttunen, David Airlie, Simona Vetter,
	Jonathan Hunter
  Cc: dri-devel, linux-tegra, linux-kernel, Joshua Crofts

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls.

Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
 drivers/gpu/drm/tegra/nvdec.c | 1 -
 drivers/gpu/drm/tegra/nvjpg.c | 1 -
 drivers/gpu/drm/tegra/vic.c   | 1 -
 3 files changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/tegra/nvdec.c b/drivers/gpu/drm/tegra/nvdec.c
index 18a8f6e4ced083ee94cf1611223b7ef507e0b7f6..98a94423b0e2099b9f8330f73dee8f534564078f 100644
--- a/drivers/gpu/drm/tegra/nvdec.c
+++ b/drivers/gpu/drm/tegra/nvdec.c
@@ -212,7 +212,6 @@ static int nvdec_exit(struct host1x_client *client)
 	if (err < 0)
 		return err;
 
-	pm_runtime_dont_use_autosuspend(client->dev);
 	pm_runtime_force_suspend(client->dev);
 
 	host1x_syncpt_put(client->syncpts[0]);
diff --git a/drivers/gpu/drm/tegra/nvjpg.c b/drivers/gpu/drm/tegra/nvjpg.c
index e302a8d1f6e7fdbcd7f14881525b4a2e1a422361..09679bb0c75767ff1471134a478b5985b2c0ee5c 100644
--- a/drivers/gpu/drm/tegra/nvjpg.c
+++ b/drivers/gpu/drm/tegra/nvjpg.c
@@ -82,7 +82,6 @@ static int nvjpg_exit(struct host1x_client *client)
 	if (err < 0)
 		return err;
 
-	pm_runtime_dont_use_autosuspend(client->dev);
 	pm_runtime_force_suspend(client->dev);
 
 	host1x_client_iommu_detach(client);
diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
index 3c2b1ff55deb7f407d2a5995a5dff302cf37f7d5..9648c3d0176bbfd9efbb3c49c8bd9c74e3df9d0e 100644
--- a/drivers/gpu/drm/tegra/vic.c
+++ b/drivers/gpu/drm/tegra/vic.c
@@ -205,7 +205,6 @@ static int vic_exit(struct host1x_client *client)
 	if (err < 0)
 		return err;
 
-	pm_runtime_dont_use_autosuspend(client->dev);
 	pm_runtime_force_suspend(client->dev);
 
 	host1x_syncpt_put(client->syncpts[0]);

---
base-commit: b3dfbde62cf1981c4638939c159dfd087b7a72e9
change-id: 20261110-tegra-remove-dont-use-autosuspend-caaf082f8c2f

Best regards,
-- 
Joshua Crofts <crofts@kernel.org>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/tegra: remove redundant pm_runtime_dont_use_autosuspend() calls
  2026-11-10 15:19 [PATCH] drm/tegra: remove redundant pm_runtime_dont_use_autosuspend() calls Joshua Crofts
@ 2026-11-19  7:13 ` Mikko Perttunen
  0 siblings, 0 replies; 2+ messages in thread
From: Mikko Perttunen @ 2026-11-19  7:13 UTC (permalink / raw)
  To: Thierry Reding, David Airlie, Simona Vetter, Jonathan Hunter,
	linux-tegra
  Cc: dri-devel, linux-tegra, linux-kernel, Joshua Crofts,
	Joshua Crofts

On Wednesday, November 11, 2026 12:19 AM Joshua Crofts wrote:
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
> 
> Remove the redundant function calls.
> 
> Signed-off-by: Joshua Crofts <crofts@kernel.org>
> ---
>  drivers/gpu/drm/tegra/nvdec.c | 1 -
>  drivers/gpu/drm/tegra/nvjpg.c | 1 -
>  drivers/gpu/drm/tegra/vic.c   | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tegra/nvdec.c b/drivers/gpu/drm/tegra/nvdec.c
> index 18a8f6e4ced083ee94cf1611223b7ef507e0b7f6..98a94423b0e2099b9f8330f73dee8f534564078f 100644
> --- a/drivers/gpu/drm/tegra/nvdec.c
> +++ b/drivers/gpu/drm/tegra/nvdec.c
> @@ -212,7 +212,6 @@ static int nvdec_exit(struct host1x_client *client)
>  	if (err < 0)
>  		return err;
>  
> -	pm_runtime_dont_use_autosuspend(client->dev);
>  	pm_runtime_force_suspend(client->dev);
>  
>  	host1x_syncpt_put(client->syncpts[0]);
> diff --git a/drivers/gpu/drm/tegra/nvjpg.c b/drivers/gpu/drm/tegra/nvjpg.c
> index e302a8d1f6e7fdbcd7f14881525b4a2e1a422361..09679bb0c75767ff1471134a478b5985b2c0ee5c 100644
> --- a/drivers/gpu/drm/tegra/nvjpg.c
> +++ b/drivers/gpu/drm/tegra/nvjpg.c
> @@ -82,7 +82,6 @@ static int nvjpg_exit(struct host1x_client *client)
>  	if (err < 0)
>  		return err;
>  
> -	pm_runtime_dont_use_autosuspend(client->dev);
>  	pm_runtime_force_suspend(client->dev);
>  
>  	host1x_client_iommu_detach(client);
> diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
> index 3c2b1ff55deb7f407d2a5995a5dff302cf37f7d5..9648c3d0176bbfd9efbb3c49c8bd9c74e3df9d0e 100644
> --- a/drivers/gpu/drm/tegra/vic.c
> +++ b/drivers/gpu/drm/tegra/vic.c
> @@ -205,7 +205,6 @@ static int vic_exit(struct host1x_client *client)
>  	if (err < 0)
>  		return err;
>  
> -	pm_runtime_dont_use_autosuspend(client->dev);
>  	pm_runtime_force_suspend(client->dev);
>  
>  	host1x_syncpt_put(client->syncpts[0]);
> 
> ---
> base-commit: b3dfbde62cf1981c4638939c159dfd087b7a72e9
> change-id: 20261110-tegra-remove-dont-use-autosuspend-caaf082f8c2f
> 
> Best regards,
> -- 
> Joshua Crofts <crofts@kernel.org>
> 
> 

Nice cleanup, thank you!

Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-19  7:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-10 15:19 [PATCH] drm/tegra: remove redundant pm_runtime_dont_use_autosuspend() calls Joshua Crofts
2026-11-19  7:13 ` Mikko Perttunen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox