* [PATCH] soc/tegra: cbb: Remove redundant dev_err()
@ 2026-07-23 2:37 Pan Chuang
2026-07-23 4:10 ` Mikko Perttunen
0 siblings, 1 reply; 2+ messages in thread
From: Pan Chuang @ 2026-07-23 2:37 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, Shashank Balaji, Gary Guo,
Danilo Krummrich, Rahul Bukte, Bruno Sobreira França,
Pan Chuang, open list:TEGRA ARCHITECTURE SUPPORT, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/soc/tegra/cbb/tegra194-cbb.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/soc/tegra/cbb/tegra194-cbb.c b/drivers/soc/tegra/cbb/tegra194-cbb.c
index 2f69e104c838..69ef929e04f8 100644
--- a/drivers/soc/tegra/cbb/tegra194-cbb.c
+++ b/drivers/soc/tegra/cbb/tegra194-cbb.c
@@ -2072,20 +2072,15 @@ static int tegra194_cbb_interrupt_enable(struct tegra_cbb *cbb)
if (priv->sec_irq) {
err = devm_request_irq(dev, priv->sec_irq, tegra194_cbb_err_isr, 0, dev_name(dev),
priv);
- if (err) {
- dev_err(dev, "failed to register interrupt %u: %d\n", priv->sec_irq, err);
+ if (err)
return err;
- }
}
if (priv->nonsec_irq) {
err = devm_request_irq(dev, priv->nonsec_irq, tegra194_cbb_err_isr, 0,
dev_name(dev), priv);
- if (err) {
- dev_err(dev, "failed to register interrupt %u: %d\n", priv->nonsec_irq,
- err);
+ if (err)
return err;
- }
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc/tegra: cbb: Remove redundant dev_err()
2026-07-23 2:37 [PATCH] soc/tegra: cbb: Remove redundant dev_err() Pan Chuang
@ 2026-07-23 4:10 ` Mikko Perttunen
0 siblings, 0 replies; 2+ messages in thread
From: Mikko Perttunen @ 2026-07-23 4:10 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, Shashank Balaji, Gary Guo,
Danilo Krummrich, Rahul Bukte, Bruno Sobreira França,
Pan Chuang, open list:TEGRA ARCHITECTURE SUPPORT, open list,
Pan Chuang
On Thursday, July 23, 2026 11:37 AM Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/soc/tegra/cbb/tegra194-cbb.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/soc/tegra/cbb/tegra194-cbb.c b/drivers/soc/tegra/cbb/tegra194-cbb.c
> index 2f69e104c838..69ef929e04f8 100644
> --- a/drivers/soc/tegra/cbb/tegra194-cbb.c
> +++ b/drivers/soc/tegra/cbb/tegra194-cbb.c
> @@ -2072,20 +2072,15 @@ static int tegra194_cbb_interrupt_enable(struct tegra_cbb *cbb)
> if (priv->sec_irq) {
> err = devm_request_irq(dev, priv->sec_irq, tegra194_cbb_err_isr, 0, dev_name(dev),
> priv);
> - if (err) {
> - dev_err(dev, "failed to register interrupt %u: %d\n", priv->sec_irq, err);
> + if (err)
> return err;
> - }
> }
>
> if (priv->nonsec_irq) {
> err = devm_request_irq(dev, priv->nonsec_irq, tegra194_cbb_err_isr, 0,
> dev_name(dev), priv);
> - if (err) {
> - dev_err(dev, "failed to register interrupt %u: %d\n", priv->nonsec_irq,
> - err);
> + if (err)
> return err;
> - }
> }
>
> return 0;
> --
> 2.34.1
>
>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-23 4:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 2:37 [PATCH] soc/tegra: cbb: Remove redundant dev_err() Pan Chuang
2026-07-23 4:10 ` Mikko Perttunen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox