* [PATCH 31/44] serial: tegra: Use uart_xmit_advance()
[not found] <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com>
@ 2022-10-19 9:11 ` Ilpo Järvinen
2022-10-19 17:05 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Ilpo Järvinen @ 2022-10-19 9:11 UTC (permalink / raw)
To: linux-serial, Greg KH, Jiri Slaby, Laxman Dewangan,
Thierry Reding, Jonathan Hunter, linux-tegra, linux-kernel
Cc: Andy Shevchenko, Ilpo Järvinen
Take advantage of the new uart_xmit_advance() helper.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/tty/serial/serial-tegra.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
index b7170cb9a544..4304e3f9307d 100644
--- a/drivers/tty/serial/serial-tegra.c
+++ b/drivers/tty/serial/serial-tegra.c
@@ -496,8 +496,7 @@ static void tegra_uart_fill_tx_fifo(struct tegra_uart_port *tup, int max_bytes)
break;
}
tegra_uart_write(tup, xmit->buf[xmit->tail], UART_TX);
- xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
- tup->uport.icount.tx++;
+ uart_xmit_advance(&tup->uport, 1);
}
}
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 31/44] serial: tegra: Use uart_xmit_advance()
2022-10-19 9:11 ` [PATCH 31/44] serial: tegra: Use uart_xmit_advance() Ilpo Järvinen
@ 2022-10-19 17:05 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2022-10-19 17:05 UTC (permalink / raw)
To: Ilpo Järvinen
Cc: linux-serial, Greg KH, Jiri Slaby, Laxman Dewangan,
Jonathan Hunter, linux-tegra, linux-kernel, Andy Shevchenko
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
On Wed, Oct 19, 2022 at 12:11:38PM +0300, Ilpo Järvinen wrote:
> Take advantage of the new uart_xmit_advance() helper.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/serial/serial-tegra.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Looks good:
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-19 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com>
2022-10-19 9:11 ` [PATCH 31/44] serial: tegra: Use uart_xmit_advance() Ilpo Järvinen
2022-10-19 17:05 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox