From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Wayne Chang <waynec@nvidia.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH V4 4/5] i2c: nvidia-gpu: Replace ccgx to well-known regex
Date: Tue, 17 Jan 2023 14:06:58 +0200 [thread overview]
Message-ID: <Y8aPYkFJ+TqQtatx@kuha.fi.intel.com> (raw)
In-Reply-To: <20230116155045.100780-5-jonathanh@nvidia.com>
On Mon, Jan 16, 2023 at 03:50:44PM +0000, Jon Hunter wrote:
> From: Wayne Chang <waynec@nvidia.com>
>
> ccgx is refer to the cypress cypd4226 typec controller.
> Replace ccgx to well-known regex "cypress".
>
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> V2 -> V4: nothing has changed
> V1 -> V2: New change for adding cypress,firmware-build
>
> drivers/i2c/busses/i2c-nvidia-gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
> index 12e330cd7635..0934f8ad7f49 100644
> --- a/drivers/i2c/busses/i2c-nvidia-gpu.c
> +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
> @@ -260,7 +260,7 @@ MODULE_DEVICE_TABLE(pci, gpu_i2c_ids);
>
> static const struct property_entry ccgx_props[] = {
> /* Use FW built for NVIDIA (nv) only */
> - PROPERTY_ENTRY_U16("ccgx,firmware-build", ('n' << 8) | 'v'),
> + PROPERTY_ENTRY_U16("cypress,firmware-build", ('n' << 8) | 'v'),
> { }
> };
So you need a new patch where you first introduce that
"cypress,firmware-build" property. That patch comes before patch 3/5.
Then in this patch you only remove the old property
"ccgx,firmware-build" property.
thanks,
--
heikki
next prev parent reply other threads:[~2023-01-17 12:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 15:50 [PATCH V4 0/5] Add device-tree support for Cypress CYP4226 Jon Hunter
2023-01-16 15:50 ` [PATCH V4 1/5] dt-bindings: usb: Add binding for Cypress cypd4226 I2C driver Jon Hunter
2023-01-16 19:03 ` Krzysztof Kozlowski
2023-01-17 17:16 ` Jon Hunter
2023-01-17 17:40 ` Krzysztof Kozlowski
2023-01-16 15:50 ` [PATCH V4 2/5] usb: typec: ucsi_ccg: Add OF support Jon Hunter
2023-01-16 15:50 ` [PATCH V4 3/5] usb: typec: ucsi_ccg: Replace ccgx to well-known regex Jon Hunter
2023-01-17 12:02 ` Heikki Krogerus
2023-01-17 17:17 ` Jon Hunter
2023-01-17 23:29 ` Jon Hunter
2023-01-18 9:13 ` Heikki Krogerus
2023-01-19 10:45 ` Jon Hunter
2023-01-20 7:19 ` Goswami, Sanket
2023-01-16 15:50 ` [PATCH V4 4/5] i2c: nvidia-gpu: " Jon Hunter
2023-01-17 12:06 ` Heikki Krogerus [this message]
2023-01-16 15:50 ` [PATCH V4 5/5] arm64: tegra: Populate USB Type-C Controller for Jetson AGX Orin Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8aPYkFJ+TqQtatx@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=waynec@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox