[PATCH 3/3] ARM: dts: Update jedec,lpddr2 revision-id binding

[PATCH 3/3] ARM: dts: Update jedec,lpddr2 revision-id binding

[Julius Werner]

This patch updates the tegra20-asus-tf101 device tree to replace the
deprecated `revision-id1` binding with the new `revision-id` binding in
its "jedec,lpddr2"-compatible node. This was the only DTS in the tree
using this binding.

The revision-id2 (mode register 7) of this memory chip was not given in
the existing device tree, so let's assume 0 for now until it becomes
relevant.

Signed-off-by: Julius Werner <jwerner@chromium.org>
---
 arch/arm/boot/dts/tegra20-asus-tf101.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/tegra20-asus-tf101.dts b/arch/arm/boot/dts/tegra20-asus-tf101.dts
index 020172ee7340ec..c700f80e2a366e 100644
--- a/arch/arm/boot/dts/tegra20-asus-tf101.dts
+++ b/arch/arm/boot/dts/tegra20-asus-tf101.dts
@@ -756,7 +756,7 @@ emc-tables@3 {
 
 			lpddr2 {
 				compatible = "elpida,B8132B2PB-6D-F", "jedec,lpddr2-s4";
-				revision-id1 = <1>;
+				revision-id = <1 0>;
 				density = <2048>;
 				io-width = <16>;
 			};
-- 
2.31.0

Re: [PATCH 3/3] ARM: dts: Update jedec,lpddr2 revision-id binding

[Krzysztof Kozlowski]

On 24/02/2022 01:34, Julius Werner wrote:
> This patch updates the tegra20-asus-tf101 device tree to replace the
> deprecated `revision-id1` binding with the new `revision-id` binding in
> its "jedec,lpddr2"-compatible node. This was the only DTS in the tree
> using this binding.
> 
> The revision-id2 (mode register 7) of this memory chip was not given in
> the existing device tree, so let's assume 0 for now until it becomes
> relevant.
> 
> Signed-off-by: Julius Werner <jwerner@chromium.org>
> ---
>  arch/arm/boot/dts/tegra20-asus-tf101.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please use scripts/get_maintainer.pl to get the list of people/lists to
CC. You skipped here Tegra maintainers, so no one would pick up this patch.

I bounced the mail to Jonathan, Thierry and linux-tegra (+Cc), so
hopefully they will get it. If not, series might need resend with proper
addresses.


Best regards,
Krzysztof

Re: [PATCH 3/3] ARM: dts: Update jedec,lpddr2 revision-id binding

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On Thu, Feb 24, 2022 at 08:29:27AM +0100, Krzysztof Kozlowski wrote:
> On 24/02/2022 01:34, Julius Werner wrote:
> > This patch updates the tegra20-asus-tf101 device tree to replace the
> > deprecated `revision-id1` binding with the new `revision-id` binding in
> > its "jedec,lpddr2"-compatible node. This was the only DTS in the tree
> > using this binding.
> > 
> > The revision-id2 (mode register 7) of this memory chip was not given in
> > the existing device tree, so let's assume 0 for now until it becomes
> > relevant.
> > 
> > Signed-off-by: Julius Werner <jwerner@chromium.org>
> > ---
> >  arch/arm/boot/dts/tegra20-asus-tf101.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Please use scripts/get_maintainer.pl to get the list of people/lists to
> CC. You skipped here Tegra maintainers, so no one would pick up this patch.
> 
> I bounced the mail to Jonathan, Thierry and linux-tegra (+Cc), so
> hopefully they will get it. If not, series might need resend with proper
> addresses.

Thanks for the bounce. Applied.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 3/3] ARM: dts: Update jedec,lpddr2 revision-id binding

[Julius Werner]

> > I bounced the mail to Jonathan, Thierry and linux-tegra (+Cc), so
> > hopefully they will get it. If not, series might need resend with proper
> > addresses.
>
> Thanks for the bounce. Applied.

Sorry, I wasn't sure how this was supposed to work for interdependent
patches, I thought they would all go through the same maintainer tree.
If you do split them up please be aware of the dependency, i.e. this
patch should not be applied anywhere without patch 1 and 2 of this
series landing first.

Re: [PATCH 3/3] ARM: dts: Update jedec,lpddr2 revision-id binding

[Krzysztof Kozlowski]

On 25/02/2022 02:41, Julius Werner wrote:
>>> I bounced the mail to Jonathan, Thierry and linux-tegra (+Cc), so
>>> hopefully they will get it. If not, series might need resend with proper
>>> addresses.
>>
>> Thanks for the bounce. Applied.
> 
> Sorry, I wasn't sure how this was supposed to work for interdependent
> patches, I thought they would all go through the same maintainer tree.
> If you do split them up please be aware of the dependency, i.e. this
> patch should not be applied anywhere without patch 1 and 2 of this
> series landing first.

DTS changes never go with driver changes. Even if within the same tree,
these will be different branches, so you cannot maintain dependency. The
cover letter therefore should mention such dependency, so DTS won't get
applied too fast.

Best regards,
Krzysztof