* [Patch V3] soc/tegra: pmc: update Tegra234 reset sources
@ 2022-04-01 14:33 Sandipan Patra
2022-04-01 17:36 ` Andy Shevchenko
2022-04-06 13:05 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Sandipan Patra @ 2022-04-01 14:33 UTC (permalink / raw)
To: treding, jonathanh, digetx, ulf.hansson, andriy.shevchenko,
cai.huoqing
Cc: bbasu, linux-tegra, linux-kernel, Sandipan Patra
Reset_sources list is updated to add all reset sources
and removing ones that do not actually exist.
Signed-off-by: Sandipan Patra <spatra@nvidia.com>
---
Update on V3 patch:
Added more frequent comments to specify every 8 offsets
Update on V2 patch:
space inside comment and
Changed decimal to hexadecimal notation in the comments.
drivers/soc/tegra/pmc.c | 33 +++++++++++++++++++++++++--------
1 file changed, 25 insertions(+), 8 deletions(-)
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index fdf508e03400..c01db5309b5e 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -3766,7 +3766,7 @@ static const struct tegra_pmc_regs tegra234_pmc_regs = {
};
static const char * const tegra234_reset_sources[] = {
- "SYS_RESET_N",
+ "SYS_RESET_N", /* 0x0 */
"AOWDT",
"BCCPLEXWDT",
"BPMPWDT",
@@ -3774,19 +3774,36 @@ static const char * const tegra234_reset_sources[] = {
"SPEWDT",
"APEWDT",
"LCCPLEXWDT",
- "SENSOR",
- "AOTAG",
- "VFSENSOR",
+ "SENSOR", /* 0x8 */
+ NULL,
+ NULL,
"MAINSWRST",
"SC7",
"HSM",
- "CSITE",
+ NULL,
"RCEWDT",
- "PVA0WDT",
- "PVA1WDT",
- "L1A_ASYNC",
+ NULL, /* 0x10 */
+ NULL,
+ NULL,
"BPMPBOOT",
"FUSECRC",
+ "DCEWDT",
+ "PSCWDT",
+ "PSC",
+ "CSITE_SW", /* 0x18 */
+ "POD",
+ "SCPM",
+ "VREFRO_POWERBAD",
+ "VMON",
+ "FMON",
+ "FSI_R5WDT",
+ "FSI_THERM",
+ "FSI_R52C0WDT", /* 0x20 */
+ "FSI_R52C1WDT",
+ "FSI_R52C2WDT",
+ "FSI_R52C3WDT",
+ "FSI_FMON",
+ "FSI_VMON", /* 0x25 */
};
static const struct tegra_wake_event tegra234_wake_events[] = {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Patch V3] soc/tegra: pmc: update Tegra234 reset sources
2022-04-01 14:33 [Patch V3] soc/tegra: pmc: update Tegra234 reset sources Sandipan Patra
@ 2022-04-01 17:36 ` Andy Shevchenko
2022-04-06 13:05 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-04-01 17:36 UTC (permalink / raw)
To: Sandipan Patra
Cc: treding, jonathanh, digetx, ulf.hansson, cai.huoqing, bbasu,
linux-tegra, linux-kernel
On Fri, Apr 01, 2022 at 08:03:43PM +0530, Sandipan Patra wrote:
> Reset_sources list is updated to add all reset sources
> and removing ones that do not actually exist.
This LGTM, but I am not a maintainer.
So, if it helps and FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Sandipan Patra <spatra@nvidia.com>
> ---
> Update on V3 patch:
> Added more frequent comments to specify every 8 offsets
> Update on V2 patch:
> space inside comment and
> Changed decimal to hexadecimal notation in the comments.
>
> drivers/soc/tegra/pmc.c | 33 +++++++++++++++++++++++++--------
> 1 file changed, 25 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index fdf508e03400..c01db5309b5e 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -3766,7 +3766,7 @@ static const struct tegra_pmc_regs tegra234_pmc_regs = {
> };
>
> static const char * const tegra234_reset_sources[] = {
> - "SYS_RESET_N",
> + "SYS_RESET_N", /* 0x0 */
> "AOWDT",
> "BCCPLEXWDT",
> "BPMPWDT",
> @@ -3774,19 +3774,36 @@ static const char * const tegra234_reset_sources[] = {
> "SPEWDT",
> "APEWDT",
> "LCCPLEXWDT",
> - "SENSOR",
> - "AOTAG",
> - "VFSENSOR",
> + "SENSOR", /* 0x8 */
> + NULL,
> + NULL,
> "MAINSWRST",
> "SC7",
> "HSM",
> - "CSITE",
> + NULL,
> "RCEWDT",
> - "PVA0WDT",
> - "PVA1WDT",
> - "L1A_ASYNC",
> + NULL, /* 0x10 */
> + NULL,
> + NULL,
> "BPMPBOOT",
> "FUSECRC",
> + "DCEWDT",
> + "PSCWDT",
> + "PSC",
> + "CSITE_SW", /* 0x18 */
> + "POD",
> + "SCPM",
> + "VREFRO_POWERBAD",
> + "VMON",
> + "FMON",
> + "FSI_R5WDT",
> + "FSI_THERM",
> + "FSI_R52C0WDT", /* 0x20 */
> + "FSI_R52C1WDT",
> + "FSI_R52C2WDT",
> + "FSI_R52C3WDT",
> + "FSI_FMON",
> + "FSI_VMON", /* 0x25 */
> };
>
> static const struct tegra_wake_event tegra234_wake_events[] = {
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Patch V3] soc/tegra: pmc: update Tegra234 reset sources
2022-04-01 14:33 [Patch V3] soc/tegra: pmc: update Tegra234 reset sources Sandipan Patra
2022-04-01 17:36 ` Andy Shevchenko
@ 2022-04-06 13:05 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2022-04-06 13:05 UTC (permalink / raw)
To: Sandipan Patra
Cc: treding, jonathanh, digetx, ulf.hansson, andriy.shevchenko,
cai.huoqing, bbasu, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Fri, Apr 01, 2022 at 08:03:43PM +0530, Sandipan Patra wrote:
> Reset_sources list is updated to add all reset sources
> and removing ones that do not actually exist.
>
> Signed-off-by: Sandipan Patra <spatra@nvidia.com>
> ---
> Update on V3 patch:
> Added more frequent comments to specify every 8 offsets
> Update on V2 patch:
> space inside comment and
> Changed decimal to hexadecimal notation in the comments.
>
> drivers/soc/tegra/pmc.c | 33 +++++++++++++++++++++++++--------
> 1 file changed, 25 insertions(+), 8 deletions(-)
Applied with a slightly reworded commit message.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-06 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-01 14:33 [Patch V3] soc/tegra: pmc: update Tegra234 reset sources Sandipan Patra
2022-04-01 17:36 ` Andy Shevchenko
2022-04-06 13:05 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox