Linux Tegra architecture development
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
	Timo Alho <talho@nvidia.com>
Subject: Re: [PATCH 1/2] clk: tegra: register clocks from root to leaf
Date: Wed, 4 May 2022 11:32:22 +0200	[thread overview]
Message-ID: <YnJIJpHXmyRDYj5q@orome> (raw)
In-Reply-To: <20220406151701.262056-1-jonathanh@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

On Wed, Apr 06, 2022 at 04:17:00PM +0100, Jon Hunter wrote:
> From: Timo Alho <talho@nvidia.com>
> 
> Current clock initialization causes intermediate registering of orphan
> clocks (i.e. a clock without a parent registered). CCF keeps track of
> orphan clocks and any time a new clock is registered, it will loop
> through the list of orphan and queries if the parent is now
> available. This operation triggers a clk operation(s), which is an IPC
> with BPMP-FW. Hence, due to the order of which the clock appear
> currently, this causes >5000 IPC messages to be sent to BPMP-FW during
> clock initialization.
> 
> Optimize the clock probing by registering clocks hierarchically from
> root clock towards leafs.
> 
> Signed-off-by: Timo Alho <talho@nvidia.com>
> [ Checkpatch warnings fixed by Jon Hunter <jonathanh@nvidia.com> ]
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  drivers/clk/tegra/clk-bpmp.c | 72 ++++++++++++++++++++++++++++--------
>  1 file changed, 56 insertions(+), 16 deletions(-)

Both patches applied, with slight tweaks to the commit message.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2022-05-04  9:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06 15:17 [PATCH 1/2] clk: tegra: register clocks from root to leaf Jon Hunter
2022-04-06 15:17 ` [PATCH 2/2] clk: tegra: replace round_rate with determine_rate Jon Hunter
2022-05-04  9:32 ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnJIJpHXmyRDYj5q@orome \
    --to=thierry.reding@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=sboyd@kernel.org \
    --cc=talho@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox