* [PATCH 6/9] thermal/drivers/tegra: remove redundant msg in tegra_tsensor_register_channel() [not found] <20230318144412.75046-1-frank.li@vivo.com> @ 2023-03-18 14:44 ` Yangtao Li 2023-04-05 12:13 ` Thierry Reding 0 siblings, 1 reply; 2+ messages in thread From: Yangtao Li @ 2023-03-18 14:44 UTC (permalink / raw) To: Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui, Thierry Reding, Jonathan Hunter Cc: Yangtao Li, linux-pm, linux-tegra, linux-kernel The upper-layer devm_thermal_add_hwmon_sysfs() function can directly print error information. Signed-off-by: Yangtao Li <frank.li@vivo.com> --- drivers/thermal/tegra/tegra30-tsensor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/tegra/tegra30-tsensor.c index cb584a5735ed..c243e9d76d3c 100644 --- a/drivers/thermal/tegra/tegra30-tsensor.c +++ b/drivers/thermal/tegra/tegra30-tsensor.c @@ -523,8 +523,7 @@ static int tegra_tsensor_register_channel(struct tegra_tsensor *ts, return 0; } - if (devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd)) - dev_warn(ts->dev, "failed to add hwmon sysfs attributes\n"); + devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd); return 0; } -- 2.35.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/9] thermal/drivers/tegra: remove redundant msg in tegra_tsensor_register_channel() 2023-03-18 14:44 ` [PATCH 6/9] thermal/drivers/tegra: remove redundant msg in tegra_tsensor_register_channel() Yangtao Li @ 2023-04-05 12:13 ` Thierry Reding 0 siblings, 0 replies; 2+ messages in thread From: Thierry Reding @ 2023-04-05 12:13 UTC (permalink / raw) To: Yangtao Li Cc: Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui, Jonathan Hunter, linux-pm, linux-tegra, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1014 bytes --] On Sat, Mar 18, 2023 at 10:44:09PM +0800, Yangtao Li wrote: > The upper-layer devm_thermal_add_hwmon_sysfs() function can directly > print error information. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > drivers/thermal/tegra/tegra30-tsensor.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/tegra/tegra30-tsensor.c > index cb584a5735ed..c243e9d76d3c 100644 > --- a/drivers/thermal/tegra/tegra30-tsensor.c > +++ b/drivers/thermal/tegra/tegra30-tsensor.c > @@ -523,8 +523,7 @@ static int tegra_tsensor_register_channel(struct tegra_tsensor *ts, > return 0; > } > > - if (devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd)) > - dev_warn(ts->dev, "failed to add hwmon sysfs attributes\n"); > + devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd); I don't see any error messages output by devm_thermal_add_hwmon_sysfs() nor any of the functions that it calls. Did I miss something? Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-05 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230318144412.75046-1-frank.li@vivo.com>
2023-03-18 14:44 ` [PATCH 6/9] thermal/drivers/tegra: remove redundant msg in tegra_tsensor_register_channel() Yangtao Li
2023-04-05 12:13 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox