Re: [PATCH 6.5 000/285] 6.5.4-rc1 review

Re: [PATCH 6.5 000/285] 6.5.4-rc1 review

[Jon Hunter]

Hi Greg,

On 17/09/2023 20:10, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.5.4 release.
> There are 285 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Tue, 19 Sep 2023 19:10:04 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.5.4-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.5.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 
> -------------
> Pseudo-Shortlog of commits:

...

> Sameer Pujar <spujar@nvidia.com>
>      arm64: tegra: Update AHUB clock parent and rate


Unfortunately, the above change is causing a regression in one of our 
audio tests and we are looking into why this is.

Can we drop this from stable for now?

Sorry about this.

Jon

-- 
nvpublic

Re: [PATCH 6.5 000/285] 6.5.4-rc1 review

[Greg Kroah-Hartman]

On Mon, Sep 18, 2023 at 01:52:10PM +0100, Jon Hunter wrote:
> Hi Greg,
> 
> On 17/09/2023 20:10, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.5.4 release.
> > There are 285 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Tue, 19 Sep 2023 19:10:04 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.5.4-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.5.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > -------------
> > Pseudo-Shortlog of commits:
> 
> ...
> 
> > Sameer Pujar <spujar@nvidia.com>
> >      arm64: tegra: Update AHUB clock parent and rate
> 
> 
> Unfortunately, the above change is causing a regression in one of our audio
> tests and we are looking into why this is.
> 
> Can we drop this from stable for now?

Is it also a problem in Linus's tree?  Keeping bug-compatible is always
good :)

thanks,

greg k-h

Re: [PATCH 6.5 000/285] 6.5.4-rc1 review

[Jon Hunter]

On 18/09/2023 13:52, Jon Hunter wrote:
> Hi Greg,
> 
> On 17/09/2023 20:10, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 6.5.4 release.
>> There are 285 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Tue, 19 Sep 2023 19:10:04 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.5.4-rc1.gz
>> or in the git tree and branch at:
>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.5.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>>
>> -------------
>> Pseudo-Shortlog of commits:
> 
> ...
> 
>> Sameer Pujar <spujar@nvidia.com>
>>      arm64: tegra: Update AHUB clock parent and rate
> 
> 
> Unfortunately, the above change is causing a regression in one of our 
> audio tests and we are looking into why this is.
> 
> Can we drop this from stable for now?


An alternative to dropping this change is to pull in the following fixes ...

https://lore.kernel.org/linux-tegra/169447691068.2390116.10518505217580469969.b4-ty@kernel.org/T/#t

Thanks
Jon

-- 
nvpublic

Re: [PATCH 6.5 000/285] 6.5.4-rc1 review

[Greg Kroah-Hartman]

On Mon, Sep 18, 2023 at 02:04:27PM +0100, Jon Hunter wrote:
> 
> On 18/09/2023 13:52, Jon Hunter wrote:
> > Hi Greg,
> > 
> > On 17/09/2023 20:10, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 6.5.4 release.
> > > There are 285 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Tue, 19 Sep 2023 19:10:04 +0000.
> > > Anything received after that time might be too late.
> > > 
> > > The whole patch series can be found in one patch at:
> > >     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.5.4-rc1.gz
> > > or in the git tree and branch at:
> > >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.5.y
> > > and the diffstat can be found below.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > > -------------
> > > Pseudo-Shortlog of commits:
> > 
> > ...
> > 
> > > Sameer Pujar <spujar@nvidia.com>
> > >      arm64: tegra: Update AHUB clock parent and rate
> > 
> > 
> > Unfortunately, the above change is causing a regression in one of our
> > audio tests and we are looking into why this is.
> > 
> > Can we drop this from stable for now?
> 
> 
> An alternative to dropping this change is to pull in the following fixes ...
> 
> https://lore.kernel.org/linux-tegra/169447691068.2390116.10518505217580469969.b4-ty@kernel.org/T/#t

they aren't in Linus's tree yet, any plans on when that will happen?

And to confirm, what are the git ids of these in linux-next?

thanks,

greg k-h

Re: [PATCH 6.5 000/285] 6.5.4-rc1 review

[Jon Hunter]

On 18/09/2023 13:56, Greg Kroah-Hartman wrote:
> On Mon, Sep 18, 2023 at 01:52:10PM +0100, Jon Hunter wrote:
>> Hi Greg,
>>
>> On 17/09/2023 20:10, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 6.5.4 release.
>>> There are 285 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Tue, 19 Sep 2023 19:10:04 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.5.4-rc1.gz
>>> or in the git tree and branch at:
>>> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.5.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>> -------------
>>> Pseudo-Shortlog of commits:
>>
>> ...
>>
>>> Sameer Pujar <spujar@nvidia.com>
>>>       arm64: tegra: Update AHUB clock parent and rate
>>
>>
>> Unfortunately, the above change is causing a regression in one of our audio
>> tests and we are looking into why this is.
>>
>> Can we drop this from stable for now?
> 
> Is it also a problem in Linus's tree?  Keeping bug-compatible is always
> good :)


Yes this is also seen in Linus' tree, so we are compatible :-)

Jon

-- 
nvpublic

Re: [PATCH 6.5 000/285] 6.5.4-rc1 review

[Jon Hunter]

On 18/09/2023 14:14, Greg Kroah-Hartman wrote:
> On Mon, Sep 18, 2023 at 02:04:27PM +0100, Jon Hunter wrote:
>>
>> On 18/09/2023 13:52, Jon Hunter wrote:
>>> Hi Greg,
>>>
>>> On 17/09/2023 20:10, Greg Kroah-Hartman wrote:
>>>> This is the start of the stable review cycle for the 6.5.4 release.
>>>> There are 285 patches in this series, all will be posted as a response
>>>> to this one.  If anyone has any issues with these being applied, please
>>>> let me know.
>>>>
>>>> Responses should be made by Tue, 19 Sep 2023 19:10:04 +0000.
>>>> Anything received after that time might be too late.
>>>>
>>>> The whole patch series can be found in one patch at:
>>>>      https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.5.4-rc1.gz
>>>> or in the git tree and branch at:
>>>>      git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.5.y
>>>> and the diffstat can be found below.
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>>
>>>> -------------
>>>> Pseudo-Shortlog of commits:
>>>
>>> ...
>>>
>>>> Sameer Pujar <spujar@nvidia.com>
>>>>       arm64: tegra: Update AHUB clock parent and rate
>>>
>>>
>>> Unfortunately, the above change is causing a regression in one of our
>>> audio tests and we are looking into why this is.
>>>
>>> Can we drop this from stable for now?
>>
>>
>> An alternative to dropping this change is to pull in the following fixes ...
>>
>> https://lore.kernel.org/linux-tegra/169447691068.2390116.10518505217580469969.b4-ty@kernel.org/T/#t
> 
> they aren't in Linus's tree yet, any plans on when that will happen?


Not clear at the moment, I see Mark has them queued up here ...

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/?h=for-6.6 	
  
> And to confirm, what are the git ids of these in linux-next?


In next I see the following git ids ...

e765886249c5 ASoC: tegra: Fix redundant PLLA and PLLA_OUT0 updates
f101583fa9f8 ASoC: soc-utils: Export snd_soc_dai_is_dummy() symbol


Thanks
Jon

-- 
nvpublic

Re: [PATCH 6.5 000/285] 6.5.4-rc1 review

[Guenter Roeck]

On 9/18/23 05:56, Greg Kroah-Hartman wrote:
> On Mon, Sep 18, 2023 at 01:52:10PM +0100, Jon Hunter wrote:
>> Hi Greg,
>>
>> On 17/09/2023 20:10, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 6.5.4 release.
>>> There are 285 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Tue, 19 Sep 2023 19:10:04 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.5.4-rc1.gz
>>> or in the git tree and branch at:
>>> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.5.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>> -------------
>>> Pseudo-Shortlog of commits:
>>
>> ...
>>
>>> Sameer Pujar <spujar@nvidia.com>
>>>       arm64: tegra: Update AHUB clock parent and rate
>>
>>
>> Unfortunately, the above change is causing a regression in one of our audio
>> tests and we are looking into why this is.
>>
>> Can we drop this from stable for now?
> 
> Is it also a problem in Linus's tree?  Keeping bug-compatible is always
> good :)
> 

Sorry, no, it isn't, especially in the context of at the same time suggesting
that everyone should start using the most recent stable release immediately
(instead of, say, selectively picking security patches).

I don't think Tegra users would be happy if their audio stopped working,
and it seems unlikely that they would accept the argument that they should
be happy to be bug-compatible with the latest upstream kernel - even more so
if that latest upstream kernel is a release candidate and the problem was
introduced in the commit window.

Guenter

Re: [PATCH 6.5 000/285] 6.5.4-rc1 review

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

Hi!

> > > Sameer Pujar <spujar@nvidia.com>
> > >      arm64: tegra: Update AHUB clock parent and rate
> > 
> > 
> > Unfortunately, the above change is causing a regression in one of our audio
> > tests and we are looking into why this is.
> > 
> > Can we drop this from stable for now?
> 
> Is it also a problem in Linus's tree?  Keeping bug-compatible is always
> good :)

Please update Documentation/process/stable-kernel-rules.rst
accordingly. People expect certain properties from stable tree, and of
the rules written there only "It or an equivalent fix must already
exist in Linus' tree (upstream)." is followed.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH 6.5 000/285] 6.5.4-rc1 review

[Greg Kroah-Hartman]

On Mon, Sep 18, 2023 at 01:52:10PM +0100, Jon Hunter wrote:
> Hi Greg,
> 
> On 17/09/2023 20:10, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.5.4 release.
> > There are 285 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Tue, 19 Sep 2023 19:10:04 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.5.4-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.5.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > -------------
> > Pseudo-Shortlog of commits:
> 
> ...
> 
> > Sameer Pujar <spujar@nvidia.com>
> >      arm64: tegra: Update AHUB clock parent and rate
> 
> 
> Unfortunately, the above change is causing a regression in one of our audio
> tests and we are looking into why this is.
> 
> Can we drop this from stable for now?

Ok, now dropped, thanks all for the report.

greg k-h

Re: [PATCH 6.5 000/285] 6.5.4-rc1 review

[Greg Kroah-Hartman]

On Mon, Sep 18, 2023 at 08:17:43AM -0700, Guenter Roeck wrote:
> On 9/18/23 05:56, Greg Kroah-Hartman wrote:
> > On Mon, Sep 18, 2023 at 01:52:10PM +0100, Jon Hunter wrote:
> > > Hi Greg,
> > > 
> > > On 17/09/2023 20:10, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 6.5.4 release.
> > > > There are 285 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Tue, 19 Sep 2023 19:10:04 +0000.
> > > > Anything received after that time might be too late.
> > > > 
> > > > The whole patch series can be found in one patch at:
> > > > 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.5.4-rc1.gz
> > > > or in the git tree and branch at:
> > > > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.5.y
> > > > and the diffstat can be found below.
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > > 
> > > > -------------
> > > > Pseudo-Shortlog of commits:
> > > 
> > > ...
> > > 
> > > > Sameer Pujar <spujar@nvidia.com>
> > > >       arm64: tegra: Update AHUB clock parent and rate
> > > 
> > > 
> > > Unfortunately, the above change is causing a regression in one of our audio
> > > tests and we are looking into why this is.
> > > 
> > > Can we drop this from stable for now?
> > 
> > Is it also a problem in Linus's tree?  Keeping bug-compatible is always
> > good :)
> > 
> 
> Sorry, no, it isn't, especially in the context of at the same time suggesting
> that everyone should start using the most recent stable release immediately
> (instead of, say, selectively picking security patches).
> 
> I don't think Tegra users would be happy if their audio stopped working,
> and it seems unlikely that they would accept the argument that they should
> be happy to be bug-compatible with the latest upstream kernel - even more so
> if that latest upstream kernel is a release candidate and the problem was
> introduced in the commit window.

Very good point, I've now dropped it.

greg k-h