Linux Tegra architecture development
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	linux-tegra <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ALSA: hda: Enable sync-write operation as default for all controllers
Date: Tue, 14 Jul 2020 09:09:53 +0100	[thread overview]
Message-ID: <a0422e6d-462e-29cd-51e5-59751606a7e6@nvidia.com> (raw)
In-Reply-To: <8fc9f086-9a34-4287-8f51-6e0ebc34928f-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>


On 14/07/2020 09:08, Jon Hunter wrote:
> Hi Takashi,
> 
> On 18/06/2020 15:40, Takashi Iwai wrote:
>> In the end we already enabled the sync-write mode for most of HD-audio
>> controllers including Intel, and it's no big merit to keep the async
>> write mode for the rest.  Let's make it as default and drop the
>> superfluous AZX_DCAPS_SYNC_WRITE bit flag.
>>
>> Also, avoid to set the allow_bus_reset flag, which is a quite unstable
>> and hackish behavior that was needed only for some early platforms
>> (decades ago).  The straight fallback to the single cmd mode is more
>> robust.
>>
>> Signed-off-by: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
> 
> 
> I have noticed a regression in HDA playback on our Tegra186 Jetson TX2
> platform. Bisect is pointing to this patch and reverting this does
> appear to fix it. Interestingly, I am not seeing any problems on other
> Tegra platforms, however, Tegra186 does have the IOMMU enabled for HDA
> which is one different between the other platforms.
> 
> We can take a closer look at this for Tegra, but I am wondering if we
> revert this for Tegra for now.

By revert, I don't mean revert the entire change, but just disable the
sync-write for Tegra for now.

Jon

-- 
nvpublic

  parent reply	other threads:[~2020-07-14  8:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200618144051.7415-1-tiwai@suse.de>
     [not found] ` <20200618144051.7415-1-tiwai-l3A5Bk7waGM@public.gmane.org>
2020-07-14  8:08   ` [PATCH] ALSA: hda: Enable sync-write operation as default for all controllers Jon Hunter
     [not found]     ` <8fc9f086-9a34-4287-8f51-6e0ebc34928f-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-14  8:09       ` Jon Hunter [this message]
2020-07-14  8:30       ` Takashi Iwai
     [not found]         ` <s5hy2nmv6qv.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2020-07-14  9:08           ` Jon Hunter
     [not found]             ` <6f7a6d27-127d-9242-0638-abaf10e38410-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-14  9:12               ` Takashi Iwai
     [not found]                 ` <s5hr1tev4sw.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2020-07-14  9:51                   ` Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0422e6d-462e-29cd-51e5-59751606a7e6@nvidia.com \
    --to=jonathanh-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tiwai-l3A5Bk7waGM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox