From: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-tegra <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ALSA: hda: Enable sync-write operation as default for all controllers
Date: Tue, 14 Jul 2020 10:51:20 +0100 [thread overview]
Message-ID: <c2c925ab-5bf7-7f7c-cf30-126b3ba34fff@nvidia.com> (raw)
In-Reply-To: <s5hr1tev4sw.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
On 14/07/2020 10:12, Takashi Iwai wrote:
...
>> Did you mean ...
>>
>> diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
>> index 0cc5fad1af8a..5637f0129932 100644
>> --- a/sound/pci/hda/hda_tegra.c
>> +++ b/sound/pci/hda/hda_tegra.c
>> @@ -443,6 +443,7 @@ static int hda_tegra_create(struct snd_card *card,
>> if (err < 0)
>> return err;
>>
>> + chip->bus.core.sync_write = 0;
>> chip->bus.core.needs_damn_long_delay = 1;
>> chip->bus.core.aligned_mmio = 1;
>>
>> The above works for me.
>
> Yeah, sorry, that was a wrong patch :)
> I'm fine for applying it with some more comments.
>
> Care to submit a proper patch?
No problem. I will submit a patch.
Jon
--
nvpublic
prev parent reply other threads:[~2020-07-14 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200618144051.7415-1-tiwai@suse.de>
[not found] ` <20200618144051.7415-1-tiwai-l3A5Bk7waGM@public.gmane.org>
2020-07-14 8:08 ` [PATCH] ALSA: hda: Enable sync-write operation as default for all controllers Jon Hunter
[not found] ` <8fc9f086-9a34-4287-8f51-6e0ebc34928f-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-14 8:09 ` Jon Hunter
2020-07-14 8:30 ` Takashi Iwai
[not found] ` <s5hy2nmv6qv.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2020-07-14 9:08 ` Jon Hunter
[not found] ` <6f7a6d27-127d-9242-0638-abaf10e38410-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-14 9:12 ` Takashi Iwai
[not found] ` <s5hr1tev4sw.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2020-07-14 9:51 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2c925ab-5bf7-7f7c-cf30-126b3ba34fff@nvidia.com \
--to=jonathanh-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tiwai-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox