* [PATCH next] phy: tegra: xusb: remove a stray unlock
@ 2025-04-23 13:08 Dan Carpenter
2025-04-24 7:30 ` Jon Hunter
2025-05-14 11:31 ` Vinod Koul
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2025-04-23 13:08 UTC (permalink / raw)
To: Wayne Chang
Cc: JC Kuo, Vinod Koul, Kishon Vijay Abraham I, Thierry Reding,
Jonathan Hunter, linux-phy, linux-tegra, linux-kernel,
kernel-janitors
We used to take a lock in tegra186_utmi_bias_pad_power_on() but now we
have moved the lock into the caller. Unfortunately, when we moved the
lock this unlock was left behind and it results in a double unlock.
Delete it now.
Fixes: b47158fb4295 ("phy: tegra: xusb: Use a bitmask for UTMI pad power state tracking")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/phy/tegra/xusb-tegra186.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
index cc7b8a6a999f..23a23f2d64e5 100644
--- a/drivers/phy/tegra/xusb-tegra186.c
+++ b/drivers/phy/tegra/xusb-tegra186.c
@@ -656,8 +656,6 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl)
} else {
clk_disable_unprepare(priv->usb2_trk_clk);
}
-
- mutex_unlock(&padctl->lock);
}
static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl)
--
2.47.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH next] phy: tegra: xusb: remove a stray unlock
2025-04-23 13:08 [PATCH next] phy: tegra: xusb: remove a stray unlock Dan Carpenter
@ 2025-04-24 7:30 ` Jon Hunter
2025-05-07 8:47 ` Jon Hunter
2025-05-14 11:31 ` Vinod Koul
1 sibling, 1 reply; 4+ messages in thread
From: Jon Hunter @ 2025-04-24 7:30 UTC (permalink / raw)
To: Dan Carpenter, Wayne Chang
Cc: JC Kuo, Vinod Koul, Kishon Vijay Abraham I, Thierry Reding,
linux-phy, linux-tegra, linux-kernel, kernel-janitors
On 23/04/2025 14:08, Dan Carpenter wrote:
> We used to take a lock in tegra186_utmi_bias_pad_power_on() but now we
> have moved the lock into the caller. Unfortunately, when we moved the
> lock this unlock was left behind and it results in a double unlock.
> Delete it now.
>
> Fixes: b47158fb4295 ("phy: tegra: xusb: Use a bitmask for UTMI pad power state tracking")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/phy/tegra/xusb-tegra186.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index cc7b8a6a999f..23a23f2d64e5 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -656,8 +656,6 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl)
> } else {
> clk_disable_unprepare(priv->usb2_trk_clk);
> }
> -
> - mutex_unlock(&padctl->lock);
> }
>
> static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl)
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Thanks for catching and fixing this!
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH next] phy: tegra: xusb: remove a stray unlock
2025-04-24 7:30 ` Jon Hunter
@ 2025-05-07 8:47 ` Jon Hunter
0 siblings, 0 replies; 4+ messages in thread
From: Jon Hunter @ 2025-05-07 8:47 UTC (permalink / raw)
To: Dan Carpenter, Wayne Chang, Vinod Koul
Cc: JC Kuo, Kishon Vijay Abraham I, Thierry Reding, linux-phy,
linux-tegra, linux-kernel, kernel-janitors
Hi Vinod,
On 24/04/2025 08:30, Jon Hunter wrote:
>
> On 23/04/2025 14:08, Dan Carpenter wrote:
>> We used to take a lock in tegra186_utmi_bias_pad_power_on() but now we
>> have moved the lock into the caller. Unfortunately, when we moved the
>> lock this unlock was left behind and it results in a double unlock.
>> Delete it now.
>>
>> Fixes: b47158fb4295 ("phy: tegra: xusb: Use a bitmask for UTMI pad
>> power state tracking")
>> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>> ---
>> drivers/phy/tegra/xusb-tegra186.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/
>> xusb-tegra186.c
>> index cc7b8a6a999f..23a23f2d64e5 100644
>> --- a/drivers/phy/tegra/xusb-tegra186.c
>> +++ b/drivers/phy/tegra/xusb-tegra186.c
>> @@ -656,8 +656,6 @@ static void tegra186_utmi_bias_pad_power_on(struct
>> tegra_xusb_padctl *padctl)
>> } else {
>> clk_disable_unprepare(priv->usb2_trk_clk);
>> }
>> -
>> - mutex_unlock(&padctl->lock);
>> }
>> static void tegra186_utmi_bias_pad_power_off(struct
>> tegra_xusb_padctl *padctl)
>
>
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
>
> Thanks for catching and fixing this!
Can you pick this up please?
Thanks
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH next] phy: tegra: xusb: remove a stray unlock
2025-04-23 13:08 [PATCH next] phy: tegra: xusb: remove a stray unlock Dan Carpenter
2025-04-24 7:30 ` Jon Hunter
@ 2025-05-14 11:31 ` Vinod Koul
1 sibling, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2025-05-14 11:31 UTC (permalink / raw)
To: Wayne Chang, Dan Carpenter
Cc: JC Kuo, Kishon Vijay Abraham I, Thierry Reding, Jonathan Hunter,
linux-phy, linux-tegra, linux-kernel, kernel-janitors
On Wed, 23 Apr 2025 16:08:23 +0300, Dan Carpenter wrote:
> We used to take a lock in tegra186_utmi_bias_pad_power_on() but now we
> have moved the lock into the caller. Unfortunately, when we moved the
> lock this unlock was left behind and it results in a double unlock.
> Delete it now.
>
>
Applied, thanks!
[1/1] phy: tegra: xusb: remove a stray unlock
commit: 83c178470e0bf690d34c8c08440f2421b82e881c
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-14 11:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-23 13:08 [PATCH next] phy: tegra: xusb: remove a stray unlock Dan Carpenter
2025-04-24 7:30 ` Jon Hunter
2025-05-07 8:47 ` Jon Hunter
2025-05-14 11:31 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox