Re: [PATCH 5.10 000/491] 5.10.253-rc1 review

Re: [PATCH 5.10 000/491] 5.10.253-rc1 review

[Jon Hunter]

Hi Greg,

On 13/04/2026 16:54, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.253 release.
> There are 491 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Wed, 15 Apr 2026 15:57:08 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.253-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 
> -------------
> Pseudo-Shortlog of commits:

...
  
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>      bus: omap-ocp2scp: Convert to platform remove callback returning void


I am seeing the following build error due to the above change on ARM platforms ...

drivers/bus/omap-ocp2scp.c:95:10: error: 'struct platform_driver' has no member named 'remove_new'; did you mean 'remove'?
    95 |         .remove_new     = omap_ocp2scp_remove,
       |          ^~~~~~~~~~
       |          remove
drivers/bus/omap-ocp2scp.c:95:27: error: initialization of 'int (*)(struct platform_device *)' from incompatible pointer type 'void (*)(struct platform_device *)' [-Werror=incompatible-pointer-types]
    95 |         .remove_new     = omap_ocp2scp_remove,
       |                           ^~~~~~~~~~~~~~~~~~~

Thanks
Jon

-- 
nvpublic

Re: [PATCH 5.10 000/491] 5.10.253-rc1 review

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1948 bytes --]

On Mon 2026-04-13 19:52:08, Jon Hunter wrote:
> Hi Greg,
> 
> On 13/04/2026 16:54, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.253 release.
> > There are 491 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Wed, 15 Apr 2026 15:57:08 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.253-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > -------------
> > Pseudo-Shortlog of commits:
> 
> ...
> > Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >      bus: omap-ocp2scp: Convert to platform remove callback returning void
> 
> 
> I am seeing the following build error due to the above change on ARM platforms ...
> 
> drivers/bus/omap-ocp2scp.c:95:10: error: 'struct platform_driver' has no member named 'remove_new'; did you mean 'remove'?
>    95 |         .remove_new     = omap_ocp2scp_remove,
>       |          ^~~~~~~~~~
>       |          remove
> drivers/bus/omap-ocp2scp.c:95:27: error: initialization of 'int (*)(struct platform_device *)' from incompatible pointer type 'void (*)(struct platform_device *)' [-Werror=incompatible-pointer-types]
>    95 |         .remove_new     = omap_ocp2scp_remove,
>       |                           ^~~~~~~~~~~~~~~~~~~
> 

We see that one, too:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/13901155305
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/2450043152

Best regards,
										Pavel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH 5.10 000/491] 5.10.253-rc1 review

[Ben Copeland]

On Tue, 14 Apr 2026 at 09:03, Pavel Machek <pavel@nabladev.com> wrote:
>
> On Mon 2026-04-13 19:52:08, Jon Hunter wrote:
> > Hi Greg,
> >
> > On 13/04/2026 16:54, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.10.253 release.
> > > There are 491 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 15 Apr 2026 15:57:08 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >     https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.253-rc1.gz
> > > or in the git tree and branch at:
> > >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> > > -------------
> > > Pseudo-Shortlog of commits:
> >
> > ...
> > > Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > >      bus: omap-ocp2scp: Convert to platform remove callback returning void
> >
> >
> > I am seeing the following build error due to the above change on ARM platforms ...
> >
> > drivers/bus/omap-ocp2scp.c:95:10: error: 'struct platform_driver' has no member named 'remove_new'; did you mean 'remove'?
> >    95 |         .remove_new     = omap_ocp2scp_remove,
> >       |          ^~~~~~~~~~
> >       |          remove
> > drivers/bus/omap-ocp2scp.c:95:27: error: initialization of 'int (*)(struct platform_device *)' from incompatible pointer type 'void (*)(struct platform_device *)' [-Werror=incompatible-pointer-types]
> >    95 |         .remove_new     = omap_ocp2scp_remove,
> >       |                           ^~~~~~~~~~~~~~~~~~~
> >
>
> We see that one, too:
>
> https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/13901155305
> https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/2450043152
>
> Best regards,

This was also observed on KernelCI:

https://dashboard.kernelci.org/tree/stable-rc/linux-5.10.y/0abb5988a311f0e617615aa4b08c90b3ade85c25?df%7Ca%7Carm=true

The two issues:

https://dashboard.kernelci.org/issue/maestro%3A67d434ff5d6b71886d45efe758ca00ff45cb969a?iv=1
https://dashboard.kernelci.org/issue/maestro%3Ac970827f049cfd67124148e3c19abe1d4aa8347a?iv=1

Regards

Ben

>                                                                                 Pavel

Re: [PATCH 5.10 000/491] 5.10.253-rc1 review

[Ben Copeland]

On Wed, 15 Apr 2026 at 06:49, Ben Copeland <ben.copeland@linaro.org> wrote:
>
> On Tue, 14 Apr 2026 at 09:03, Pavel Machek <pavel@nabladev.com> wrote:
> >
> > On Mon 2026-04-13 19:52:08, Jon Hunter wrote:
> > > Hi Greg,
> > >
> > > On 13/04/2026 16:54, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 5.10.253 release.
> > > > There are 491 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Wed, 15 Apr 2026 15:57:08 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > >     https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.253-rc1.gz
> > > > or in the git tree and branch at:
> > > >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > > >
> > > > -------------
> > > > Pseudo-Shortlog of commits:
> > >
> > > ...
> > > > Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > >      bus: omap-ocp2scp: Convert to platform remove callback returning void
> > >
> > >
> > > I am seeing the following build error due to the above change on ARM platforms ...
> > >
> > > drivers/bus/omap-ocp2scp.c:95:10: error: 'struct platform_driver' has no member named 'remove_new'; did you mean 'remove'?
> > >    95 |         .remove_new     = omap_ocp2scp_remove,
> > >       |          ^~~~~~~~~~
> > >       |          remove
> > > drivers/bus/omap-ocp2scp.c:95:27: error: initialization of 'int (*)(struct platform_device *)' from incompatible pointer type 'void (*)(struct platform_device *)' [-Werror=incompatible-pointer-types]
> > >    95 |         .remove_new     = omap_ocp2scp_remove,
> > >       |                           ^~~~~~~~~~~~~~~~~~~
> > >
> >
> > We see that one, too:
> >
> > https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/13901155305
> > https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/2450043152
> >
> > Best regards,
>
> This was also observed on KernelCI:
>
> https://dashboard.kernelci.org/tree/stable-rc/linux-5.10.y/0abb5988a311f0e617615aa4b08c90b3ade85c25?df%7Ca%7Carm=true
>
> The two issues:
>
> https://dashboard.kernelci.org/issue/maestro%3A67d434ff5d6b71886d45efe758ca00ff45cb969a?iv=1
> https://dashboard.kernelci.org/issue/maestro%3Ac970827f049cfd67124148e3c19abe1d4aa8347a?iv=1

I bisected it to # first bad commit:
[708f670c8e0849525742cc3a1ce319739fe74c26] bus: omap-ocp2scp: Convert
to platform remove callback returning void

Here is the log:

# bad: [0abb5988a311f0e617615aa4b08c90b3ade85c25] Linux 5.10.253-rc1
# good: [fbb1715e3efa70ec20c5b1f755f3301fd3d042eb] Linux 5.10.252
git bisect start '0abb5988a311' 'v5.10.252'
# bad: [0cbe44da7c41f095b72fb599410d0530ca80a9aa] ASoC: soc-core: move
snd_soc_runtime_set_dai_fmt() to upside
git bisect bad 0cbe44da7c41f095b72fb599410d0530ca80a9aa
# bad: [9b7ae0b9077850af955e1c8c976808feb269cc44] net: Handle
napi_schedule() calls from non-interrupt
git bisect bad 9b7ae0b9077850af955e1c8c976808feb269cc44
# bad: [eb39b81e0f85135e1e5a39b6c7bfbec77e03467b] sh: platform_early:
remove pdev->driver_override check
git bisect bad eb39b81e0f85135e1e5a39b6c7bfbec77e03467b
# bad: [a1ea84bad7500d1e346bf3714850c5a32c4d5c51] net: qrtr: Add GFP
flags parameter to qrtr_alloc_ctrl_packet
git bisect bad a1ea84bad7500d1e346bf3714850c5a32c4d5c51
# bad: [e6613448c424bc28ca19cad1e56295ae101cd9c4] usb: gadget:
dummy_hcd: fix premature URB completion when ZLP follows partial
transfer
git bisect bad e6613448c424bc28ca19cad1e56295ae101cd9c4
# good: [0f8c01ecc1771e45d065f17df934c2bdc4d6a825] drm/tegra: dsi: fix
device leak on probe
git bisect good 0f8c01ecc1771e45d065f17df934c2bdc4d6a825
# bad: [5a490afd6710b438b7fab854128d34e05e60c4bf] can: ucan: Fix
infinite loop from zero-length messages
git bisect bad 5a490afd6710b438b7fab854128d34e05e60c4bf
# bad: [5ec032ae50ff9959dccf12ccf0438c4b03032e2b] can: mcp251x: fix
deadlock in error path of mcp251x_open
git bisect bad 5ec032ae50ff9959dccf12ccf0438c4b03032e2b
# bad: [e2f4d521f05adb048145737f4f87125ab0452f25] scsi: storvsc: Fix
scheduling while atomic on PREEMPT_RT
git bisect bad e2f4d521f05adb048145737f4f87125ab0452f25
# bad: [708f670c8e0849525742cc3a1ce319739fe74c26] bus: omap-ocp2scp:
Convert to platform remove callback returning void
git bisect bad 708f670c8e0849525742cc3a1ce319739fe74c26
# bad: [fd70655e816486140fd3b8d190e98bc0390d756b] clk: tegra:
tegra124-emc: fix device leak on set_rate()
git bisect bad fd70655e816486140fd3b8d190e98bc0390d756b
# bad: [7cea67d4c59e7351b459cef6aa062127a4501923] hwmon: (max16065)
Use READ/WRITE_ONCE to avoid compiler optimization induced race
git bisect bad 7cea67d4c59e7351b459cef6aa062127a4501923
# bad: [efed6d887792cb026aef5fe3b711583b56b8037f] net: arcnet:
com20020-pci: fix support for 2.5Mbit cards
git bisect bad efed6d887792cb026aef5fe3b711583b56b8037f
# bad: [dad08fee3e0e4c9c2103fe7538af96398f7a7567] net: usb: kaweth:
validate USB endpoints
git bisect bad dad08fee3e0e4c9c2103fe7538af96398f7a7567
# bad: [2529a8fc2f31887320b59699da52508055fba791] net: usb: pegasus:
validate USB endpoints
git bisect bad 2529a8fc2f31887320b59699da52508055fba791
# first bad commit: [708f670c8e0849525742cc3a1ce319739fe74c26] bus:
omap-ocp2scp: Convert to platform remove callback returning void


Regards,

Ben


>
> Regards
>
> Ben
>
> >                                                                                 Pavel