[PATCH] soc/tegra: fuse: Fix spurious straps warning on SMCCC platforms

[PATCH] soc/tegra: fuse: Fix spurious straps warning on SMCCC platforms

[Breno Leitao]

My Grace host started to show this warning:
  WARNING: drivers/soc/tegra/fuse/tegra-apbmisc.c:120 at tegra_read_straps
   tegra30_fuse_add_randomness
   tegra30_fuse_init
   tegra_fuse_probe

tegra_read_straps() warns when the static "chipid" cache is still zero,
using it as a proxy for "APBMISC has been initialised". However chipid
is only ever populated lazily by tegra_read_chipid() when it reads the
APBMISC register.

Guard on apbmisc_base instead, which is set unconditionally in
tegra_init_apbmisc_resources() for all platforms and is already the
sentinel used by tegra_read_chipid().

Fixes: c71f213fa5af ("soc/tegra: fuse: Warn if straps are not ready")
Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/soc/tegra/fuse/tegra-apbmisc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/tegra/fuse/tegra-apbmisc.c b/drivers/soc/tegra/fuse/tegra-apbmisc.c
index 87ae63a7e52d..7aba7c58bad0 100644
--- a/drivers/soc/tegra/fuse/tegra-apbmisc.c
+++ b/drivers/soc/tegra/fuse/tegra-apbmisc.c
@@ -117,7 +117,7 @@ bool tegra_is_silicon(void)
 
 u32 tegra_read_straps(void)
 {
-	WARN(!chipid, "Tegra ABP MISC not yet available\n");
+	WARN(!apbmisc_base, "Tegra ABP MISC not yet available\n");
 
 	return strapping;
 }

---
base-commit: 1f5563665c2715e5ab2f64ec3d4b0af60927014f
change-id: 20260604-tegra_warn_fix-f9e8085b4175

Best regards,
-- 
Breno Leitao <leitao@debian.org>

Re: [PATCH] soc/tegra: fuse: Fix spurious straps warning on SMCCC platforms

[Breno Leitao]

On Thu, Jun 04, 2026 at 03:36:17AM -0700, Breno Leitao wrote:
> My Grace host started to show this warning:
>   WARNING: drivers/soc/tegra/fuse/tegra-apbmisc.c:120 at tegra_read_straps
>    tegra30_fuse_add_randomness
>    tegra30_fuse_init
>    tegra_fuse_probe
> 
> tegra_read_straps() warns when the static "chipid" cache is still zero,
> using it as a proxy for "APBMISC has been initialised". However chipid
> is only ever populated lazily by tegra_read_chipid() when it reads the
> APBMISC register.
> 
> Guard on apbmisc_base instead, which is set unconditionally in
> tegra_init_apbmisc_resources() for all platforms and is already the
> sentinel used by tegra_read_chipid().
> 
> Fixes: c71f213fa5af ("soc/tegra: fuse: Warn if straps are not ready")
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  drivers/soc/tegra/fuse/tegra-apbmisc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/tegra/fuse/tegra-apbmisc.c b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> index 87ae63a7e52d..7aba7c58bad0 100644
> --- a/drivers/soc/tegra/fuse/tegra-apbmisc.c
> +++ b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> @@ -117,7 +117,7 @@ bool tegra_is_silicon(void)
>  
>  u32 tegra_read_straps(void)
>  {
> -	WARN(!chipid, "Tegra ABP MISC not yet available\n");
> +	WARN(!apbmisc_base, "Tegra ABP MISC not yet available\n");

Hello Thierry,

Have you had a chance to look at this one? This is showing up in my
Grace all the time.

Thanks