* [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure
@ 2026-07-09 2:30 Pan Chuang
2026-07-09 2:30 ` [PATCH 17/18] thermal/drivers/tegra: Remove redundant dev_err() and dev_err_probe() Pan Chuang
2026-07-09 7:09 ` [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Pan Chuang @ 2026-07-09 2:30 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Miquel Raynal, Markus Mayer, Broadcom internal kernel review list,
Florian Fainelli, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, zhanghongchen, Yinbo Zhu, Amit Kucheria,
Thara Gopinath, Niklas Söderlund, Geert Uytterhoeven,
Magnus Damm, John Madieu, Heiko Stuebner,
Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski, Peter Griffin,
Alim Akhtar, Maxime Coquelin, Alexandre Torgue, Thierry Reding,
Jonathan Hunter, Matthias Brugger, AngeloGioacchino Del Regno,
Srinivas Pandruvada, Pan Chuang, Laura Nao, Mason Chang, Fei Shao,
Frank Wunderlich, Jiapeng Chong, Andy Shevchenko,
Jiri Slaby (SUSE), Svyatoslav Ryhel, open list:THERMAL, open list,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:QUALCOMM TSENS THERMAL DRIVER,
open list:RENESAS R-CAR THERMAL DRIVERS,
open list:ARM/Rockchip SoC support,
open list:SAMSUNG THERMAL DRIVER,
moderated list:ARM/STM32 ARCHITECTURE,
open list:TEGRA ARCHITECTURE SUPPORT,
moderated list:ARM/Mediatek SoC support:Keyword:mediatek
Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
error handling in devm_request_*_irq()") added automatic error
logging to devm_request_threaded_irq() and
devm_request_any_context_irq() via the new devm_request_result()
helper, which prints device name, IRQ number, handler functions, and
error code on failure.
Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this automatic
logging.
Remove the now-redundant dev_err() and dev_err_probe() calls in
thermal drivers that follow these devm_request_*_irq() functions, as
the core now provides more detailed diagnostic information on failure.
Pan Chuang (18):
thermal/drivers/airoha: Remove redundant dev_err()
thermal/drivers/armada: Remove redundant dev_err()
thermal/drivers/db8500: Remove redundant dev_err()
thermal/drivers/hisi: Remove redundant dev_err()
thermal/drivers/imx: Remove redundant dev_err()
thermal/drivers/loongson2: Remove redundant dev_err_probe()
thermal/drivers/max77620: Remove redundant dev_err()
thermal/drivers/rockchip: Remove redundant dev_err_probe()
thermal/drivers/brcmstb_thermal: Remove redundant dev_err_probe()
thermal: intel: int340x: Remove redundant dev_err()
thermal/drivers/intel/bxt_pmic: Remove redundant dev_err()
thermal/drivers/mediatek/lvts_thermal: Remove redundant dev_err()
thermal/drivers/qcom: Remove redundant dev_err()
thermal/drivers/renesas: Remove redundant dev_err()
thermal/drivers/exynos: Remove redundant dev_err()
thermal/drivers/st: Remove redundant dev_err()
thermal/drivers/tegra: Remove redundant dev_err() and dev_err_probe()
thermal/drivers/imx91: Remove redundant dev_err_probe()
drivers/thermal/airoha_thermal.c | 4 +---
drivers/thermal/armada_thermal.c | 5 +----
drivers/thermal/broadcom/brcmstb_thermal.c | 3 +--
drivers/thermal/db8500_thermal.c | 8 ++------
drivers/thermal/hisi_thermal.c | 4 +---
drivers/thermal/imx91_thermal.c | 2 +-
drivers/thermal/imx_thermal.c | 4 +---
.../intel/int340x_thermal/processor_thermal_device_pci.c | 8 ++------
drivers/thermal/intel/intel_bxt_pmic_thermal.c | 4 +---
drivers/thermal/loongson2_thermal.c | 2 +-
drivers/thermal/max77620_thermal.c | 8 ++------
drivers/thermal/mediatek/lvts_thermal.c | 2 +-
drivers/thermal/qcom/lmh.c | 1 -
drivers/thermal/qcom/tsens.c | 5 +----
drivers/thermal/renesas/rcar_thermal.c | 4 +---
drivers/thermal/renesas/rzg3e_thermal.c | 4 +---
drivers/thermal/rockchip_thermal.c | 3 +--
drivers/thermal/samsung/exynos_tmu.c | 4 +---
drivers/thermal/st/st_thermal_memmap.c | 4 +---
drivers/thermal/st/stm_thermal.c | 5 +----
drivers/thermal/tegra/soctherm.c | 8 ++------
drivers/thermal/tegra/tegra30-tsensor.c | 3 +--
22 files changed, 25 insertions(+), 70 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 17/18] thermal/drivers/tegra: Remove redundant dev_err() and dev_err_probe()
2026-07-09 2:30 [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Pan Chuang
@ 2026-07-09 2:30 ` Pan Chuang
2026-07-09 7:09 ` [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Pan Chuang @ 2026-07-09 2:30 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Thierry Reding, Jonathan Hunter, Pan Chuang, Svyatoslav Ryhel,
Jiri Slaby (SUSE), open list:THERMAL,
open list:TEGRA ARCHITECTURE SUPPORT, open list
The devm_request_threaded_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err() and dev_err_probe() calls that previously printed generic
messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/thermal/tegra/soctherm.c | 8 ++------
drivers/thermal/tegra/tegra30-tsensor.c | 3 +--
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index d8e988a0d43e..f74acf13b24d 100644
--- a/drivers/thermal/tegra/soctherm.c
+++ b/drivers/thermal/tegra/soctherm.c
@@ -2007,10 +2007,8 @@ static int soctherm_interrupts_init(struct platform_device *pdev,
IRQF_ONESHOT,
dev_name(&pdev->dev),
tegra);
- if (ret < 0) {
- dev_err(&pdev->dev, "request_irq 'thermal_irq' failed.\n");
+ if (ret < 0)
return ret;
- }
ret = devm_request_threaded_irq(&pdev->dev,
tegra->edp_irq,
@@ -2019,10 +2017,8 @@ static int soctherm_interrupts_init(struct platform_device *pdev,
IRQF_ONESHOT,
"soctherm_edp",
tegra);
- if (ret < 0) {
- dev_err(&pdev->dev, "request_irq 'edp_irq' failed.\n");
+ if (ret < 0)
return ret;
- }
return 0;
}
diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/tegra/tegra30-tsensor.c
index 6245f6b97f43..10a5ab1fe1b9 100644
--- a/drivers/thermal/tegra/tegra30-tsensor.c
+++ b/drivers/thermal/tegra/tegra30-tsensor.c
@@ -602,8 +602,7 @@ static int tegra_tsensor_probe(struct platform_device *pdev)
tegra_tsensor_isr, IRQF_ONESHOT,
"tegra_tsensor", ts);
if (err)
- return dev_err_probe(&pdev->dev, err,
- "failed to request interrupt\n");
+ return err;
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure
2026-07-09 2:30 [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-09 2:30 ` [PATCH 17/18] thermal/drivers/tegra: Remove redundant dev_err() and dev_err_probe() Pan Chuang
@ 2026-07-09 7:09 ` Krzysztof Kozlowski
2026-07-09 7:24 ` Wolfram Sang
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-09 7:09 UTC (permalink / raw)
To: Pan Chuang, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba, Miquel Raynal, Markus Mayer,
Broadcom internal kernel review list, Florian Fainelli, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
zhanghongchen, Yinbo Zhu, Amit Kucheria, Thara Gopinath,
Niklas Söderlund, Geert Uytterhoeven, Magnus Damm,
John Madieu, Heiko Stuebner, Bartlomiej Zolnierkiewicz,
Peter Griffin, Alim Akhtar, Maxime Coquelin, Alexandre Torgue,
Thierry Reding, Jonathan Hunter, Matthias Brugger,
AngeloGioacchino Del Regno, Srinivas Pandruvada, Laura Nao,
Mason Chang, Fei Shao, Frank Wunderlich, Jiapeng Chong,
Andy Shevchenko, Jiri Slaby (SUSE), Svyatoslav Ryhel,
open list:THERMAL, open list,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:QUALCOMM TSENS THERMAL DRIVER,
open list:RENESAS R-CAR THERMAL DRIVERS,
open list:ARM/Rockchip SoC support,
open list:SAMSUNG THERMAL DRIVER,
moderated list:ARM/STM32 ARCHITECTURE,
open list:TEGRA ARCHITECTURE SUPPORT,
moderated list:ARM/Mediatek SoC support:Keyword:mediatek
On 09/07/2026 04:30, Pan Chuang wrote:
> Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
> error handling in devm_request_*_irq()") added automatic error
> logging to devm_request_threaded_irq() and
> devm_request_any_context_irq() via the new devm_request_result()
> helper, which prints device name, IRQ number, handler functions, and
> error code on failure.
>
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this automatic
> logging.
>
> Remove the now-redundant dev_err() and dev_err_probe() calls in
> thermal drivers that follow these devm_request_*_irq() functions, as
> the core now provides more detailed diagnostic information on failure.
>
> Pan Chuang (18):
> thermal/drivers/airoha: Remove redundant dev_err()
> thermal/drivers/armada: Remove redundant dev_err()
> thermal/drivers/db8500: Remove redundant dev_err()
all of these 18 are just one commit, no?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure
2026-07-09 7:09 ` [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Krzysztof Kozlowski
@ 2026-07-09 7:24 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2026-07-09 7:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Pan Chuang, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba, Miquel Raynal, Markus Mayer,
Broadcom internal kernel review list, Florian Fainelli, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
zhanghongchen, Yinbo Zhu, Amit Kucheria, Thara Gopinath,
Niklas Söderlund, Geert Uytterhoeven, Magnus Damm,
John Madieu, Heiko Stuebner, Bartlomiej Zolnierkiewicz,
Peter Griffin, Alim Akhtar, Maxime Coquelin, Alexandre Torgue,
Thierry Reding, Jonathan Hunter, Matthias Brugger,
AngeloGioacchino Del Regno, Srinivas Pandruvada, Laura Nao,
Mason Chang, Fei Shao, Frank Wunderlich, Jiapeng Chong,
Andy Shevchenko, Jiri Slaby (SUSE), Svyatoslav Ryhel,
open list:THERMAL, open list,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:QUALCOMM TSENS THERMAL DRIVER,
open list:RENESAS R-CAR THERMAL DRIVERS,
open list:ARM/Rockchip SoC support,
open list:SAMSUNG THERMAL DRIVER,
moderated list:ARM/STM32 ARCHITECTURE,
open list:TEGRA ARCHITECTURE SUPPORT,
moderated list:ARM/Mediatek SoC support:Keyword:mediatek
> all of these 18 are just one commit, no?
I think so, too.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-09 7:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-09 2:30 [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-09 2:30 ` [PATCH 17/18] thermal/drivers/tegra: Remove redundant dev_err() and dev_err_probe() Pan Chuang
2026-07-09 7:09 ` [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Krzysztof Kozlowski
2026-07-09 7:24 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox