From: Mark Brown <broonie@kernel.org>
To: Diogo Ivo <diogo.ivo@bootlin.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Animesh Agarwal <animeshagarwal28@gmail.com>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: realtek,rt5677: Add clock property
Date: Thu, 3 Sep 2026 10:57:17 +0100 [thread overview]
Message-ID: <aplEfd33wSz59iLS@sirena.org.uk> (raw)
In-Reply-To: <20260903-rt5677-mclk-v1-1-b71a5a3533f9@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On Thu, Sep 03, 2026 at 12:11:00AM +0200, Diogo Ivo wrote:
> Add a clock property as the RT5677 codec can be fed an
> external clock signal.
> + clocks:
> + items:
> + - description: phandle and clock specifier for codec MCLK.
> +
> + clock-names:
> + items:
> + - const: mclk
The driver code has a reference to MCLK1 which implies multiple MCLKs,
unfortunately no pinout seems to be available and other references in
the driver are just to MCLK so it could be cut'n'paste.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-03 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 22:10 [PATCH 0/2] rt5677: add mclk to DT binding and define it for Smaug Diogo Ivo
2026-09-02 22:11 ` [PATCH 1/2] ASoC: dt-bindings: realtek,rt5677: Add clock property Diogo Ivo
2026-09-03 9:57 ` Mark Brown [this message]
2026-09-03 13:26 ` Diogo Ivo
2026-09-03 21:01 ` Mark Brown
2026-09-04 9:06 ` Diogo Ivo
2026-09-02 22:11 ` [PATCH 2/2] arm64: tegra: smaug: Add rt5677 mclk input Diogo Ivo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aplEfd33wSz59iLS@sirena.org.uk \
--to=broonie@kernel.org \
--cc=animeshagarwal28@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@bootlin.com \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox