Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings

Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings

[Dmitry Osipenko]

27.02.2020 13:35, Julia Lawall пишет:
> From: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
> 
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> 
> Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
> CC: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Julia Lawall <julia.lawall-MZpvjPyXg2s@public.gmane.org>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
> commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST
> :::::: branch date: 17 hours ago
> :::::: commit date: 2 days ago
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  tegra20-apb-dma.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
>  		irq = platform_get_irq(pdev, i);
>  		if (irq < 0) {
>  			ret = irq;
> -			dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
>  			goto err_pm_disable;
>  		}
> 

Reviewed-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

On Thu, Feb 27, 2020 at 05:50:19PM +0300, Dmitry Osipenko wrote:
> 27.02.2020 13:35, Julia Lawall пишет:
> > From: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > 
> > Remove dev_err() messages after platform_get_irq*() failures.
> > platform_get_irq() already prints an error.
> > 
> > Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> > 
> > Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
> > CC: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Julia Lawall <julia.lawall-MZpvjPyXg2s@public.gmane.org>
> > ---
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
> > commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST
> > :::::: branch date: 17 hours ago
> > :::::: commit date: 2 days ago
> > 
> > Please take the patch only if it's a positive warning. Thanks!
> > 
> >  tegra20-apb-dma.c |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > --- a/drivers/dma/tegra20-apb-dma.c
> > +++ b/drivers/dma/tegra20-apb-dma.c
> > @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
> >  		irq = platform_get_irq(pdev, i);
> >  		if (irq < 0) {
> >  			ret = irq;
> > -			dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
> >  			goto err_pm_disable;
> >  		}
> > 
> 
> Reviewed-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]