From: Andrew Lunn <andrew@lunn.ch>
To: Brad Griffis <bgriffis@nvidia.com>
Cc: Furong Xu <0x1207@gmail.com>, Jon Hunter <jonathanh@nvidia.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Joe Damato <jdamato@fastly.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
xfr@outlook.com,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH net-next v3 1/4] net: stmmac: Switch to zero-copy in non-XDP RX path
Date: Thu, 23 Jan 2025 22:48:42 +0100 [thread overview]
Message-ID: <ccbecd2a-7889-4389-977e-10da6a00391c@lunn.ch> (raw)
In-Reply-To: <e6305e71-5633-48bf-988d-fa2886e16aae@nvidia.com>
> Just to clarify, the patch that you had us try was not intended as an actual
> fix, correct? It was only for diagnostic purposes, i.e. to see if there is
> some kind of cache coherence issue, which seems to be the case? So perhaps
> the only fix needed is to add dma-coherent to our device tree?
That sounds quite error prone. How many other DT blobs are missing the
property? If the memory should be coherent, i would expect the driver
to allocate coherent memory. Or the driver needs to handle
non-coherent memory and add the necessary flush/invalidates etc.
Andrew
next prev parent reply other threads:[~2025-01-23 21:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1736910454.git.0x1207@gmail.com>
[not found] ` <bd7aabf4d9b6696885922ed4bef8fc95142d3004.1736910454.git.0x1207@gmail.com>
2025-01-23 14:06 ` [PATCH net-next v3 1/4] net: stmmac: Switch to zero-copy in non-XDP RX path Jon Hunter
2025-01-23 16:35 ` Furong Xu
2025-01-23 19:53 ` Brad Griffis
2025-01-23 21:48 ` Andrew Lunn [this message]
2025-01-24 2:42 ` Furong Xu
2025-01-24 13:15 ` Thierry Reding
2025-01-28 20:04 ` Lucas Stach
2025-01-25 10:20 ` Ido Schimmel
2025-01-25 14:43 ` Furong Xu
2025-01-26 8:41 ` Ido Schimmel
2025-01-26 10:37 ` Furong Xu
2025-01-26 11:35 ` Ido Schimmel
2025-01-26 12:56 ` Furong Xu
2025-01-25 15:03 ` Furong Xu
2025-01-25 19:08 ` Andrew Lunn
2025-01-26 2:39 ` Furong Xu
2025-01-27 13:28 ` Thierry Reding
2025-01-29 14:51 ` Jon Hunter
2025-02-07 9:07 ` Furong Xu
2025-02-07 13:42 ` Jon Hunter
2025-01-24 1:53 ` Furong Xu
2025-01-24 15:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccbecd2a-7889-4389-977e-10da6a00391c@lunn.ch \
--to=andrew@lunn.ch \
--cc=0x1207@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=bgriffis@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=jonathanh@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xfr@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox