* [PATCH v2 2/2] dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA
2024-01-12 9:32 [PATCH v2 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA Peter Robinson
@ 2024-01-12 9:32 ` Peter Robinson
2024-01-17 14:56 ` Jon Hunter
2024-01-19 15:37 ` Thierry Reding
2024-01-17 14:55 ` [PATCH v2 1/2] bus: tegra-aconnect: " Jon Hunter
` (2 subsequent siblings)
3 siblings, 2 replies; 8+ messages in thread
From: Peter Robinson @ 2024-01-12 9:32 UTC (permalink / raw)
To: linux-tegra
Cc: Peter Robinson, Jon Hunter, Thierry Reding, Sameer Pujar,
Laxman Dewangan
Update the architecture dependency to be the generic Tegra
because the driver works on the four latest Tegra generations
not just T210, if you build a kernel with a specific
ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get
this driver.
Fixes: 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Sameer Pujar <spujar@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>
---
v2: fix spelling of option
drivers/dma/Kconfig | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 70ba506dabab5..de6eb370d485d 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -629,16 +629,16 @@ config TEGRA20_APB_DMA
config TEGRA210_ADMA
tristate "NVIDIA Tegra210 ADMA support"
- depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST)
+ depends on (ARCH_TEGRA || COMPILE_TEST)
select DMA_ENGINE
select DMA_VIRTUAL_CHANNELS
help
- Support for the NVIDIA Tegra210 ADMA controller driver. The
- DMA controller has multiple DMA channels and is used to service
- various audio clients in the Tegra210 audio processing engine
- (APE). This DMA controller transfers data from memory to
- peripheral and vice versa. It does not support memory to
- memory data transfer.
+ Support for the NVIDIA Tegra210/Tegra186/Tegra194/Tegra234 ADMA
+ controller driver. The DMA controller has multiple DMA channels
+ and is used to service various audio clients in the Tegra210
+ audio processing engine (APE). This DMA controller transfers
+ data from memory to peripheral and vice versa. It does not
+ support memory to memory data transfer.
config TIMB_DMA
tristate "Timberdale FPGA DMA support"
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 2/2] dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA
2024-01-12 9:32 ` [PATCH v2 2/2] dmaengine: tegra210-adma: " Peter Robinson
@ 2024-01-17 14:56 ` Jon Hunter
2024-01-19 15:37 ` Thierry Reding
1 sibling, 0 replies; 8+ messages in thread
From: Jon Hunter @ 2024-01-17 14:56 UTC (permalink / raw)
To: Peter Robinson, linux-tegra, Vinod Koul
Cc: Thierry Reding, Sameer Pujar, Laxman Dewangan
Adding Vinod ...
On 12/01/2024 09:32, Peter Robinson wrote:
> Update the architecture dependency to be the generic Tegra
> because the driver works on the four latest Tegra generations
> not just T210, if you build a kernel with a specific
> ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get
> this driver.
>
> Fixes: 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Cc: Jon Hunter <jonathanh@nvidia.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Sameer Pujar <spujar@nvidia.com>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> ---
>
> v2: fix spelling of option
>
> drivers/dma/Kconfig | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 70ba506dabab5..de6eb370d485d 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -629,16 +629,16 @@ config TEGRA20_APB_DMA
>
> config TEGRA210_ADMA
> tristate "NVIDIA Tegra210 ADMA support"
> - depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST)
> + depends on (ARCH_TEGRA || COMPILE_TEST)
> select DMA_ENGINE
> select DMA_VIRTUAL_CHANNELS
> help
> - Support for the NVIDIA Tegra210 ADMA controller driver. The
> - DMA controller has multiple DMA channels and is used to service
> - various audio clients in the Tegra210 audio processing engine
> - (APE). This DMA controller transfers data from memory to
> - peripheral and vice versa. It does not support memory to
> - memory data transfer.
> + Support for the NVIDIA Tegra210/Tegra186/Tegra194/Tegra234 ADMA
> + controller driver. The DMA controller has multiple DMA channels
> + and is used to service various audio clients in the Tegra210
> + audio processing engine (APE). This DMA controller transfers
> + data from memory to peripheral and vice versa. It does not
> + support memory to memory data transfer.
>
> config TIMB_DMA
> tristate "Timberdale FPGA DMA support"
Thanks!
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 2/2] dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA
2024-01-12 9:32 ` [PATCH v2 2/2] dmaengine: tegra210-adma: " Peter Robinson
2024-01-17 14:56 ` Jon Hunter
@ 2024-01-19 15:37 ` Thierry Reding
1 sibling, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2024-01-19 15:37 UTC (permalink / raw)
To: Peter Robinson, linux-tegra
Cc: Jon Hunter, Thierry Reding, Sameer Pujar, Laxman Dewangan
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
On Fri Jan 12, 2024 at 10:32 AM CET, Peter Robinson wrote:
> Update the architecture dependency to be the generic Tegra
> because the driver works on the four latest Tegra generations
> not just T210, if you build a kernel with a specific
> ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get
> this driver.
>
> Fixes: 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Cc: Jon Hunter <jonathanh@nvidia.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Sameer Pujar <spujar@nvidia.com>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> ---
>
> v2: fix spelling of option
>
> drivers/dma/Kconfig | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Same comments as for the ACONNECT patch.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA
2024-01-12 9:32 [PATCH v2 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA Peter Robinson
2024-01-12 9:32 ` [PATCH v2 2/2] dmaengine: tegra210-adma: " Peter Robinson
@ 2024-01-17 14:55 ` Jon Hunter
2024-01-19 15:37 ` Thierry Reding
2024-01-22 16:25 ` (subset) " Vinod Koul
3 siblings, 0 replies; 8+ messages in thread
From: Jon Hunter @ 2024-01-17 14:55 UTC (permalink / raw)
To: Peter Robinson, linux-tegra; +Cc: Thierry Reding
On 12/01/2024 09:32, Peter Robinson wrote:
> Update the architecture dependency to be the generic Tegra
> because the driver works on the four latest Tegra generations
> not just T210, if you build a kernel with a specific
> ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get
> this driver.
>
> Fixes: 46a88534afb59 ("bus: Add support for Tegra ACONNECT")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Cc: Jon Hunter <jonathanh@nvidia.com>
> Cc: Thierry Reding <treding@nvidia.com>
> ---
>
> v2: fix spelling of option
>
> drivers/bus/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index e6742998f372c..b003dad62d596 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -186,11 +186,12 @@ config SUNXI_RSB
>
> config TEGRA_ACONNECT
> tristate "Tegra ACONNECT Bus Driver"
> - depends on ARCH_TEGRA_210_SOC
> + depends on ARCH_TEGRA
> depends on OF && PM
> help
> Driver for the Tegra ACONNECT bus which is used to interface with
> - the devices inside the Audio Processing Engine (APE) for Tegra210.
> + the devices inside the Audio Processing Engine (APE) for
> + Tegra210/Tegra186/Tegra194/Tegra234.
>
> config TEGRA_GMI
> tristate "Tegra Generic Memory Interface bus driver"
Thanks!
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA
2024-01-12 9:32 [PATCH v2 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA Peter Robinson
2024-01-12 9:32 ` [PATCH v2 2/2] dmaengine: tegra210-adma: " Peter Robinson
2024-01-17 14:55 ` [PATCH v2 1/2] bus: tegra-aconnect: " Jon Hunter
@ 2024-01-19 15:37 ` Thierry Reding
2024-01-22 7:59 ` Sameer Pujar
2024-01-22 16:25 ` (subset) " Vinod Koul
3 siblings, 1 reply; 8+ messages in thread
From: Thierry Reding @ 2024-01-19 15:37 UTC (permalink / raw)
To: Peter Robinson, linux-tegra; +Cc: Jon Hunter, Thierry Reding, Sameer Pujar
[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]
On Fri Jan 12, 2024 at 10:32 AM CET, Peter Robinson wrote:
> Update the architecture dependency to be the generic Tegra
> because the driver works on the four latest Tegra generations
> not just T210, if you build a kernel with a specific
I prefer spelling these out as Tegra210 for better greppability.
> ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get
> this driver.
>
> Fixes: 46a88534afb59 ("bus: Add support for Tegra ACONNECT")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Cc: Jon Hunter <jonathanh@nvidia.com>
> Cc: Thierry Reding <treding@nvidia.com>
> ---
>
> v2: fix spelling of option
>
> drivers/bus/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index e6742998f372c..b003dad62d596 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -186,11 +186,12 @@ config SUNXI_RSB
>
> config TEGRA_ACONNECT
> tristate "Tegra ACONNECT Bus Driver"
> - depends on ARCH_TEGRA_210_SOC
> + depends on ARCH_TEGRA
> depends on OF && PM
> help
> Driver for the Tegra ACONNECT bus which is used to interface with
> - the devices inside the Audio Processing Engine (APE) for Tegra210.
> + the devices inside the Audio Processing Engine (APE) for
> + Tegra210/Tegra186/Tegra194/Tegra234.
Perhaps we want to say something like "Tegra210 and later"? I know it's
going to be in at least one more, but I would think it's likely that it
will stay around even longer.
Sameer, have you seen any indication that ACONNECT will go away in some
future chip?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA
2024-01-19 15:37 ` Thierry Reding
@ 2024-01-22 7:59 ` Sameer Pujar
0 siblings, 0 replies; 8+ messages in thread
From: Sameer Pujar @ 2024-01-22 7:59 UTC (permalink / raw)
To: Thierry Reding, Peter Robinson, linux-tegra; +Cc: Jon Hunter, Thierry Reding
On 19-01-2024 21:07, Thierry Reding wrote:
> On Fri Jan 12, 2024 at 10:32 AM CET, Peter Robinson wrote:
>> Update the architecture dependency to be the generic Tegra
>> because the driver works on the four latest Tegra generations
>> not just T210, if you build a kernel with a specific
> I prefer spelling these out as Tegra210 for better greppability.
>
>> ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get
>> this driver.
>>
>> Fixes: 46a88534afb59 ("bus: Add support for Tegra ACONNECT")
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> Cc: Jon Hunter <jonathanh@nvidia.com>
>> Cc: Thierry Reding <treding@nvidia.com>
>> ---
>>
>> v2: fix spelling of option
>>
>> drivers/bus/Kconfig | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
>> index e6742998f372c..b003dad62d596 100644
>> --- a/drivers/bus/Kconfig
>> +++ b/drivers/bus/Kconfig
>> @@ -186,11 +186,12 @@ config SUNXI_RSB
>>
>> config TEGRA_ACONNECT
>> tristate "Tegra ACONNECT Bus Driver"
>> - depends on ARCH_TEGRA_210_SOC
>> + depends on ARCH_TEGRA
>> depends on OF && PM
>> help
>> Driver for the Tegra ACONNECT bus which is used to interface with
>> - the devices inside the Audio Processing Engine (APE) for Tegra210.
>> + the devices inside the Audio Processing Engine (APE) for
>> + Tegra210/Tegra186/Tegra194/Tegra234.
> Perhaps we want to say something like "Tegra210 and later"? I know it's
> going to be in at least one more, but I would think it's likely that it
> will stay around even longer.
>
> Sameer, have you seen any indication that ACONNECT will go away in some
> future chip?
Yes, no signs of this going away. "Tegra210 and later" looks good.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (subset) [PATCH v2 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA
2024-01-12 9:32 [PATCH v2 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA Peter Robinson
` (2 preceding siblings ...)
2024-01-19 15:37 ` Thierry Reding
@ 2024-01-22 16:25 ` Vinod Koul
3 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2024-01-22 16:25 UTC (permalink / raw)
To: linux-tegra, Peter Robinson; +Cc: Jon Hunter, Thierry Reding
On Fri, 12 Jan 2024 09:32:55 +0000, Peter Robinson wrote:
> Update the architecture dependency to be the generic Tegra
> because the driver works on the four latest Tegra generations
> not just T210, if you build a kernel with a specific
> ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get
> this driver.
>
>
> [...]
Applied, thanks!
[2/2] dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA
commit: 33b7db45533af240fe44e809f9dc4d604cf82d07
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread