* Re: linux-next: Tree for Jan 29 (soc/tegra/fuse/fuse-tegra30.c) [not found] <20240129143030.16647483@canb.auug.org.au> @ 2024-01-30 4:06 ` Randy Dunlap 2024-01-30 10:46 ` Jon Hunter 0 siblings, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2024-01-30 4:06 UTC (permalink / raw) To: Stephen Rothwell, Linux Next Mailing List Cc: Linux Kernel Mailing List, linux-tegra, Arnd Bergmann, Kartik [-- Attachment #1: Type: text/plain, Size: 688 bytes --] On 1/28/24 19:30, Stephen Rothwell wrote: > Hi all, > > Changes since 20240125: > on arm64: ../drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'? 684 | .read = tegra30_fuse_read, | ^~~~~~~~~~~~~~~~~ | tegra_fuse_readl ../drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error: 'tegra30_fuse_init' undeclared here (not in a function); did you mean 'tegra_fuse_info'? 694 | .init = tegra30_fuse_init, | ^~~~~~~~~~~~~~~~~ | tegra_fuse_info Full randconfig file is attached. -- #Randy [-- Attachment #2: config-r5887.gz --] [-- Type: application/gzip, Size: 45378 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for Jan 29 (soc/tegra/fuse/fuse-tegra30.c) 2024-01-30 4:06 ` linux-next: Tree for Jan 29 (soc/tegra/fuse/fuse-tegra30.c) Randy Dunlap @ 2024-01-30 10:46 ` Jon Hunter 2024-01-30 10:59 ` Arnd Bergmann 0 siblings, 1 reply; 5+ messages in thread From: Jon Hunter @ 2024-01-30 10:46 UTC (permalink / raw) To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List, Kartik K Cc: Linux Kernel Mailing List, linux-tegra@vger.kernel.org, Arnd Bergmann, Thierry Reding On 30/01/2024 04:06, Randy Dunlap wrote: > > > On 1/28/24 19:30, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20240125: >> > > on arm64: > > ../drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'? > 684 | .read = tegra30_fuse_read, > | ^~~~~~~~~~~~~~~~~ > | tegra_fuse_readl > ../drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error: 'tegra30_fuse_init' undeclared here (not in a function); did you mean 'tegra_fuse_info'? > 694 | .init = tegra30_fuse_init, > | ^~~~~~~~~~~~~~~~~ > | tegra_fuse_info Looks like we are missing the following ... diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c index 2070d36c510d..eb14e5ff5a0a 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra30.c +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c @@ -38,7 +38,8 @@ defined(CONFIG_ARCH_TEGRA_210_SOC) || \ defined(CONFIG_ARCH_TEGRA_186_SOC) || \ defined(CONFIG_ARCH_TEGRA_194_SOC) || \ - defined(CONFIG_ARCH_TEGRA_234_SOC) + defined(CONFIG_ARCH_TEGRA_234_SOC) || \ + defined(CONFIG_ARCH_TEGRA_241_SOC) static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned int offset) Kartik, can you send a fix for this? Jon -- nvpublic ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for Jan 29 (soc/tegra/fuse/fuse-tegra30.c) 2024-01-30 10:46 ` Jon Hunter @ 2024-01-30 10:59 ` Arnd Bergmann 2024-01-30 11:02 ` Jon Hunter 2024-02-01 15:07 ` Thierry Reding 0 siblings, 2 replies; 5+ messages in thread From: Arnd Bergmann @ 2024-01-30 10:59 UTC (permalink / raw) To: Jon Hunter, Randy Dunlap, Stephen Rothwell, linux-next, Kartik Cc: Linux Kernel Mailing List, linux-tegra@vger.kernel.org, Thierry Reding On Tue, Jan 30, 2024, at 11:46, Jon Hunter wrote: > On 30/01/2024 04:06, Randy Dunlap wrote: > Looks like we are missing the following ... > > diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c > b/drivers/soc/tegra/fuse/fuse-tegra30.c > index 2070d36c510d..eb14e5ff5a0a 100644 > --- a/drivers/soc/tegra/fuse/fuse-tegra30.c > +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c > @@ -38,7 +38,8 @@ > defined(CONFIG_ARCH_TEGRA_210_SOC) || \ > defined(CONFIG_ARCH_TEGRA_186_SOC) || \ > defined(CONFIG_ARCH_TEGRA_194_SOC) || \ > - defined(CONFIG_ARCH_TEGRA_234_SOC) > + defined(CONFIG_ARCH_TEGRA_234_SOC) || \ > + defined(CONFIG_ARCH_TEGRA_241_SOC) > static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned > int offset) > > > Kartik, can you send a fix for this? If I get an Ack for my original patch, I can pick that up into the soc tree directly: https://lore.kernel.org/all/20240103102654.3779458-1-arnd@kernel.org/ Arnd ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for Jan 29 (soc/tegra/fuse/fuse-tegra30.c) 2024-01-30 10:59 ` Arnd Bergmann @ 2024-01-30 11:02 ` Jon Hunter 2024-02-01 15:07 ` Thierry Reding 1 sibling, 0 replies; 5+ messages in thread From: Jon Hunter @ 2024-01-30 11:02 UTC (permalink / raw) To: Arnd Bergmann, Randy Dunlap, Stephen Rothwell, linux-next, Kartik Cc: Linux Kernel Mailing List, linux-tegra@vger.kernel.org, Thierry Reding On 30/01/2024 10:59, Arnd Bergmann wrote: > On Tue, Jan 30, 2024, at 11:46, Jon Hunter wrote: >> On 30/01/2024 04:06, Randy Dunlap wrote: > >> Looks like we are missing the following ... >> >> diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c >> b/drivers/soc/tegra/fuse/fuse-tegra30.c >> index 2070d36c510d..eb14e5ff5a0a 100644 >> --- a/drivers/soc/tegra/fuse/fuse-tegra30.c >> +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c >> @@ -38,7 +38,8 @@ >> defined(CONFIG_ARCH_TEGRA_210_SOC) || \ >> defined(CONFIG_ARCH_TEGRA_186_SOC) || \ >> defined(CONFIG_ARCH_TEGRA_194_SOC) || \ >> - defined(CONFIG_ARCH_TEGRA_234_SOC) >> + defined(CONFIG_ARCH_TEGRA_234_SOC) || \ >> + defined(CONFIG_ARCH_TEGRA_241_SOC) >> static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned >> int offset) >> >> >> Kartik, can you send a fix for this? > > If I get an Ack for my original patch, I can pick that > up into the soc tree directly: > > https://lore.kernel.org/all/20240103102654.3779458-1-arnd@kernel.org/ Done! Thanks. Jon -- nvpublic ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for Jan 29 (soc/tegra/fuse/fuse-tegra30.c) 2024-01-30 10:59 ` Arnd Bergmann 2024-01-30 11:02 ` Jon Hunter @ 2024-02-01 15:07 ` Thierry Reding 1 sibling, 0 replies; 5+ messages in thread From: Thierry Reding @ 2024-02-01 15:07 UTC (permalink / raw) To: Arnd Bergmann, Jon Hunter, Randy Dunlap, Stephen Rothwell, linux-next, Kartik Cc: Linux Kernel Mailing List, linux-tegra@vger.kernel.org, Thierry Reding On Tue Jan 30, 2024 at 11:59 AM CET, Arnd Bergmann wrote: > On Tue, Jan 30, 2024, at 11:46, Jon Hunter wrote: > > On 30/01/2024 04:06, Randy Dunlap wrote: > > > Looks like we are missing the following ... > > > > diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c > > b/drivers/soc/tegra/fuse/fuse-tegra30.c > > index 2070d36c510d..eb14e5ff5a0a 100644 > > --- a/drivers/soc/tegra/fuse/fuse-tegra30.c > > +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c > > @@ -38,7 +38,8 @@ > > defined(CONFIG_ARCH_TEGRA_210_SOC) || \ > > defined(CONFIG_ARCH_TEGRA_186_SOC) || \ > > defined(CONFIG_ARCH_TEGRA_194_SOC) || \ > > - defined(CONFIG_ARCH_TEGRA_234_SOC) > > + defined(CONFIG_ARCH_TEGRA_234_SOC) || \ > > + defined(CONFIG_ARCH_TEGRA_241_SOC) > > static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned > > int offset) > > > > > > Kartik, can you send a fix for this? > > If I get an Ack for my original patch, I can pick that > up into the soc tree directly: > > https://lore.kernel.org/all/20240103102654.3779458-1-arnd@kernel.org/ Sorry for the delay on this. I guess you can't really apply that to ARM SoC directly because the patch that introduces Tegra241 support is only in the Tegra tree. In any case, I've applied your patch now, so the fixed version should show up in tomorrow's linux-next. I'm considering squashing it into the original since that'd preserve bisectability, though that'd probably be of limited usefulness because most people doing regression builds involving this will likely have one of the other bits enabled. Thierry ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-01 15:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240129143030.16647483@canb.auug.org.au>
2024-01-30 4:06 ` linux-next: Tree for Jan 29 (soc/tegra/fuse/fuse-tegra30.c) Randy Dunlap
2024-01-30 10:46 ` Jon Hunter
2024-01-30 10:59 ` Arnd Bergmann
2024-01-30 11:02 ` Jon Hunter
2024-02-01 15:07 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox