* [PATCH] media: cec: tegra: add missing MODULE_DEVICE_TABLE()
@ 2026-07-04 12:26 Pengpeng Hou
2026-07-15 3:22 ` Mikko Perttunen
0 siblings, 1 reply; 2+ messages in thread
From: Pengpeng Hou @ 2026-07-04 12:26 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Thierry Reding,
Jonathan Hunter
Cc: Pengpeng Hou, linux-tegra, linux-media, linux-kernel
The driver has an OF match table wired to .of_match_table, but does
not export the table with MODULE_DEVICE_TABLE().
Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
information is generated for OF based module autoloading.
This is a source-level fix. It does not claim dynamic hardware
reproduction; the evidence is the driver-owned match table, its use by
the platform driver, and the missing module alias publication.
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
drivers/media/cec/platform/tegra/tegra_cec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/cec/platform/tegra/tegra_cec.c b/drivers/media/cec/platform/tegra/tegra_cec.c
index 3ed50097262f..fe66336e734f 100644
--- a/drivers/media/cec/platform/tegra/tegra_cec.c
+++ b/drivers/media/cec/platform/tegra/tegra_cec.c
@@ -458,6 +458,7 @@ static const struct of_device_id tegra_cec_of_match[] = {
{ .compatible = "nvidia,tegra210-cec", },
{},
};
+MODULE_DEVICE_TABLE(of, tegra_cec_of_match);
static struct platform_driver tegra_cec_driver = {
.driver = {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: cec: tegra: add missing MODULE_DEVICE_TABLE()
2026-07-04 12:26 [PATCH] media: cec: tegra: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
@ 2026-07-15 3:22 ` Mikko Perttunen
0 siblings, 0 replies; 2+ messages in thread
From: Mikko Perttunen @ 2026-07-15 3:22 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Thierry Reding,
Jonathan Hunter, Pengpeng Hou
Cc: Pengpeng Hou, linux-tegra, linux-media, linux-kernel
On Saturday, July 4, 2026 9:26 PM Pengpeng Hou wrote:
> The driver has an OF match table wired to .of_match_table, but does
> not export the table with MODULE_DEVICE_TABLE().
>
> Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
> information is generated for OF based module autoloading.
>
> This is a source-level fix. It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the platform driver, and the missing module alias publication.
This paragraph doesn't belong in the commit message. Below the three
dashes you can simply say that the patch is only build-tested. No
elaborate AI patch justifications necessary.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
> drivers/media/cec/platform/tegra/tegra_cec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/cec/platform/tegra/tegra_cec.c b/drivers/media/cec/platform/tegra/tegra_cec.c
> index 3ed50097262f..fe66336e734f 100644
> --- a/drivers/media/cec/platform/tegra/tegra_cec.c
> +++ b/drivers/media/cec/platform/tegra/tegra_cec.c
> @@ -458,6 +458,7 @@ static const struct of_device_id tegra_cec_of_match[] = {
> { .compatible = "nvidia,tegra210-cec", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, tegra_cec_of_match);
>
> static struct platform_driver tegra_cec_driver = {
> .driver = {
>
>
Otherwise looks fine to me.
Mikko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-15 3:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-04 12:26 [PATCH] media: cec: tegra: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
2026-07-15 3:22 ` Mikko Perttunen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox