Linux Trace Development
 help / color / mirror / Atom feed
* [PATCH] libtracefs/utest: Do not use synth for test_synth element
@ 2023-05-30  6:21 Steven Rostedt
  0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2023-05-30  6:21 UTC (permalink / raw)
  To: Linux Trace Devel

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

The test_synth_compare() function is confusing as it uses "synth" for the
test_synth structure. "synth" should only be used for tracefs_synth
descriptors. Rename it to "sevents" to match the variable of the calling
function.

Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 utest/tracefs-utest.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/utest/tracefs-utest.c b/utest/tracefs-utest.c
index 9cfafdbd039c..0f4075679ec4 100644
--- a/utest/tracefs-utest.c
+++ b/utest/tracefs-utest.c
@@ -983,7 +983,7 @@ struct test_synth {
 	char *match_name;
 };
 
-static void test_synth_compare(struct test_synth *synth, struct tracefs_dynevent **devents)
+static void test_synth_compare(struct test_synth *sevents, struct tracefs_dynevent **devents)
 {
 	enum tracefs_dynevent_type stype;
 	char *format;
@@ -996,9 +996,9 @@ static void test_synth_compare(struct test_synth *synth, struct tracefs_dynevent
 		CU_TEST(stype == TRACEFS_DYNEVENT_SYNTH);
 		if (stype != TRACEFS_DYNEVENT_SYNTH)
 			continue;
-		CU_TEST(event && synth[i].name && strcmp(event, synth[i].name) == 0);
-		if (synth[i].match_name) {
-			CU_TEST(strstr(format, synth[i].match_name) != NULL);
+		CU_TEST(event && sevents[i].name && strcmp(event, sevents[i].name) == 0);
+		if (sevents[i].match_name) {
+			CU_TEST(strstr(format, sevents[i].match_name) != NULL);
 		}
 		free(event);
 		free(format);
-- 
2.39.2


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-30  6:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-30  6:21 [PATCH] libtracefs/utest: Do not use synth for test_synth element Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox