Linux Trace Development
 help / color / mirror / Atom feed
* [PATCH] libtraceeval task-eval: Fix passing wrong teval to helper function
@ 2024-10-25 10:05 Steven Rostedt
  0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2024-10-25 10:05 UTC (permalink / raw)
  To: Linux Trace Devel

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

The addition of helper functions was supposed to make the code simpler,
but instead it ended up passing the wrong teval into one of the helper
functions due to a cut-and-paste error.

Pass the teval_cpus descriptor to the cpu helper function and not the
teval_threads descriptor.

Fixes: f38b05e1 ("libtraceeval task-eval: Simplify logic by adding more helper functions")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 samples/task-eval.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/task-eval.c b/samples/task-eval.c
index 178936d..5b6da1a 100644
--- a/samples/task-eval.c
+++ b/samples/task-eval.c
@@ -677,7 +677,7 @@ static void sched_out(struct task_data *tdata, const char *comm,
 	/* Update the individual thread as well */
 
 	insert_thread_data(pdata->teval_threads, pid, RUNNING, prio, delta, record->ts);
-	insert_cpu_data(pdata->teval_threads, record->cpu, RUNNING, delta, record->ts);
+	insert_cpu_data(pdata->teval_cpus, record->cpu, RUNNING, delta, record->ts);
 }
 
 static void sched_in(struct task_data *tdata, const char *comm,
-- 
2.45.2


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2024-10-25 10:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-25 10:05 [PATCH] libtraceeval task-eval: Fix passing wrong teval to helper function Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox