Linux Trace Development
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, Emil Thorsoe <ethorsoe@tuxera.com>
Subject: Re: [PATCH] libtraceevent utest: exit test if mmap fails
Date: Fri, 29 May 2026 14:41:24 -0400	[thread overview]
Message-ID: <20260529144124.14954a5f@fedora> (raw)
In-Reply-To: <20260526184219.408223-1-sudipm.mukherjee@gmail.com>

On Tue, 26 May 2026 19:42:19 +0100
Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:

> CU_TEST() continues execution even if the test fails. It just records
> that the test has failed and moves on.
> So, when libtraceevent is built in a chroot, it can open
> /sys/kernel/btf/vmlinux but fails in mmap stage and since CU_TEST()
> does not stop so we get a segfault when tep_load_btf() tries to use
> the mapped buffer.
> 
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

Thanks, but the real fix is here and I'm applying that one:

  https://lore.kernel.org/all/d6e07cd6-cb78-4119-a048-920ca58b4830@tuxera.com/

-- Steve

  reply	other threads:[~2026-05-29 18:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 18:42 [PATCH] libtraceevent utest: exit test if mmap fails Sudip Mukherjee
2026-05-29 18:41 ` Steven Rostedt [this message]
2026-06-15 19:25   ` Sudip Mukherjee
2026-06-16 20:48     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260529144124.14954a5f@fedora \
    --to=rostedt@goodmis.org \
    --cc=ethorsoe@tuxera.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox