Linux Trace Development
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, Emil Thorsoe <ethorsoe@tuxera.com>
Subject: Re: [PATCH] libtraceevent utest: exit test if mmap fails
Date: Tue, 16 Jun 2026 16:48:12 -0400	[thread overview]
Message-ID: <20260616164812.5ecda840@fedora> (raw)
In-Reply-To: <CADVatmMUERxEkbURZuZfTw+UYB2YCMVxK9nvc-z-u5kKNHxM=g@mail.gmail.com>

On Mon, 15 Jun 2026 20:25:08 +0100
Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:

> Hi Steve,
> 
> On Fri, 29 May 2026 at 19:41, Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Tue, 26 May 2026 19:42:19 +0100
> > Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
> >  
> > > CU_TEST() continues execution even if the test fails. It just records
> > > that the test has failed and moves on.
> > > So, when libtraceevent is built in a chroot, it can open
> > > /sys/kernel/btf/vmlinux but fails in mmap stage and since CU_TEST()
> > > does not stop so we get a segfault when tep_load_btf() tries to use
> > > the mapped buffer.
> > >
> > > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>  
> >
> > Thanks, but the real fix is here and I'm applying that one:
> >
> >   https://lore.kernel.org/all/d6e07cd6-cb78-4119-a048-920ca58b4830@tuxera.com/  
> 
> Tried it today, and the test still fails for me.

Thanks for letting me know. I currently just started a new job and I'm
a bit overwhelmed. It may be a couple more weeks before I get to this.

-- Steve

      reply	other threads:[~2026-06-16 20:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 18:42 [PATCH] libtraceevent utest: exit test if mmap fails Sudip Mukherjee
2026-05-29 18:41 ` Steven Rostedt
2026-06-15 19:25   ` Sudip Mukherjee
2026-06-16 20:48     ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260616164812.5ecda840@fedora \
    --to=rostedt@goodmis.org \
    --cc=ethorsoe@tuxera.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox