Linux Trace Kernel
 help / color / mirror / Atom feed
* [PATCH] ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint
@ 2026-11-10 13:20 Temitope obabi
  2026-11-11  1:59 ` sashiko-bot
  2026-11-17  1:09 ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Temitope obabi @ 2026-11-10 13:20 UTC (permalink / raw)
  To: Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
	Temitope obabi, Amadeusz Sławiński, Cezary Rojewski,
	Mark Brown, linux-kernel, linux-trace-kernel

The sst_ipc_inbox_rdata tracepoint has had no callers since commit
970d299b0a0a ("ASoC: Intel: Remove unused code") removed the last one.

Tracepoints that are defined take up around 5K each, even if they are
not used. Remove this unused tracepoint.

Fixes: 970d299b0a0a ("ASoC: Intel: Remove unused code")
Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
---
 include/trace/events/intel-sst.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/include/trace/events/intel-sst.h b/include/trace/events/intel-sst.h
index 0416e91f8181..ae7c269b0824 100644
--- a/include/trace/events/intel-sst.h
+++ b/include/trace/events/intel-sst.h
@@ -69,14 +69,6 @@ DECLARE_EVENT_CLASS(sst_ipc_mailbox,
 		(unsigned int)__entry->offset, (unsigned int)__entry->val)
 );
 
-DEFINE_EVENT(sst_ipc_mailbox, sst_ipc_inbox_rdata,
-
-	TP_PROTO(unsigned int offset, unsigned int val),
-
-	TP_ARGS(offset, val)
-
-);
-
 DEFINE_EVENT(sst_ipc_mailbox, sst_ipc_inbox_wdata,
 
 	TP_PROTO(unsigned int offset, unsigned int val),
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint
  2026-11-10 13:20 [PATCH] ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint Temitope obabi
@ 2026-11-11  1:59 ` sashiko-bot
  2026-11-17  1:09 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-11-11  1:59 UTC (permalink / raw)
  To: Temitope obabi, linux-trace-kernel

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: Intel: incomplete removal of unused intel-sst.h tracepoint
  header
--

commit 47a1bdb679fab28a368c73c42b9adeadd92a9bea
Author: Temitope obabi <obabitemitope765@gmail.com>

> ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint
>
> The sst_ipc_inbox_rdata tracepoint has had no callers since commit
> 970d299b0a0a ("ASoC: Intel: Remove unused code") removed the last one.
>
> Tracepoints that are defined take up around 5K each, even if they are
> not used. Remove this unused tracepoint.
>
> Fixes: 970d299b0a0a ("ASoC: Intel: Remove unused code")
> Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>

> diff --git a/include/trace/events/intel-sst.h b/include/trace/events/intel-sst.h
> index 0416e91f81817..ae7c269b0824f 100644
> --- a/include/trace/events/intel-sst.h
> +++ b/include/trace/events/intel-sst.h
> @@ -69,14 +69,6 @@ DECLARE_EVENT_CLASS(sst_ipc_mailbox,
>  		(unsigned int)__entry->offset, (unsigned int)__entry->val)
>  );
>  
> -DEFINE_EVENT(sst_ipc_mailbox, sst_ipc_inbox_rdata,
> -
> -	TP_PROTO(unsigned int offset, unsigned int val),
> -
> -	TP_ARGS(offset, val)
> -
> -);
> -
>  DEFINE_EVENT(sst_ipc_mailbox, sst_ipc_inbox_wdata,
>  
>  	TP_PROTO(unsigned int offset, unsigned int val),

[Severity: Low]
Should the entire include/trace/events/intel-sst.h header be removed
instead of just sst_ipc_inbox_rdata?

Commit 970d299b0a0a ("ASoC: Intel: Remove unused code") deleted
sound/soc/intel/common/sst-dsp.c, which was the only file in the tree that
defined CREATE_TRACE_POINTS and included trace/events/intel-sst.h.  The
remaining nine DEFINE_EVENT definitions and three DECLARE_EVENT_CLASS
definitions in this header also have no callers.  Because no translation
unit includes trace/events/intel-sst.h, none of these tracepoints are
compiled into the kernel image or consume memory, so the commit message
claim and the Fixes: tag are also inaccurate for this cleanup.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110132013.732-1-obabitemitope765@gmail.com?part=1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint
  2026-11-10 13:20 [PATCH] ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint Temitope obabi
  2026-11-11  1:59 ` sashiko-bot
@ 2026-11-17  1:09 ` Mark Brown
  2026-11-17 14:02   ` Cezary Rojewski
  1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2026-11-17  1:09 UTC (permalink / raw)
  To: Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
	Amadeusz Sławiński, Cezary Rojewski, linux-kernel,
	linux-trace-kernel, Temitope obabi

On Tue, 10 Nov 2026 15:20:07 +0200, Temitope obabi wrote:
> ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.5

Thanks!

[1/1] ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint
      https://git.kernel.org/broonie/sound/c/c5afacef0c09

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint
  2026-11-17  1:09 ` Mark Brown
@ 2026-11-17 14:02   ` Cezary Rojewski
  0 siblings, 0 replies; 4+ messages in thread
From: Cezary Rojewski @ 2026-11-17 14:02 UTC (permalink / raw)
  To: Mark Brown, Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
	Amadeusz Sławiński, linux-kernel, linux-trace-kernel,
	Temitope obabi

On 11/17/2026 2:09 AM, Mark Brown wrote:
> On Tue, 10 Nov 2026 15:20:07 +0200, Temitope obabi wrote:
>> ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.5


There is a separate thread [1] started by the author that will conflict
with this very change. Ideally only the "remove whole header" version
should be applied.

[1]:
https://lore.kernel.org/all/20261111223102.1310-1-obabitemitope765@gmail.com/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-17 14:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-10 13:20 [PATCH] ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint Temitope obabi
2026-11-11  1:59 ` sashiko-bot
2026-11-17  1:09 ` Mark Brown
2026-11-17 14:02   ` Cezary Rojewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox