From: Steven Rostedt <rostedt@goodmis.org>
To: sunying@nj.iscas.ac.cn
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] trace/recordmcount: add the necessary dependencies
Date: Tue, 25 Apr 2023 15:01:54 -0400 [thread overview]
Message-ID: <20230425150154.255b238a@gandalf.local.home> (raw)
In-Reply-To: <20230412101840.13601-1-sunying@nj.iscas.ac.cn>
On Wed, 12 Apr 2023 18:18:40 +0800
sunying@nj.iscas.ac.cn wrote:
> From: Ying Sun <sunying@nj.iscas.ac.cn>
>
> HAVE_C_RECORDMCOUNT is used only if the condition
> "ifdef CONFIG_FTRACE_MCOUNT_USE_RECORDMCOUNT" is met in the Makefile,
> adding a dependency constraint on this configuration option
> to prevent it from being set ‘y' but not taking effect.
Why do we care?
The HAVE_* configs are only there to allow architectures to say if they
support it or not. They usually have no effect themselves\ and require
other configs to be enabled something. This is "Works as designed".
-- Steve
>
> Suggested-by: Yanjie Ren <renyanjie01@gmail.com>
> Signed-off-by: Ying Sun <sunying@nj.iscas.ac.cn>
> ---
> kernel/trace/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 8cf97fa4a4b3..69bb70b6bdd7 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -94,6 +94,7 @@ config HAVE_OBJTOOL_NOP_MCOUNT
>
> config HAVE_C_RECORDMCOUNT
> bool
> + depends on FTRACE_MCOUNT_USE_RECORDMCOUNT
> help
> C version of recordmcount available?
>
prev parent reply other threads:[~2023-04-25 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 10:18 [PATCH] trace/recordmcount: add the necessary dependencies sunying
2023-04-25 19:01 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425150154.255b238a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=sunying@nj.iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox