* [PATCH] trace/recordmcount: add the necessary dependencies
@ 2023-04-12 10:18 sunying
2023-04-25 19:01 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: sunying @ 2023-04-12 10:18 UTC (permalink / raw)
To: rostedt, mhiramat; +Cc: linux-kernel, linux-trace-kernel, Ying Sun
From: Ying Sun <sunying@nj.iscas.ac.cn>
HAVE_C_RECORDMCOUNT is used only if the condition
"ifdef CONFIG_FTRACE_MCOUNT_USE_RECORDMCOUNT" is met in the Makefile,
adding a dependency constraint on this configuration option
to prevent it from being set ‘y' but not taking effect.
Suggested-by: Yanjie Ren <renyanjie01@gmail.com>
Signed-off-by: Ying Sun <sunying@nj.iscas.ac.cn>
---
kernel/trace/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 8cf97fa4a4b3..69bb70b6bdd7 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -94,6 +94,7 @@ config HAVE_OBJTOOL_NOP_MCOUNT
config HAVE_C_RECORDMCOUNT
bool
+ depends on FTRACE_MCOUNT_USE_RECORDMCOUNT
help
C version of recordmcount available?
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] trace/recordmcount: add the necessary dependencies
2023-04-12 10:18 [PATCH] trace/recordmcount: add the necessary dependencies sunying
@ 2023-04-25 19:01 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2023-04-25 19:01 UTC (permalink / raw)
To: sunying; +Cc: mhiramat, linux-kernel, linux-trace-kernel
On Wed, 12 Apr 2023 18:18:40 +0800
sunying@nj.iscas.ac.cn wrote:
> From: Ying Sun <sunying@nj.iscas.ac.cn>
>
> HAVE_C_RECORDMCOUNT is used only if the condition
> "ifdef CONFIG_FTRACE_MCOUNT_USE_RECORDMCOUNT" is met in the Makefile,
> adding a dependency constraint on this configuration option
> to prevent it from being set ‘y' but not taking effect.
Why do we care?
The HAVE_* configs are only there to allow architectures to say if they
support it or not. They usually have no effect themselves\ and require
other configs to be enabled something. This is "Works as designed".
-- Steve
>
> Suggested-by: Yanjie Ren <renyanjie01@gmail.com>
> Signed-off-by: Ying Sun <sunying@nj.iscas.ac.cn>
> ---
> kernel/trace/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 8cf97fa4a4b3..69bb70b6bdd7 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -94,6 +94,7 @@ config HAVE_OBJTOOL_NOP_MCOUNT
>
> config HAVE_C_RECORDMCOUNT
> bool
> + depends on FTRACE_MCOUNT_USE_RECORDMCOUNT
> help
> C version of recordmcount available?
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-25 19:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-12 10:18 [PATCH] trace/recordmcount: add the necessary dependencies sunying
2023-04-25 19:01 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox