* [PATCH] include: events: remove spaces after '(' and before ')'
[not found] <20230719030939.18448-1-xujianghui@cdjrlc.com>
@ 2023-07-19 3:21 ` sunran001
2023-07-23 15:12 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: sunran001 @ 2023-07-19 3:21 UTC (permalink / raw)
To: rostedt, mhiramat; +Cc: linux-kernel, linux-trace-kernel
Fix four occurrences of the checkpatch error:
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
include/trace/events/nmi.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/trace/events/nmi.h b/include/trace/events/nmi.h
index 18e0411398ba..99abd0bc8ebd 100644
--- a/include/trace/events/nmi.h
+++ b/include/trace/events/nmi.h
@@ -15,9 +15,9 @@ TRACE_EVENT(nmi_handler,
TP_ARGS(handler, delta_ns, handled),
TP_STRUCT__entry(
- __field( void *, handler )
- __field( s64, delta_ns)
- __field( int, handled )
+ __field(void *, handler)
+ __field(s64, delta_ns)
+ __field(int, handled)
),
TP_fast_assign(
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] include: events: remove spaces after '(' and before ')'
2023-07-19 3:21 ` [PATCH] include: events: remove spaces after '(' and before ')' sunran001
@ 2023-07-23 15:12 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2023-07-23 15:12 UTC (permalink / raw)
To: sunran001; +Cc: mhiramat, linux-kernel, linux-trace-kernel
On Wed, 19 Jul 2023 11:21:03 +0800
sunran001@208suo.com wrote:
> Fix four occurrences of the checkpatch error:
>
> ERROR: space prohibited after that open parenthesis '('
> ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> include/trace/events/nmi.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/trace/events/nmi.h b/include/trace/events/nmi.h
> index 18e0411398ba..99abd0bc8ebd 100644
> --- a/include/trace/events/nmi.h
> +++ b/include/trace/events/nmi.h
> @@ -15,9 +15,9 @@ TRACE_EVENT(nmi_handler,
> TP_ARGS(handler, delta_ns, handled),
>
> TP_STRUCT__entry(
> - __field( void *, handler )
> - __field( s64, delta_ns)
> - __field( int, handled )
> + __field(void *, handler)
> + __field(s64, delta_ns)
> + __field(int, handled)
NACK!
Which version looks better?
checkpatch.pl fails horribly on TRACE_EVENT macros. DON'T MODIFY THEM!
-- Steve
> ),
>
> TP_fast_assign(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-23 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230719030939.18448-1-xujianghui@cdjrlc.com>
2023-07-19 3:21 ` [PATCH] include: events: remove spaces after '(' and before ')' sunran001
2023-07-23 15:12 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox