From: Steven Rostedt <rostedt@goodmis.org>
To: Dmytro Maluka <dmaluka@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Sean Paul <seanpaul@chromium.org>, Arun Easi <aeasi@marvell.com>,
Daniel Wagner <dwagner@suse.de>
Subject: Re: [RFC][PATCH] tracing: Allow creating instances with specified system events
Date: Tue, 28 Nov 2023 09:20:29 -0500 [thread overview]
Message-ID: <20231128092029.342f5f03@gandalf.local.home> (raw)
In-Reply-To: <ZWXntcHNflkbrxd7@google.com>
On Tue, 28 Nov 2023 14:14:29 +0100
Dmytro Maluka <dmaluka@chromium.org> wrote:
> This limitation will cause (unrelated) events created by modules that
> are insmoded after creating the instance to be also added to the
> instance. Why not filter those as well?
I did think of that. But that would be a separate patch. Where I would save
the string that is passed in, and whenever a new module is loaded, it would
only add the events if the events' system matches in the string. This would
also allow adding event systems that do not yet exist.
>
> Besides that, the change looks nice to me.
Thanks, I'll make it into a more formal patch set.
-- Steve
next prev parent reply other threads:[~2023-11-28 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 22:41 [RFC][PATCH] tracing: Allow creating instances with specified system events Steven Rostedt
2023-11-27 22:50 ` Steven Rostedt
2023-11-28 8:49 ` Daniel Wagner
2023-11-28 13:14 ` Dmytro Maluka
2023-11-28 14:20 ` Steven Rostedt [this message]
2023-11-28 14:54 ` Steven Rostedt
2023-11-28 15:17 ` Masami Hiramatsu
2023-11-28 15:35 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128092029.342f5f03@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=aeasi@marvell.com \
--cc=dmaluka@chromium.org \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox