* [PATCH][next] blktrace: remove redundant return at end of function
@ 2024-12-04 15:04 Colin Ian King
2024-12-04 16:33 ` Jens Axboe
2024-12-05 1:20 ` Ming Lei
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2024-12-04 15:04 UTC (permalink / raw)
To: Jens Axboe, Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
Ming Lei, linux-block, linux-trace-kernel
Cc: kernel-janitors, linux-kernel
A recent change added return 0 before an existing return statement
at the end of function blk_trace_setup. The final return is now
redundant, so remove it.
Fixes: 64d124798244 ("blktrace: move copy_[to|from]_user() out of ->debugfs_lock")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
kernel/trace/blktrace.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 18c81e6aa496..3679a6d18934 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -639,8 +639,6 @@ int blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
return -EFAULT;
}
return 0;
-
- return ret;
}
EXPORT_SYMBOL_GPL(blk_trace_setup);
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][next] blktrace: remove redundant return at end of function
2024-12-04 15:04 [PATCH][next] blktrace: remove redundant return at end of function Colin Ian King
@ 2024-12-04 16:33 ` Jens Axboe
2024-12-05 1:20 ` Ming Lei
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2024-12-04 16:33 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers, Ming Lei,
linux-block, linux-trace-kernel, Colin Ian King
Cc: kernel-janitors, linux-kernel
On Wed, 04 Dec 2024 15:04:50 +0000, Colin Ian King wrote:
> A recent change added return 0 before an existing return statement
> at the end of function blk_trace_setup. The final return is now
> redundant, so remove it.
>
> Fixes: 64d124798244 ("blktrace: move copy_[to|from]_user() out of ->debugfs_lock")
>
>
> [...]
Applied, thanks!
[1/1] blktrace: remove redundant return at end of function
commit: 62047e8946da6269cf9bcec578298dd194ee4b7f
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] blktrace: remove redundant return at end of function
2024-12-04 15:04 [PATCH][next] blktrace: remove redundant return at end of function Colin Ian King
2024-12-04 16:33 ` Jens Axboe
@ 2024-12-05 1:20 ` Ming Lei
1 sibling, 0 replies; 3+ messages in thread
From: Ming Lei @ 2024-12-05 1:20 UTC (permalink / raw)
To: Colin Ian King
Cc: Jens Axboe, Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
linux-block, linux-trace-kernel, kernel-janitors, linux-kernel
On Wed, Dec 4, 2024 at 11:05 PM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> A recent change added return 0 before an existing return statement
> at the end of function blk_trace_setup. The final return is now
> redundant, so remove it.
>
> Fixes: 64d124798244 ("blktrace: move copy_[to|from]_user() out of ->debugfs_lock")
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> kernel/trace/blktrace.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index 18c81e6aa496..3679a6d18934 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -639,8 +639,6 @@ int blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
> return -EFAULT;
> }
> return 0;
> -
> - return ret;
> }
> EXPORT_SYMBOL_GPL(blk_trace_setup);
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-05 1:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-04 15:04 [PATCH][next] blktrace: remove redundant return at end of function Colin Ian King
2024-12-04 16:33 ` Jens Axboe
2024-12-05 1:20 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox